Changeset 69538 in vbox

Timestamp:

Oct 31, 2017 11:48:08 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118885

Message:

FE/Qt: bugref:8901: Snapshot Pane: Cleanup error handling a bit, no error icon for take-snapshot case, only for edit-snapshot case.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector

Files:

• UISnapshotDetailsWidget.cpp (modified) (7 diffs)
• UISnapshotDetailsWidget.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISnapshotDetailsWidget.cpp

@@ -521 +521 @@
     , m_pLayoutDetails(0)
     , m_pScrollAreaDetails(0)
-    , m_fSnapshotNameEdited(false)
 {
     /* Prepare: */
@@ -529 +528 @@
 void UISnapshotDetailsWidget::setData(const CMachine &comMachine)
 {
-    /* Reset defaults: */
-    m_fSnapshotNameEdited = false;
-
     /* Cache old/new data: */
     m_oldData = UIDataSnapshot();
@@ -548 +544 @@
 void UISnapshotDetailsWidget::setData(const UIDataSnapshot &data, const CSnapshot &comSnapshot)
 {
-    /* Reset defaults: */
-    m_fSnapshotNameEdited = false;
-
     /* Cache old/new data: */
     m_oldData = data;
@@ -567 +560 @@
 void UISnapshotDetailsWidget::clearData()
 {
-    /* Reset defaults: */
-    m_fSnapshotNameEdited = false;
-
     /* Reset old/new data: */
     m_oldData = UIDataSnapshot();
@@ -662 +652 @@
             setToolTip(tr("Apply Changes (%1)").arg(m_pButtonBox->button(QDialogButtonBox::Ok)->shortcut().toString()));
     }
-}
-
-void UISnapshotDetailsWidget::sltHandleNameEdit()
-{
-    m_fSnapshotNameEdited = true;
 }
 
@@ -784 +769 @@
                     policy.setHorizontalStretch(1);
                     m_pEditorName->setSizePolicy(policy);
-                    connect(m_pEditorName, &QLineEdit::textEdited,
-                            this, &UISnapshotDetailsWidget::sltHandleNameEdit);
                     connect(m_pEditorName, &QLineEdit::textChanged,
                             this, &UISnapshotDetailsWidget::sltHandleNameChange);
@@ -1092 +1075 @@
     {
         const bool fError = m_newData.m_strName.isEmpty();
-        m_pErrorPaneName->setVisible(fError && m_fSnapshotNameEdited);
+        m_pErrorPaneName->setVisible(fError && m_comMachine.isNull());
     }
     if (!pWidget || pWidget == m_pErrorPaneDescription)

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISnapshotDetailsWidget.h

@@ -108 +108 @@
 private slots:
 
-    /** Handles snapshot name edit. */
-    void sltHandleNameEdit();
     /** Handles snapshot name change. */
     void sltHandleNameChange();
@@ -236 +234 @@
     /** Holds the details element map. */
     QMap<DetailsElementType, UISnapshotDetailsElement*> m_details;
-
-    /** Holds whether the snapshot name was edited. */
-    bool  m_fSnapshotNameEdited;
 };