Changeset 69578 in vbox for trunk/src/VBox/ValidationKit/common

Timestamp:

Nov 4, 2017 10:19:34 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118928

Message:

better processExists() implementations for windows.

File:

• trunk/src/VBox/ValidationKit/common/utils.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/common/utils.py

@@ -51 +51 @@
     import win32file;           # pylint: disable=import-error
     import win32process;        # pylint: disable=import-error
+    import winerror;            # pylint: disable=import-error
+    import pywintypes;          # pylint: disable=import-error
 else:
     import signal;
@@ -783 +785 @@
     if sys.platform == 'win32':
         fRc = False;
+        # We try open the process for waiting since this is generally only forbidden in a very few cases.
         try:
-            hProcess = win32api.OpenProcess(win32con.PROCESS_QUERY_INFORMATION, False, uPid);   # pylint: disable=no-member
-        except:
+            hProcess = win32api.OpenProcess(win32con.SYNCHRONIZE, False, uPid);     # pylint: disable=no-member
+        except pywintypes.error as oXcpt:                                           # pylint: disable=no-member
+            if oXcpt.winerror == winerror.ERROR_ACCESS_DENIED:
+                fRc = True;
+        except Exception as oXcpt:
             pass;
         else:
-            hProcess.Close(); # win32api.CloseHandle(hProcess);
+            hProcess.Close();
             fRc = True;
     else:
@@ -794 +800 @@
             os.kill(uPid, 0);
             fRc = True;
-        except:
+        except: ## @todo check error code.
             fRc = False;
     return fRc;