Changeset 69578 in vbox for trunk/src/VBox/ValidationKit/testdriver

Timestamp:

Nov 4, 2017 10:19:34 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

118928

Message:

better processExists() implementations for windows.

File:

• trunk/src/VBox/ValidationKit/testdriver/winbase.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testdriver/winbase.py

@@ -41 +41 @@
 import win32event;          # pylint: disable=import-error
 import win32process;        # pylint: disable=import-error
+import winerror;            # pylint: disable=import-error
+import pywintypes;          # pylint: disable=import-error
 
 # Validation Kit imports.
@@ -112 +114 @@
 def processExists(uPid):
     """ The Windows version of base.processExists """
-    # pylint: disable=no-member
-    fRc = False;
-    try:
-        hProcess = win32api.OpenProcess(win32con.PROCESS_QUERY_INFORMATION, False, uPid);
-    except:
+    # We try open the process for waiting since this is generally only forbidden in a very few cases.
+    try:
+        hProcess = win32api.OpenProcess(win32con.SYNCHRONIZE, False, uPid);     # pylint: disable=no-member
+    except pywintypes.error as oXcpt:                                           # pylint: disable=no-member
+        if oXcpt.winerror == winerror.ERROR_INVALID_PARAMETER:
+            return False;
+        if oXcpt.winerror != winerror.ERROR_ACCESS_DENIED:
+            reporter.logXcpt('uPid=%s oXcpt=%s' % (uPid, oXcpt));
+            return False;
+        reporter.logXcpt('uPid=%s oXcpt=%s' % (uPid, oXcpt));
+    except Exception as oXcpt:
         reporter.logXcpt('uPid=%s' % (uPid,));
+        return False;
     else:
         hProcess.Close(); #win32api.CloseHandle(hProcess)
-        fRc = True;
-    return fRc;
+    return True;
 
 def processCheckPidAndName(uPid, sName):