Changeset 69724 in vbox for trunk

Timestamp:

Nov 17, 2017 1:20:17 PM (7 years ago)

Author:

vboxsync

Message:

VideoRec: Added a bit more error logging going into the release log.

Location:

trunk/src/VBox/Main/src-client

Files:

• DisplayImpl.cpp (modified) (1 diff)
• VideoRec.cpp (modified) (5 diffs)

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -2765 +2765 @@
             rc = rc2;
     }
+
+    if (RT_FAILURE(rc))
+        LogRel(("VideoRec: Failed to start video recording (%Rrc)\n", rc));
+
     return rc;
 }

trunk/src/VBox/Main/src-client/VideoRec.cpp

@@ -207 +207 @@
         bool                fHasVideoData;
 #endif
+        /** Number of failed attempts to encode the current video frame in a row. */
+        uint16_t            cFailedEncodingFrames;
     } Video;
 } VIDEORECSTREAM, *PVIDEORECSTREAM;
@@ -1044 +1046 @@
 
     pStream->pCtx          = pCtx;
+
     /** @todo Make the following parameters configurable on a per-stream basis? */
-    pStream->Video.uWidth  = pCfg->Video.uWidth;
-    pStream->Video.uHeight = pCfg->Video.uHeight;
+    pStream->Video.uWidth                = pCfg->Video.uWidth;
+    pStream->Video.uHeight               = pCfg->Video.uHeight;
+    pStream->Video.cFailedEncodingFrames = 0;
 
 #ifndef VBOX_VIDEOREC_WITH_QUEUE
@@ -1174 +1178 @@
     if (rcv != VPX_CODEC_OK)
     {
-        LogFlow(("Failed to initialize VP8 encoder: %s\n", vpx_codec_err_to_string(rcv)));
+        LogRel(("VideoRec: Failed to initialize VP8 encoder: %s\n", vpx_codec_err_to_string(rcv)));
         return VERR_INVALID_PARAMETER;
     }
@@ -1180 +1184 @@
     if (!vpx_img_alloc(&pVC->VPX.RawImage, VPX_IMG_FMT_I420, pCfg->Video.uWidth, pCfg->Video.uHeight, 1))
     {
-        LogFlow(("Failed to allocate image %RU32x%RU32\n", pCfg->Video.uWidth, pCfg->Video.uHeight));
+        LogRel(("VideoRec: Failed to allocate image %RU32x%RU32\n", pCfg->Video.uWidth, pCfg->Video.uHeight));
         return VERR_NO_MEMORY;
     }
@@ -1338 +1342 @@
     if (rcv != VPX_CODEC_OK)
     {
-        LogFunc(("Failed to encode video frame: %s\n", vpx_codec_err_to_string(rcv)));
-        return VERR_GENERAL_FAILURE;
-    }
+        if (pStream->Video.cFailedEncodingFrames++ < 64)
+        {
+            LogRel(("VideoRec: Failed to encode video frame: %s\n", vpx_codec_err_to_string(rcv)));
+            return VERR_GENERAL_FAILURE;
+        }
+    }
+
+    pStream->Video.cFailedEncodingFrames = 0;
 
     vpx_codec_iter_t iter = NULL;