Changeset 69727 in vbox for trunk

Timestamp:

Nov 17, 2017 7:26:40 PM (7 years ago)

Author:

vboxsync

Message:

VBoxProxyStub: Untested SDS code cleanups.

File:

• trunk/src/VBox/Main/src-all/win/VBoxProxyStub.c (modified) (1 diff)

trunk/src/VBox/Main/src-all/win/VBoxProxyStub.c

@@ -2297 +2297 @@
 
 
-BOOL IsInstalledWindowsService(const WCHAR* wszServiceName)
-{
-    BOOL bResult = FALSE;
-    SC_HANDLE hSCM;
-    SC_HANDLE hService;
-
-    hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+#ifdef VBOX_WITH_SDS
+
+static BOOL vbpsIsInstalledWindowsService(const WCHAR *pwszServiceName)
+{
+    BOOL fRet = FALSE;
+    SC_HANDLE hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
     if (hSCM != NULL)
     {
-        hService = OpenService(hSCM, wszServiceName, SERVICE_QUERY_CONFIG);
+        SC_HANDLE hService = OpenService(hSCM, pwszServiceName, SERVICE_QUERY_CONFIG);
         if (hService != NULL)
         {
-            bResult = TRUE;
             CloseServiceHandle(hService);
+            fRet = TRUE;
         }
         CloseServiceHandle(hSCM);
     }
-    return bResult;
-}
-
-
-BOOL InstallWindowsService(const WCHAR* wszVBoxDir,
-    const WCHAR* wszServiceModule,
-    const WCHAR* wszServiceName,
-    const WCHAR* wszServiceDisplayName,
-    const WCHAR* wszServiceDescription
-)
-{
-    #define QUOTES_SPACE 2
-
-    WCHAR szFilePath[MAX_PATH + QUOTES_SPACE];
-    size_t dirLen;
-    size_t moduleLen;
-    SC_HANDLE hSCM;
-    SC_HANDLE hService;
-    SERVICE_DESCRIPTION sd;
-
-    if (IsInstalledWindowsService(wszServiceName))
-        return TRUE;
-
-    // Make the executable file path
-    dirLen = RTUtf16Len(wszVBoxDir);
-    moduleLen = RTUtf16Len(wszServiceModule);
-
-    if (   dirLen + moduleLen + 2 >= MAX_PATH + QUOTES_SPACE
-        || !RT_SUCCESS(RTUtf16Copy(szFilePath + 1, MAX_PATH + QUOTES_SPACE - 1, wszVBoxDir))
-        || !RT_SUCCESS(RTUtf16Copy(szFilePath + dirLen + 1, MAX_PATH + QUOTES_SPACE - dirLen - 1, wszServiceModule)))
-    {
-        LogWarnFunc(("Error: The path to a windows service module is too long\n"));
-        return FALSE;
-    }
-
-    // Quote the FilePath before calling CreateService
-    szFilePath[0] = L'\"';
-    szFilePath[dirLen + moduleLen + 1] = L'\"';
-    szFilePath[dirLen + moduleLen + 2] = 0;
-
-    hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
-    if (hSCM == NULL)
-    {
-        LogWarnFunc(("Error: Could not open Service Manager\n"));
-        Assert(0);
-        return FALSE;
-    }
-
-    hService = CreateService(hSCM, wszServiceName, wszServiceDisplayName,
-                             SERVICE_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS,
-                             SERVICE_DEMAND_START, SERVICE_ERROR_NORMAL,
-                             szFilePath, NULL, NULL, L"RPCSS\0", NULL, NULL);
-    if (hService == NULL)
-    {
-        CloseServiceHandle(hSCM);
-        LogWarnFunc(("Error: Could not start service\n"));
-        Assert(0);
-        return FALSE;
-    }
-
-    sd.lpDescription = (LPWSTR)wszServiceDescription;
-    if (!ChangeServiceConfig2(hService, SERVICE_CONFIG_DESCRIPTION, &sd))
-    {
-        LogWarnFunc(("Error: could not set service description. code: %x\n",
-                    GetLastError()));
-        Assert(0);
-    }
-
-    CloseServiceHandle(hService);
-    CloseServiceHandle(hSCM);
-    return TRUE;
-}
-
-BOOL UninstallWindowsService(const WCHAR* wszServiceName)
-{
-    SC_HANDLE hSCM;
-    SC_HANDLE hService;
-    SERVICE_STATUS status;
-    BOOL bRet;
-    BOOL bDelete;
-
-    if (!IsInstalledWindowsService(wszServiceName))
-        return TRUE;
-
-    hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
-    if (hSCM == NULL)
-    {
-        LogWarnFunc(("Error: Could not open Service Manager\n"));
-        Assert(0);
-        return FALSE;
-    }
-
-    hService = OpenService(hSCM, wszServiceName, SERVICE_STOP | DELETE);
-    if (hService == NULL)
-    {
-        CloseServiceHandle(hSCM);
-        hSCM = NULL;
-        LogWarnFunc(("Error: Could not open service\n"));
-        Assert(0);
-        return FALSE;
-    }
-
-    bRet = ControlService(hService, SERVICE_CONTROL_STOP, &status);
-    if (!bRet)
-    {
-        DWORD dwError = GetLastError();
-        if (!(   dwError == ERROR_SERVICE_NOT_ACTIVE
-              || (   dwError == ERROR_SERVICE_CANNOT_ACCEPT_CTRL
-                  && status.dwCurrentState == SERVICE_STOP_PENDING)))
+    return fRet;
+}
+
+
+BOOL vbpsInstallWindowsService(const WCHAR *pwszVBoxDir, const WCHAR *pwszServiceModule, const WCHAR *pwszServiceName,
+                               const WCHAR *pwszServiceDisplayName, const WCHAR *pwszServiceDescription)
+{
+    BOOL fRet = vbpsIsInstalledWindowsService(pwszServiceName);
+    if (!fRet)
+    {
+        /* Make double quoted executable file path. ASSUMES pwszVBoxDir ends with a slash! */
+        WCHAR wszFilePath[MAX_PATH + 2];
+        int rc = RTUtf16CopyAscii(wszFilePath, RT_ELEMENTS(wszFilePath), "\"");
+        if (RT_SUCCESS(rc))
+            rc = RTUtf16Cat(wszFilePath, RT_ELEMENTS(wszFilePath), pwszVBoxDir);
+        if (RT_SUCCESS(rc))
+            rc = RTUtf16Cat(wszFilePath, RT_ELEMENTS(wszFilePath), pwszServiceModule);
+        if (RT_SUCCESS(rc))
+            rc = RTUtf16CatAscii(wszFilePath, RT_ELEMENTS(wszFilePath), "\"");
+        if (RT_SUCCESS(rc))
         {
+            SC_HANDLE hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+            if (hSCM != NULL)
+            {
+                SC_HANDLE hService = CreateService(hSCM, pwszServiceName, pwszServiceDisplayName,
+                                                   SERVICE_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS,
+                                                   SERVICE_DEMAND_START, SERVICE_ERROR_NORMAL,
+                                                   wszFilePath, NULL, NULL, L"RPCSS\0", NULL, NULL);
+                if (hService != NULL)
+                {
+                    SERVICE_DESCRIPTION sd;
+                    sd.lpDescription = (WCHAR *)pwszServiceDescription;
+                    if (ChangeServiceConfig2(hService, SERVICE_CONFIG_DESCRIPTION, &sd))
+                        fRet = TRUE;
+                    else
+                        AssertMsgFailed(("Could not set service description for %ls: %u\n", pwszServiceName, GetLastError()));
+                    CloseServiceHandle(hService);
+                }
+                else
+                    AssertMsgFailed(("Could not create service %ls: %u\n", pwszServiceName, GetLastError()));
+                CloseServiceHandle(hSCM);
+            }
+            else
+                AssertMsgFailed(("Could not open service %ls: %u\n", pwszServiceName, GetLastError()));
+        }
+        else
+            AssertMsgFailed(("Could not open Service Manager: %u\n", GetLastError()));
+    }
+    return fRet;
+}
+
+
+BOOL vbpsUninstallWindowsService(const WCHAR *pwszServiceName)
+{
+    BOOL fRet = !vbpsIsInstalledWindowsService(pwszServiceName);
+    if (!fRet)
+    {
+        SC_HANDLE hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+        if (hSCM != NULL)
+        {
+            SC_HANDLE hService = OpenService(hSCM, pwszServiceName, SERVICE_STOP | DELETE);
+            if (hService)
+            {
+                DWORD          dwErr;
+                SERVICE_STATUS Status;
+                RT_ZERO(Status);
+                fRet = ControlService(hService, SERVICE_CONTROL_STOP, &Status);
+                dwErr = GetLastError();
+                if (   fRet
+                    || dwErr == ERROR_SERVICE_NOT_ACTIVE
+                    || (   dwErr == ERROR_SERVICE_CANNOT_ACCEPT_CTRL
+                        && Status.dwCurrentState == SERVICE_STOP_PENDING) )
+                {
+                    fRet = DeleteService(hService);
+                    AssertMsg(fRet, ("Could not delete service %ls: %u\n", pwszServiceName, GetLastError()));
+                }
+                else
+                    AssertMsgFailed(("Could not stop service %ls: %u (state=%u)\n", pwszServiceName, dwErr, Status.dwCurrentState));
+                CloseServiceHandle(hService);
+            }
+            else
+                AssertMsgFailed(("Could not open service %ls: %u\n", pwszServiceName, GetLastError()));
             CloseServiceHandle(hSCM);
-            hSCM = NULL;
-            LogWarnFunc(("Could not stop service\n"));
-            Assert(0);
         }
-    }
-
-    bDelete = DeleteService(hService);
-    CloseServiceHandle(hService);
-    CloseServiceHandle(hSCM);
-
-    if (!bDelete)
-    {
-        LogWarnFunc(("Error: Could not delete service\n"));
-        Assert(0);
-        return FALSE;
-    }
-
-    return TRUE;
-}
-
-
-static void vbpsUpdateVBoxSDSWindowsService(VBPSREGSTATE* pState, const WCHAR* wszVBoxDir)
-{
-    const WCHAR* wszModuleName =            L"VBoxSDS.exe";
-    const WCHAR* wszServiceName =           L"VBoxSDS";
-    const WCHAR* wszServiceDisplayName =    L"VirtualBox system service";
-    const WCHAR* wszServiceDescription =    L"Used as a COM server for VirtualBox API.";
+        else
+            AssertMsgFailed(("Could not open Service Manager: %u\n", GetLastError()));
+    }
+    return fRet;
+}
+
+
+static void vbpsUpdateVBoxSDSWindowsService(VBPSREGSTATE *pState, const WCHAR *pwszVBoxDir)
+{
+    const WCHAR s_wszModuleName[]         = L"VBoxSDS.exe";
+    const WCHAR s_wszServiceName[]        = L"VBoxSDS";
+    const WCHAR s_wszServiceDisplayName[] = L"VirtualBox system service";
+    const WCHAR s_wszServiceDescription[] = L"Used as a COM server for VirtualBox API.";
 
     if (pState->fUpdate)
     {
-        if (!InstallWindowsService(wszVBoxDir,
-            wszModuleName,
-            wszServiceName,
-            wszServiceDisplayName,
-            wszServiceDescription))
+        if (!vbpsInstallWindowsService(pwszVBoxDir, s_wszModuleName, s_wszServiceName,
+                                       s_wszServiceDisplayName, s_wszServiceDescription))
         {
-            LogWarnFunc(("Error: Windows service '%ls' cannot be registered\n", wszServiceName));
+            LogWarnFunc(("Error: Windows service '%ls' cannot be registered\n", s_wszServiceName));
             pState->rc = E_FAIL;
         }
     }
-    else if(pState->fDelete)
-    {
-        if (!UninstallWindowsService(wszServiceName))
+    else if (pState->fDelete)
+    {
+        if (!vbpsUninstallWindowsService(s_wszServiceName))
         {
-            LogWarnFunc(("Error: Windows service '%ls' cannot be unregistered\n", wszServiceName));
+            LogWarnFunc(("Error: Windows service '%ls' cannot be unregistered\n", s_wszServiceName));
             pState->rc = E_FAIL;
         }
     }
 }
+
+#endif /* VBOX_WITH_SDS */