Changeset 69731 in vbox for trunk/src/VBox/Main/src-server/win

Timestamp:

Nov 17, 2017 9:41:44 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

119127

Message:

Main: More SDS plan B sketching.

File:

• trunk/src/VBox/Main/src-server/win/svcmain.cpp (modified) (7 diffs)

trunk/src/VBox/Main/src-server/win/svcmain.cpp

@@ -27 +27 @@
 
 #include "VirtualBoxImpl.h"
+#ifdef VBOX_WITH_SDS_PLAN_B
+# include "VBoxSVCWrap.h"
+#endif
 #include "Logging.h"
 
@@ -139 +142 @@
 
 #ifdef VBOX_WITH_SDS_PLAN_B
+class VBoxSVC;
 
 /**
@@ -150 +154 @@
     /** Tri state: 0=uninitialized or initializing; 1=success; -1=failure.
      * This will be updated after both m_hrcCreate and m_pObj have been set. */
-    volatile int32_t    m_iState;
+    volatile int32_t       m_iState;
     /** The result of the instantiation attempt. */
-    HRESULT             m_hrcCreate;
+    HRESULT                m_hrcCreate;
     /** The IUnknown of the VirtualBox object/interface we're working with. */
-    IUnknown           *m_pObj;
+    IUnknown              *m_pObj;
+    /** Pointer to the IVBoxSVC implementation that VBoxSDS works with. */
+    ComObjPtr<VBoxSVC>     m_ptrVBoxSVC;
+    /** The VBoxSDS interface. */
+    ComPtr<IVirtualBoxSDS> m_ptrVirtualBoxSDS;
 
 public:
@@ -172 +180 @@
     STDMETHOD(CreateInstance)(LPUNKNOWN pUnkOuter, REFIID riid, void **ppvObj);
 
-    // IVBoxSVC
-    STDMETHOD(GetVirtualBox)(IUnknown **ppOtherObj);
+    /** Worker for VBoxSVC::getVirtualBox. */
+    HRESULT i_getVirtualBox(ComPtr<IUnknown> &aResult);
 
 private:
@@ -181 +189 @@
 
 
+/**
+ * The VBoxSVC class is handed to VBoxSDS so it can call us back and ask for the
+ * VirtualBox object when the next VBoxSVC for this user registers itself.
+ */
+class ATL_NO_VTABLE VBoxSVC : public VBoxSVCWrap
+{
+public:
+    DECLARE_EMPTY_CTOR_DTOR(VBoxSVC)
+
+    HRESULT FinalConstruct()
+    {
+        return BaseFinalConstruct();
+    }
+
+    void FinalRelease()
+    {
+        uninit();
+        BaseFinalRelease();
+    }
+
+    // public initializer/uninitializer for internal purposes only
+    HRESULT init(VirtualBoxClassFactory *pFactory)
+    {
+        AutoInitSpan autoInitSpan(this);
+        AssertReturn(autoInitSpan.isOk(), E_FAIL);
+
+        m_pFactory = pFactory;
+
+        autoInitSpan.setSucceeded();
+        return S_OK;
+    }
+
+    void uninit()
+    {
+        AutoUninitSpan autoUninitSpan(this);
+        if (!autoUninitSpan.uninitDone())
+            m_pFactory = NULL;
+    }
+
+private:
+    // Wrapped IVBoxSVC method.
+    HRESULT getVirtualBox(ComPtr<IUnknown> &aResult)
+    {
+        if (m_pFactory)
+            return m_pFactory->i_getVirtualBox(aResult);
+        return E_FAIL;
+    }
+
+public:
+    /** Pointer to the factory. */
+    VirtualBoxClassFactory *m_pFactory;
+};
+
+DEFINE_EMPTY_CTOR_DTOR(VBoxSVC);
+
+
 HRESULT VirtualBoxClassFactory::i_registerWithSds(IUnknown **ppOtherVirtualBox)
 {
+    /*
+     * Connect to VBoxSDS.
+     */
+    ComPtr<IVirtualBoxSDS> m_ptrVirtualBoxSDS;
+    HRESULT hrc = CoCreateInstance(CLSID_VirtualBoxSDS, NULL, CLSCTX_LOCAL_SERVER, IID_IVirtualBoxSDS,
+                                   (void **)m_ptrVirtualBoxSDS.asOutParam());
+    if (SUCCEEDED(hrc))
+    {
+        /*
+         * Create VBoxSVC object and hand that to VBoxSDS.
+         */
+        hrc = m_ptrVBoxSVC.createObject();
+        if (SUCCEEDED(hrc))
+        {
+            hrc = m_ptrVBoxSVC->init(this);
+            if (SUCCEEDED(hrc))
+            {
+                hrc = m_ptrVirtualBoxSDS->RegisterVBoxSVC(m_ptrVBoxSVC, GetCurrentProcessId(), ppOtherVirtualBox);
+                if (SUCCEEDED(hrc))
+                {
+                    return hrc;
+                }
+            }
+        }
+    }
+    m_ptrVirtualBoxSDS.setNull();
+    m_ptrVBoxSVC.setNull();
     *ppOtherVirtualBox = NULL;
-    return S_OK;
+    return hrc;
 }
 
@@ -194 +285 @@
 
 
-STDMETHODIMP VirtualBoxClassFactory::GetVirtualBox(IUnknown **ppUnkVirtualBox)
+HRESULT VirtualBoxClassFactory::i_getVirtualBox(ComPtr<IUnknown> &aResult)
 {
     IUnknown *pObj = m_pObj;
@@ -201 +292 @@
         /** @todo Do we need to do something regarding server locking?  Hopefully COM
          *        deals with that........... */
-        pObj->AddRef();
-        *ppUnkVirtualBox = pObj;
+        aResult = pObj;
         Log(("VirtualBoxClassFactory::GetVirtualBox: S_OK - %p\n", pObj));
         return S_OK;
     }
-    *ppUnkVirtualBox = NULL;
+    aResult.setNull();
     Log(("VirtualBoxClassFactory::GetVirtualBox: E_FAIL\n"));
     return E_FAIL;