Changeset 69749 in vbox for trunk/src/VBox/Main/src-server/xpcom

Timestamp:

Nov 19, 2017 12:49:36 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

119149

Message:

Changed RTLogCreateEx[V] to take a RTERRINFO pointer rather than plain char * and size_t. Turned out a several callers didn't actually make use of the error message even.

File:

• trunk/src/VBox/Main/src-server/xpcom/server.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/xpcom/server.cpp

@@ -744 +744 @@
         return RTMsgErrorExit(RTEXITCODE_FAILURE, "failed to create logging file name, rc=%Rrc", vrc);
 
-    char szError[RTPATH_MAX + 128];
+    RTERRINFOSTATIC ErrInfo;
     vrc = com::VBoxLogRelCreate("XPCOM Server", szLogFile,
                                 RTLOGFLAGS_PREFIX_THREAD | RTLOGFLAGS_PREFIX_TIME_PROG,
@@ -750 +750 @@
                                 RTLOGDEST_FILE, UINT32_MAX /* cMaxEntriesPerGroup */,
                                 cHistory, uHistoryFileTime, uHistoryFileSize,
-                                szError, sizeof(szError));
+                                RTErrInfoInitStatic(&ErrInfo));
     if (RT_FAILURE(vrc))
-        return RTMsgErrorExit(RTEXITCODE_FAILURE, "failed to open release log (%s, %Rrc)", szError, vrc);
+        return RTMsgErrorExit(RTEXITCODE_FAILURE, "failed to open release log (%s, %Rrc)", ErrInfo.Core.pszMsg, vrc);
 
     /* Set up a build identifier so that it can be seen from core dumps what