Changeset 69752 in vbox

Timestamp:

Nov 19, 2017 2:14:46 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

119152

Message:

RTLogCreateEx[V] format annotations; fixed unsafe use in VBoxService.

Location:

trunk

Files:

• include/iprt/log.h (modified) (2 diffs)
• src/VBox/Additions/common/VBoxService/VBoxService.cpp (modified) (1 diff)

trunk/include/iprt/log.h

@@ -2029 +2029 @@
                           uint32_t fDestFlags, PFNRTLOGPHASE pfnPhase, uint32_t cHistory,
                           uint64_t cbHistoryFileMax, uint32_t cSecsHistoryTimeSlot, PRTERRINFO pErrInfo,
-                          const char *pszFilenameFmt, ...) RT_IPRT_FORMAT_ATTR_MAYBE_NULL(14, 15);
+                          const char *pszFilenameFmt, ...) RT_IPRT_FORMAT_ATTR_MAYBE_NULL(13, 14);
 
 /**
@@ -2067 +2067 @@
                            uint32_t fDestFlags, PFNRTLOGPHASE pfnPhase, uint32_t cHistory,
                            uint64_t cbHistoryFileMax, uint32_t cSecsHistoryTimeSlot, PRTERRINFO pErrInfo,
-                           const char *pszFilenameFmt, va_list args) RT_IPRT_FORMAT_ATTR_MAYBE_NULL(14, 0);
+                           const char *pszFilenameFmt, va_list args) RT_IPRT_FORMAT_ATTR_MAYBE_NULL(13, 0);
 
 /**

trunk/src/VBox/Additions/common/VBoxService/VBoxService.cpp

@@ -319 +319 @@
                            RTLOGDEST_STDOUT | RTLOGDEST_USER,
                            vgsvcLogHeaderFooter, g_cHistory, g_uHistoryFileSize, g_uHistoryFileTime,
-                           NULL /*pErrInfo*/, pszLogFile);
+                           NULL /*pErrInfo*/, "%s", pszLogFile);
     if (RT_SUCCESS(rc))
     {