Changeset 69994 in vbox

Timestamp:

Dec 7, 2017 5:08:49 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

119501

Message:

VBoxServiceTimeSync.cpp: Log radical changes to the guest time too, even the ones we cause (for now).

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceTimeSync.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceTimeSync.cpp

@@ -537 +537 @@
 
     /*
-     * Initialize the last host time to prevent log message.
+     * Initialize the last host and guest times to prevent log message.
+     * We also tracks whether we set the time in the previous loop.
      */
     RTTIMESPEC HostLast;
     if (RT_FAILURE(VbglR3GetHostTime(&HostLast)))
         RTTimeSpecSetNano(&HostLast, 0);
+    RTTIMESPEC GuestLast;
+    RTTimeNow(&GuestLast);
+    bool fSetTimeLastLoop = false;
 
     /*
@@ -617 +621 @@
                 }
 
+                bool fSetTimeInThisLoop = false;
                 uint32_t AbsDriftMilli = RTTimeSpecGetMilli(&AbsDrift);
                 if (AbsDriftMilli > MinAdjust)
@@ -632 +637 @@
                         vgsvcTimeSyncCancelAdjust();
                         vgsvcTimeSyncSet(&Drift);
+                        fSetTimeInThisLoop = true;
                     }
 
@@ -645 +651 @@
                     vgsvcTimeSyncCancelAdjust();
                 HostLast = HostNow;
+
+                /*
+                 * Log radical guest time changes (we could be the cause of these, mind).
+                 * Note! Right now we don't care about an extra log line after we called
+                 *       vgsvcTimeSyncSet.  fSetTimeLastLoop helps show it though.
+                 */
+                int64_t cNsGuestDelta = RTTimeSpecGetNano(&GuestNow) - RTTimeSpecGetNano(&GuestLast);
+                if ((uint64_t)RT_ABS(cNsGuestDelta) > RT_NS_1HOUR / 2)
+                    vgsvcTimeSyncLog(0, "vgsvcTimeSyncWorker: Radical guest time change: %'RI64ns (GuestNow=%RDtimespec GuestLast=%RDtimespec fSetTimeLastLoop=%RTbool)\n",
+                                     cNsGuestDelta, &GuestNow, &GuestLast, fSetTimeLastLoop);
+                GuestLast = GuestNow;
+                fSetTimeLastLoop = fSetTimeInThisLoop;
                 break;
             }