Changeset 70097 in vbox for trunk/src/VBox/Devices

Timestamp:

Dec 12, 2017 7:45:51 PM (7 years ago)

Author:

vboxsync

Message:

Devices/Serial: Update the parameters of the driver below upon reset to stay in sync, fix value of LCR register during reset to really get 8 data bits as stated in the comment

File:

• trunk/src/VBox/Devices/Serial/DevSerial.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Serial/DevSerial.cpp

@@ -1115 +1115 @@
     pThis->ier = 0;
     pThis->iir = UART_IIR_NO_INT;
-    pThis->lcr = 0;
+    pThis->lcr = 3; /* 8 data bits, no parity, 1 stop bit */
     pThis->lsr = UART_LSR_TEMT | UART_LSR_THRE;
     pThis->msr = UART_MSR_DCD | UART_MSR_DSR | UART_MSR_CTS;
@@ -1126 +1126 @@
     pThis->char_transmit_time = (tf / 9600) * 10;
     serial_tsr_retry_update_parameters(pThis, tf);
+
+    /* Update parameters of the underlying driver to stay in sync. */
+    serial_update_parameters(pThis);
 
     fifo_clear(pThis, RECV_FIFO);
@@ -1310 +1313 @@
     pThis->transmit_timerRC = TMTimerRCPtr(pThis->transmit_timerR3);
 
-    serialReset(pDevIns);
-
 #ifdef VBOX_SERIAL_PCI
     /*
@@ -1387 +1388 @@
     }
 
+    serialReset(pDevIns);
     return VINF_SUCCESS;
 }