Changeset 70105 in vbox for trunk/src/VBox

Timestamp:

Dec 13, 2017 10:34:32 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

119653

Message:

Main/Machine: Increase chunk size for reading the log from 32K to 512K. The reason for the small chunk size has been eliminated many years ago.

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -6689 +6689 @@
     alock.release();
 
-    /* Limit the chunk size to 32K for now, as that gives better performance
-     * over (XP)COM, and keeps the SOAP reply size under 1M for the webservice.
-     * One byte expands to approx. 25 bytes of breathtaking XML. */
-    size_t cbData = (size_t)RT_MIN(aSize, 32768);
+    /* Limit the chunk size to 512K. Gives good performance over (XP)COM, and
+     * keeps the SOAP reply size under 1M for the webservice (we're using
+     * base64 encoded strings for binary data for years now, avoiding the
+     * expansion of each byte array element to approx. 25 bytes of XML. */
+    size_t cbData = (size_t)RT_MIN(aSize, _512K);
     aData.resize(cbData);