Changeset 70110 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Dec 13, 2017 1:53:56 PM (7 years ago)

Author:

vboxsync

Message:

FE/Qt: VBoxGlobal: Fix for use after free done in r104346, (s.a. r106981).

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

@@ -3674 +3674 @@
     QString vmNameOrUuid;
 
-    const QStringList arguments = qApp->arguments();
+    const QStringList &arguments = QCoreApplication::arguments();
     const int argc = arguments.size();
     int i = 1;
     while (i < argc)
     {
-        QByteArray  argBytes = arguments.at(i).toUtf8();
+        const QByteArray &argBytes = arguments.at(i).toUtf8();
         const char *arg = argBytes.constData();
         /* NOTE: the check here must match the corresponding check for the
@@ -3727 +3727 @@
             {
                 size_t cbFile;
-                const char *pszFile = arguments.at(i).toLocal8Bit().constData();
+                const QByteArray &argFileBytes = arguments.at(i).toLocal8Bit();
+                const char *pszFile = argFileBytes.constData();
                 bool fStdIn = !::strcmp(pszFile, "stdin");
                 int vrc = VINF_SUCCESS;