Changeset 70240 in vbox

Timestamp:

Dec 20, 2017 12:32:57 PM (7 years ago)

Author:

vboxsync

Message:

VBoxProxyStub.c: Official docs says DELETE is required for DeleteService. No reason for removal stated in r119820, so restoring it. Dropped incorrectly formatted comments about where to also rename VBoxSDS if we ever want to do that (we won't, and if we do, there's grep).

File:

• trunk/src/VBox/Main/src-all/win/VBoxProxyStub.c (modified) (3 diffs)

trunk/src/VBox/Main/src-all/win/VBoxProxyStub.c

@@ -1316 +1316 @@
     const char *pszLocalServer      = "VBoxSVC.exe";
 #ifdef VBOX_WITH_SDS
-    /**
-    * The Name of windows service is referenced in different places.
-    * Don't forget to change it in other places too If you change it here :
-    *      VBoxMergeApp.wxi (cp_VBoxSDS component),
-    *      VBoxSDS.cpp and VirtualBox.xidl
-    */
     const char *pszSdsAppId         = "{EC0E78E8-FA43-43E8-AC0A-02C784C4A4FA}";
     const char *pszSdsExe           = "VBoxSDS.exe";
@@ -2426 +2420 @@
         if (fDeleteIt)
         {
-            hService = OpenServiceW(hSCM, pwszServiceName, SERVICE_STOP);
+            hService = OpenServiceW(hSCM, pwszServiceName, SERVICE_STOP | DELETE);
             if (hService)
             {
@@ -2551 +2545 @@
 
 #ifdef VBOX_WITH_SDS
-        /**
-        * The Name of windows service is referenced in different places.
-        * Don't forget to change it in other places too If you change it here :
-        *      VBoxMergeApp.wxi (cp_VBoxSDS component),
-        *      VBoxSDS.cpp and VirtualBox.xidl
-        */
         vbpsUpdateWindowsService(&State, wszVBoxDir, L"VBoxSDS.exe", L"VBoxSDS",
                                  L"VirtualBox system service", L"Used as a COM server for VirtualBox API.");