Changeset 70282 in vbox for trunk/src/VBox

Timestamp:

Dec 21, 2017 2:28:47 PM (7 years ago)

Author:

vboxsync

Message:

VBoxGuest-win.cpp: Refuse to stop or remove the device when there are active sessions.

File:

• trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp (modified) (8 diffs)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp

@@ -94 +94 @@
     /** Top of the stack. */
     PDEVICE_OBJECT          pNextLowerDriver;
+
+    /** @name PCI bus and slot (device+function) set by for legacy NT only.
+     * @{ */
+    /** Bus number where the device is located. */
+    ULONG                   uBus;
+    /** Slot number where the device is located (PCI_SLOT_NUMBER). */
+    ULONG                   uSlot;
+    /** @} */
+
+    /** @name Interrupt stuff.
+     * @{  */
     /** Interrupt object pointer. */
     PKINTERRUPT             pInterruptObject;
-
-    /** Bus number where the device is located. */
-    ULONG                   uBus;
-    /** Slot number where the device is located. */
-    ULONG                   uSlot;
     /** Device interrupt level. */
     ULONG                   uInterruptLevel;
@@ -109 +115 @@
     /** LevelSensitive or Latched. */
     KINTERRUPT_MODE         enmInterruptMode;
+    /** @} */
 
     /** Physical address and length of VMMDev memory. */
@@ -116 +123 @@
 
     /** Device state. */
-    VGDRVNTDEVSTATE         enmDevState;
+    VGDRVNTDEVSTATE volatile enmDevState;
     /** The previous device state. */
     VGDRVNTDEVSTATE         enmPrevDevState;
@@ -1196 +1203 @@
 
 /**
+ * Checks if the device is idle.
+ * @returns STATUS_SUCCESS if idle, STATUS_UNSUCCESSFUL if busy.
+ * @param   pDevExt             The device extension.
+ * @param   pszQueryNm          The query name.
+ */
+static NTSTATUS vgdrvNtCheckIdle(PVBOXGUESTDEVEXTWIN pDevExt, const char *pszQueryNm)
+{
+    uint32_t cSessions = pDevExt->Core.cSessions;
+    if (cSessions == 0)
+        return STATUS_SUCCESS;
+    LogRel(("vgdrvNtCheckIdle/%s: cSessions=%d\n", pszQueryNm, cSessions));
+    return STATUS_UNSUCCESSFUL;
+}
+
+
+/**
  * PnP Request handler.
  *
@@ -1286 +1309 @@
             rc = STATUS_UNSUCCESSFUL;
 #endif
-            /** @todo refuse to remove ourselves when we've got client
-             *        sessions attached...  */
-
+            if (NT_SUCCESS(rc))
+                rc = vgdrvNtCheckIdle(pDevExt, "QUERY_REMOVE_DEVICE");
             if (NT_SUCCESS(rc))
             {
@@ -1403 +1425 @@
         {
             Log(("vgdrvNtNt5PlusPnP: QUERY_STOP_DEVICE\n"));
-
-            /** @todo Check whether we can stop the device.  Similar to
-             *        removal above */
-            rc = STATUS_SUCCESS;
+            VGDRVNTDEVSTATE const enmOldState = pDevExt->enmDevState;
+            rc = vgdrvNtCheckIdle(pDevExt, "QUERY_STOP_DEVICE");
             if (NT_SUCCESS(rc))
             {
@@ -2224 +2244 @@
  * Implements RTL_QUERY_REGISTRY_ROUTINE for enumerating our registry key.
  */
-static NTSTATUS NTAPI vbdrvNtRegistryEnumCallback(PWSTR pwszValueName, ULONG uValueType,
+static NTSTATUS NTAPI vgdrvNtRegistryEnumCallback(PWSTR pwszValueName, ULONG uValueType,
                                                   PVOID pvValue, ULONG cbValue, PVOID pvUser, PVOID pvEntryCtx)
 {
@@ -2356 +2376 @@
     RTL_QUERY_REGISTRY_TABLE aQuery[2];
     RT_ZERO(aQuery);
-    aQuery[0].QueryRoutine = vbdrvNtRegistryEnumCallback;
+    aQuery[0].QueryRoutine = vgdrvNtRegistryEnumCallback;
     aQuery[0].Flags        = 0;
     aQuery[0].Name         = NULL;