Changeset 7032 in vbox for trunk/src/VBox/Runtime/r0drv

Timestamp:

Feb 20, 2008 12:26:22 PM (17 years ago)

Author:

vboxsync

Message:

Ring-0 semaphore debugging aid (linux).

Location:

trunk/src/VBox/Runtime/r0drv/linux

Files:

• semevent-r0drv-linux.c (modified) (3 diffs)
• semeventmulti-r0drv-linux.c (modified) (3 diffs)
• semfastmutex-r0drv-linux.c (modified) (5 diffs)
• the-linux-kernel.h (modified) (1 diff)

trunk/src/VBox/Runtime/r0drv/linux/semevent-r0drv-linux.c

@@ -24 +24 @@
  * terms and conditions of either the GPL or the CDDL or both.
  */
-
 
 
@@ -139 +138 @@
     int     rc       = VINF_SUCCESS;
     long    lTimeout = cMillies == RT_INDEFINITE_WAIT ? MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(cMillies);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "e%lx", IPRT_DEBUG_SEMS_ADDRESS(pEventInt));
+#endif
     for (;;)
     {
@@ -174 +176 @@
 
     finish_wait(&pEventInt->Head, &Wait);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "e%lx:%d", IPRT_DEBUG_SEMS_ADDRESS(pEventInt), rc);
+#endif
     return rc;
 }

trunk/src/VBox/Runtime/r0drv/linux/semeventmulti-r0drv-linux.c

@@ -24 +24 @@
  * terms and conditions of either the GPL or the CDDL or both.
  */
-
 
 
@@ -150 +149 @@
     int     rc       = VINF_SUCCESS;
     long    lTimeout = cMillies == RT_INDEFINITE_WAIT ? MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(cMillies);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "E%lx", IPRT_DEBUG_SEMS_ADDRESS(pThis));
+#endif
     for (;;)
     {
@@ -185 +187 @@
 
     finish_wait(&pThis->Head, &Wait);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "E%lx:%d", IPRT_DEBUG_SEMS_ADDRESS(pThis), rc);
+#endif
     return rc;
 }

trunk/src/VBox/Runtime/r0drv/linux/semfastmutex-r0drv-linux.c

@@ -36 +36 @@
 #include <iprt/asm.h>
 #include <iprt/err.h>
+#ifdef IPRT_DEBUG_SEMS
+# include <iprt/thread.h>
+#endif
 
 #include "internal/magics.h"
@@ -52 +55 @@
     /** the linux semaphore. */
     struct semaphore    Semaphore;
+#ifdef IPRT_DEBUG_SEMS
+    /** For check. */
+    RTNATIVETHREAD volatile Owner;
+#endif
 } RTSEMFASTMUTEXINTERNAL, *PRTSEMFASTMUTEXINTERNAL;
 
@@ -70 +77 @@
     pFastInt->u32Magic = RTSEMFASTMUTEX_MAGIC;
     sema_init(&pFastInt->Semaphore, 1);
+#ifdef IPRT_DEBUG_SEMS
+    pFastInt->Owner = NIL_RTNATIVETHREAD;
+#endif
     *pMutexSem = pFastInt;
     return VINF_SUCCESS;
@@ -108 +118 @@
     }
 
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "d%lx", IPRT_DEBUG_SEMS_ADDRESS(pFastInt));
+#endif
     down(&pFastInt->Semaphore);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "o%lx", IPRT_DEBUG_SEMS_ADDRESS(pFastInt));
+    AssertRelease(pFastInt->Owner == NIL_RTNATIVETHREAD);
+    ASMAtomicUoWriteSize(&pFastInt->Owner, RTThreadNativeSelf());
+#endif
     return VINF_SUCCESS;
 }
@@ -126 +144 @@
     }
 
+#ifdef IPRT_DEBUG_SEMS
+    AssertRelease(pFastInt->Owner == RTThreadNativeSelf());
+    ASMAtomicUoWriteSize(&pFastInt->Owner, NIL_RTNATIVETHREAD);
+#endif
     up(&pFastInt->Semaphore);
+#ifdef IPRT_DEBUG_SEMS
+    snprintf(current->comm, TASK_COMM_LEN, "u%lx", IPRT_DEBUG_SEMS_ADDRESS(pFastInt));
+#endif
     return VINF_SUCCESS;
 }

trunk/src/VBox/Runtime/r0drv/linux/the-linux-kernel.h

@@ -242 +242 @@
 #endif
 
-#endif
-
+/**
+ * Hack for shortening pointers on linux so we can stuff more stuff into the
+ * task_struct::comm field. This is used by the semaphore code but put here
+ * because we don't have any better place atm. Don't use outside IPRT, please.
+ */
+#ifdef RT_ARCH_AMD64
+# define IPRT_DEBUG_SEMS_ADDRESS(addr)  ( ((long)(addr) & (long)~UINT64_C(0xfffffff000000000)) )
+#else
+# define IPRT_DEBUG_SEMS_ADDRESS(addr)  ( (long)(addr) )
+#endif
+
+#endif
+