Changeset 7034 in vbox for trunk/src/VBox

Timestamp:

Feb 20, 2008 1:29:17 PM (17 years ago)

Author:

vboxsync

Message:

Fixed unlinking bug in the object cleanup routine that would screw up the linked list (GVMM:iUsedHead) if the VM wasn't at the head of it. (inverted loop condition)

File:

• trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/GVMMR0.cpp

@@ -834 +834 @@
         uint16_t iPrev = pGVMM->iUsedHead;
         int c = RT_ELEMENTS(pGVMM->aHandles) + 2;
-        while (!iPrev)
+        while (iPrev)
         {
             if (RT_UNLIKELY(iPrev >= RT_ELEMENTS(pGVMM->aHandles)))
@@ -861 +861 @@
         }
 
+        Assert(pGVMM->aHandles[iPrev].iNext == iHandle);
         pGVMM->aHandles[iPrev].iNext = pHandle->iNext;
     }