Changeset 70526 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Jan 11, 2018 6:56:26 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

120196

Message:

VMM/HMVMXR0: Enable executing INVPCID in the guest and cause VM-exits when guest attempts to modify CR4.PCIDE bit.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -2524 +2524 @@
         if (pVM->hm.s.fNestedPaging)
             val |= VMX_VMCS_CTRL_PROC_EXEC2_EPT;                        /* Enable EPT. */
-        else
-        {
-            /*
-             * Without Nested Paging, INVPCID should cause a VM-exit. Enabling this bit causes the CPU to refer to
-             * VMX_VMCS_CTRL_PROC_EXEC_INVLPG_EXIT when INVPCID is executed by the guest.
-             * See Intel spec. 25.4 "Changes to instruction behaviour in VMX non-root operation".
-             */
-            if (pVM->hm.s.vmx.Msrs.VmxProcCtls2.n.allowed1 & VMX_VMCS_CTRL_PROC_EXEC2_INVPCID)
-                val |= VMX_VMCS_CTRL_PROC_EXEC2_INVPCID;
-        }
+
+        /*
+         * Enable the INVPCID instruction if supported by the hardware and we expose
+         * it to the guest. Without this, guest executing INVPCID would cause a #UD.
+         */
+        if (   (pVM->hm.s.vmx.Msrs.VmxProcCtls2.n.allowed1 & VMX_VMCS_CTRL_PROC_EXEC2_INVPCID)
+            && pVM->cpum.ro.GuestFeatures.fInvpcid)
+            val |= VMX_VMCS_CTRL_PROC_EXEC2_INVPCID;
 
         if (pVM->hm.s.vmx.fVpid)
@@ -4142 +4140 @@
         if (pVM->cpum.ro.HostFeatures.fXSaveRstor)
             u32CR4Mask |= X86_CR4_OSXSAVE;
+        if (pVM->cpum.ro.GuestFeatures.fPcid)
+            u32CR4Mask |= X86_CR4_PCIDE;
         pVCpu->hm.s.vmx.u32CR4Mask = u32CR4Mask;
         rc = VMXWriteVmcs32(VMX_VMCS_CTRL_CR4_MASK, u32CR4Mask);