Changeset 7058 in vbox

Timestamp:

Feb 20, 2008 6:29:10 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

28294

Message:

Added (disabled) instrumentation for measuring the time DMA writes to virtual disks take.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -73 +73 @@
 /** The maximum number of release log entries per device. */
 #define MAX_LOG_REL_ERRORS  1024
+
+/** Temporary instrumentation for tracking down potential virtual disk
+ * write performance issues. */
+#undef VBOX_INSTRUMENT_DMA_WRITES
 
 typedef struct ATADevState {
@@ -186 +190 @@
     /* Release statistics: number of ATAPI PIO commands. */
     STAMCOUNTER StatATAPIPIO;
+#ifdef VBOX_INSTRUMENT_DMA_WRITES
+    /* Release statistics: number of DMA sector writes and the time spent. */
+    STAMPROFILEADV StatInstrVDWrites;
+#endif
 
     /** Statistics: number of read operations and the time spent reading. */
@@ -1350 +1358 @@
     STAM_PROFILE_ADV_START(&s->StatWrites, w);
     s->Led.Asserted.s.fWriting = s->Led.Actual.s.fWriting = 1;
+#ifdef VBOX_INSTRUMENT_DMA_WRITES
+    if (s->fDMA)
+        STAM_PROFILE_ADV_START(&s->StatInstrVDWrites, vw);;
+#endif
     rc = s->pDrvBlock->pfnWrite(s->pDrvBlock, u64Sector * 512, pvBuf, cSectors * 512);
+#ifdef VBOX_INSTRUMENT_DMA_WRITES
+    if (s->fDMA)
+        STAM_PROFILE_ADV_STOP(&s->StatInstrVDWrites, vw);;
+#endif
     s->Led.Actual.s.fWriting = 0;
     STAM_PROFILE_ADV_STOP(&s->StatWrites, w);
@@ -6004 +6020 @@
 #endif
             PDMDevHlpSTAMRegisterF(pDevIns, &pIf->StatBytesRead,    STAMTYPE_COUNTER,     STAMVISIBILITY_ALWAYS, STAMUNIT_BYTES,           "Amount of data read.",              "/Devices/ATA%d/Unit%d/ReadBytes", i, j);
+#ifdef VBOX_INSTRUMENT_DMA_WRITES
+            PDMDevHlpSTAMRegisterF(pDevIns, &pIf->StatInstrVDWrites,       STAMTYPE_PROFILE_ADV, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL,  "Profiling of the VD DMA write operations.","/Devices/ATA%d/Unit%d/InstrVDWrites", i, j);
+#endif
 #ifdef VBOX_WITH_STATISTICS
             PDMDevHlpSTAMRegisterF(pDevIns, &pIf->StatWrites,       STAMTYPE_PROFILE_ADV, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL,  "Profiling of the write operations.","/Devices/ATA%d/Unit%d/Writes", i, j);