Changeset 70581 in vbox

Timestamp:

Jan 14, 2018 8:54:55 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

120269

Message:

FE/Qt bugref:9072: Adding setting panel to the logviewer

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• Makefile.kmk (modified) (2 diffs)
• src/logviewer/UIVMLogPage.cpp (modified) (7 diffs)
• src/logviewer/UIVMLogPage.h (modified) (2 diffs)
• src/logviewer/UIVMLogViewerBookmarksPanel.cpp (modified) (4 diffs)
• src/logviewer/UIVMLogViewerBookmarksPanel.h (modified) (2 diffs)
• src/logviewer/UIVMLogViewerSearchPanel.cpp (modified) (3 diffs)
• src/logviewer/UIVMLogViewerSearchPanel.h (modified) (2 diffs)
• src/logviewer/UIVMLogViewerSettingsPanel.cpp (copied) (copied from trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerBookmarksPanel.cpp ) (2 diffs)
• src/logviewer/UIVMLogViewerSettingsPanel.h (copied) (copied from trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerBookmarksPanel.h ) (4 diffs)
• src/logviewer/UIVMLogViewerTextEdit.cpp (modified) (16 diffs)
• src/logviewer/UIVMLogViewerTextEdit.h (modified) (3 diffs)
• src/logviewer/UIVMLogViewerWidget.cpp (modified) (19 diffs)
• src/logviewer/UIVMLogViewerWidget.h (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/Makefile.kmk

@@ -341 +341 @@
         src/logviewer/UIVMLogViewerPanel.h \
         src/logviewer/UIVMLogViewerSearchPanel.h \
+        src/logviewer/UIVMLogViewerSettingsPanel.h \
         src/logviewer/UIVMLogViewerTextEdit.h \
         src/logviewer/UIVMLogViewerWidget.h \
@@ -661 +662 @@
         src/logviewer/UIVMLogViewerPanel.cpp \
         src/logviewer/UIVMLogViewerSearchPanel.cpp \
+        src/logviewer/UIVMLogViewerSettingsPanel.cpp \
         src/logviewer/UIVMLogViewerTextEdit.cpp \
         src/logviewer/UIVMLogViewerWidget.cpp \

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogPage.cpp

@@ -44 +44 @@
     , m_tabIndex(tabIndex)
     , m_bFiltered(false)
+    , m_bShowLineNumbers(true)
+    , m_bWrapLines(false)
 {
     prepare();
@@ -192 +194 @@
 {
     int index = -1;
-    for(int i = 0; i < m_bookmarkVector.size(); ++i)
+    for (int i = 0; i < m_bookmarkVector.size(); ++i)
     {
-        if(m_bookmarkVector.at(i).first == bookmark.first)
+        if (m_bookmarkVector.at(i).first == bookmark.first)
         {
             index = i;
@@ -200 +202 @@
         }
     }
-    if(index != -1)
+    if (index != -1)
         deleteBookmark(index);
 }
@@ -213 +215 @@
 void UIVMLogPage::scrollToBookmark(int bookmarkIndex)
 {
-    if(!m_pTextEdit)
+    if (!m_pTextEdit)
         return;
     if (bookmarkIndex >= m_bookmarkVector.size())
@@ -243 +245 @@
 void UIVMLogPage::updateTextEditBookmarkLineSet()
 {
-    if(!m_pTextEdit)
+    if (!m_pTextEdit)
         return;
     QSet<int> bookmarkLinesSet;
-    for(int i = 0; i < m_bookmarkVector.size(); ++i)
+    for (int i = 0; i < m_bookmarkVector.size(); ++i)
     {
         bookmarkLinesSet.insert(m_bookmarkVector.at(i).first);
@@ -260 +262 @@
 void UIVMLogPage::setFiltered(bool filtered)
 {
-    if(m_bFiltered == filtered)
+    if (m_bFiltered == filtered)
         return;
     m_bFiltered = filtered;
-    if(m_pTextEdit)
+    if (m_pTextEdit)
     {
         m_pTextEdit->setShownTextIsFiltered(m_bFiltered);
@@ -270 +272 @@
     emit sigLogPageFilteredChanged(m_bFiltered);
 }
+
+void UIVMLogPage::setShowLineNumbers(bool bShowLineNumbers)
+{
+    if(m_bShowLineNumbers == bShowLineNumbers)
+        return;
+    m_bShowLineNumbers = bShowLineNumbers;
+    if(m_pTextEdit)
+        m_pTextEdit->setShowLineNumbers(m_bShowLineNumbers);
+    update();
+}
+
+void UIVMLogPage::setWrapLines(bool bWrapLines)
+{
+    if(m_bWrapLines == bWrapLines)
+        return;
+    m_bWrapLines = bWrapLines;
+    if(m_pTextEdit)
+        m_pTextEdit->setWrapLines(m_bWrapLines);
+    update();
+}

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogPage.h

@@ -92 +92 @@
     void setFiltered(bool filtered);
 
+    void setShowLineNumbers(bool bShowLineNumbers);
+    void setWrapLines(bool bWrapLines);
+
 private slots:
 
@@ -119 +122 @@
         if m_bFiltered is false than (m_strLog == m_pTextEdit->text()). */
     bool m_bFiltered;
+    bool m_bShowLineNumbers;
+    bool m_bWrapLines;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerBookmarksPanel.cpp

@@ -28 +28 @@
 # include <QLabel>
 # include <QPushButton>
-# include <QSpacerItem>
+
 /* GUI includes: */
 # include "QIToolButton.h"
@@ -43 +43 @@
     , m_pDeleteAllButton(0)
     , m_pDeleteCurrentButton(0)
-    , m_pSpacerItem(0)
 {
     prepare();
@@ -56 +55 @@
     QStringList bList;
     bList << "Bookmarks List";
-    for(int i = 0; i < bookmarkVector.size(); ++i)
+    for (int i = 0; i < bookmarkVector.size(); ++i)
     {
         QString strItem = QString("BookMark %1 at Line %2: %3").arg(QString::number(i)).
@@ -113 +112 @@
     mainLayout()->addWidget(m_pDeleteAllButton, 0);
 
-
-    m_pSpacerItem = new QSpacerItem(0, 0, QSizePolicy::Expanding, QSizePolicy::Minimum);
-    AssertPtrReturnVoid(m_pSpacerItem);
-    mainLayout()->addItem(m_pSpacerItem);
+    mainLayout()->addStretch(4);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerBookmarksPanel.h

@@ -25 +25 @@
 class QComboBox;
 class QPushButton;
-class QSpacerItem;
 class QIToolButton;
 
@@ -76 +75 @@
     QPushButton  *m_pDeleteAllButton;
     QIToolButton *m_pDeleteCurrentButton;
-    QSpacerItem  *m_pSpacerItem;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerSearchPanel.cpp

@@ -52 +52 @@
     , m_pMatchWholeWordCheckBox(0)
     , m_pHighlightAllCheckBox(0)
-    , m_pWarningSpacer(0), m_pWarningIcon(0), m_pInfoLabel(0)
+    , m_pWarningIcon(0)
+    , m_pInfoLabel(0)
     , m_iSearchPosition(0)
     , m_iMatchCount(-1)
@@ -270 +271 @@
     }
 
-    /* Create warning-spacer: */
-    m_pWarningSpacer = new QSpacerItem(0, 0, QSizePolicy::Fixed, QSizePolicy::Minimum);
-    AssertPtrReturnVoid(m_pWarningSpacer);
-    {
-        /* Add warning-spacer to main-layout: */
-        mainLayout()->addItem(m_pWarningSpacer);
-    }
-
     /* Create warning-icon: */
     m_pWarningIcon = new QLabel(this);
@@ -306 +299 @@
         mainLayout()->addWidget(m_pInfoLabel);
     }
-
-    m_pSpacerItem = new QSpacerItem(0, 0, QSizePolicy::Expanding, QSizePolicy::Minimum);
-    AssertPtrReturnVoid(m_pSpacerItem);
-    {
-        mainLayout()->addItem(m_pSpacerItem);
-    }
+    mainLayout()->addStretch(2);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerSearchPanel.h

@@ -29 +29 @@
 class QHBoxLayout;
 class QLabel;
-class QSpacerItem;
 class UIMiniCancelButton;
 class UIRoundRectSegmentedButton;
@@ -118 +117 @@
     QCheckBox   *m_pMatchWholeWordCheckBox;
     QCheckBox   *m_pHighlightAllCheckBox;
-    /** Holds the instance of warning spacer-item we create. */
-    QSpacerItem *m_pWarningSpacer;
+
     /** Holds the instance of warning icon we create. */
     QLabel      *m_pWarningIcon;
     /** Holds the instance of info label we create. */
     QLabel      *m_pInfoLabel;
-    /** Holds the instance of spacer item we create. */
-    QSpacerItem *m_pSpacerItem;
+
     /** Holds the position where we start the next search. */
     int          m_iSearchPosition;

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerSettingsPanel.cpp

@@ -26 +26 @@
 #  include <QFontDatabase>
 # endif
-# include <QLabel>
-# include <QPushButton>
-# include <QSpacerItem>
+# include <QCheckBox>
+
 /* GUI includes: */
 # include "QIToolButton.h"
-# include "UIVMLogViewerBookmarksPanel.h"
+# include "UIVMLogViewerSettingsPanel.h"
 # include "UIVMLogViewerWidget.h"
 
@@ -37 +36 @@
 
 
-UIVMLogViewerBookmarksPanel::UIVMLogViewerBookmarksPanel(QWidget *pParent, UIVMLogViewerWidget *pViewer)
-: UIVMLogViewerPanel(pParent, pViewer)
-    , m_iMaxBookmarkTextLength(60)
-    , m_pBookmarksComboBox(0)
-    , m_pDeleteAllButton(0)
-    , m_pDeleteCurrentButton(0)
-    , m_pSpacerItem(0)
+UIVMLogViewerSettingsPanel::UIVMLogViewerSettingsPanel(QWidget *pParent, UIVMLogViewerWidget *pViewer)
+    : UIVMLogViewerPanel(pParent, pViewer)
+    , m_pLineNumberCheckBox(0)
+    , m_pWrapLinesCheckBox(0)
 {
     prepare();
 }
 
-void UIVMLogViewerBookmarksPanel::updateBookmarkList(const QVector<QPair<int, QString> > &bookmarkVector)
+void UIVMLogViewerSettingsPanel::setShowLineNumbers(bool bShowLineNumbers)
 {
-    if (!m_pBookmarksComboBox || !viewer())
+    if(!m_pLineNumberCheckBox)
         return;
-
-    m_pBookmarksComboBox->clear();
-    QStringList bList;
-    bList << "Bookmarks List";
-    for(int i = 0; i < bookmarkVector.size(); ++i)
-    {
-        QString strItem = QString("BookMark %1 at Line %2: %3").arg(QString::number(i)).
-            arg(QString::number(bookmarkVector.at(i).first)).arg(bookmarkVector.at(i).second);
-
-        if (strItem.length() > m_iMaxBookmarkTextLength)
-        {
-            strItem.resize(m_iMaxBookmarkTextLength);
-            strItem.replace(m_iMaxBookmarkTextLength, 3, QString("..."));
-        }
-        bList << strItem;
-    }
-    m_pBookmarksComboBox->addItems(bList);
-    /* Goto last item of the combobox: */
-    m_pBookmarksComboBox->setCurrentIndex(m_pBookmarksComboBox->count()-1);
+    if(m_pLineNumberCheckBox->isChecked() == bShowLineNumbers)
+        return;
+    m_pLineNumberCheckBox->setChecked(bShowLineNumbers);
 }
 
-void UIVMLogViewerBookmarksPanel::setBookmarkIndex(int index)
+void UIVMLogViewerSettingsPanel::setWrapLines(bool bWrapLines)
 {
-    if (!m_pBookmarksComboBox)
+    if(!m_pWrapLinesCheckBox)
         return;
-    /* If there is only Title of the combo, then goto that item: */
-    if (m_pBookmarksComboBox->count() == 1 || index >= m_pBookmarksComboBox->count())
-    {
-        m_pBookmarksComboBox->setCurrentIndex(0);
+    if(m_pWrapLinesCheckBox->isChecked() == bWrapLines)
         return;
-    }
-    /* index+1 since we always have a 0th item in our combo box. */
-    m_pBookmarksComboBox->setCurrentIndex(index+1);
+    m_pWrapLinesCheckBox->setChecked(bWrapLines);
 }
 
-void UIVMLogViewerBookmarksPanel::prepareWidgets()
+
+void UIVMLogViewerSettingsPanel::prepareWidgets()
 {
     if (!mainLayout())
         return;
 
-    m_pBookmarksComboBox = new QComboBox(this);
-    QFontMetrics fontMetrics = m_pBookmarksComboBox->fontMetrics();
-    AssertPtrReturnVoid(m_pBookmarksComboBox);
-    m_pBookmarksComboBox->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Maximum);
-    m_pBookmarksComboBox->setMaximumWidth(fontMetrics.width('a') * (m_iMaxBookmarkTextLength + 2));
-    /* Make sure we have 0th item in our combo box. */
-    m_pBookmarksComboBox->insertItem(0, "Bookmarks List");
+    m_pLineNumberCheckBox = new QCheckBox(this);
+    AssertPtrReturnVoid(m_pLineNumberCheckBox);
+    m_pLineNumberCheckBox->setChecked(true);
+    mainLayout()->addWidget(m_pLineNumberCheckBox, 0, Qt::AlignLeft);
 
+    m_pWrapLinesCheckBox = new QCheckBox(this);
+    AssertPtrReturnVoid(m_pWrapLinesCheckBox);
+    m_pWrapLinesCheckBox->setChecked(false);
+    mainLayout()->addWidget(m_pWrapLinesCheckBox, 0, Qt::AlignLeft);
 
-    mainLayout()->addWidget(m_pBookmarksComboBox, 2/*, Qt::AlignLeft*/);
-
-    m_pDeleteCurrentButton = new QIToolButton(this);
-    m_pDeleteCurrentButton->setIcon(m_pDeleteCurrentButton->style()->standardIcon(QStyle::SP_TitleBarCloseButton));
-
-    AssertPtrReturnVoid(m_pBookmarksComboBox);
-    mainLayout()->addWidget(m_pDeleteCurrentButton, 0);
-
-    m_pDeleteAllButton = new QPushButton(this);
-    AssertPtrReturnVoid(m_pDeleteAllButton);
-    mainLayout()->addWidget(m_pDeleteAllButton, 0);
-
-
-    m_pSpacerItem = new QSpacerItem(0, 0, QSizePolicy::Expanding, QSizePolicy::Minimum);
-    AssertPtrReturnVoid(m_pSpacerItem);
-    mainLayout()->addItem(m_pSpacerItem);
+    mainLayout()->addStretch(2);
 }
 
-void UIVMLogViewerBookmarksPanel::prepareConnections()
+void UIVMLogViewerSettingsPanel::prepareConnections()
 {
-    connect(m_pBookmarksComboBox, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
-            this, &UIVMLogViewerBookmarksPanel::sltBookmarkSelected);
-
-    connect(m_pDeleteAllButton, &QPushButton::clicked, this, &UIVMLogViewerBookmarksPanel::sigDeleteAllBookmarks);
-    connect(m_pDeleteCurrentButton, &QIToolButton::clicked, this, &UIVMLogViewerBookmarksPanel::sltDeleteCurrentBookmark);
+    if (m_pLineNumberCheckBox)
+        connect(m_pLineNumberCheckBox, &QCheckBox::toggled, this, &UIVMLogViewerSettingsPanel::sigShowLineNumbers);
+    if (m_pWrapLinesCheckBox)
+        connect(m_pWrapLinesCheckBox, &QCheckBox::toggled, this, &UIVMLogViewerSettingsPanel::sigWrapLines);
 }
 
+void UIVMLogViewerSettingsPanel::retranslateUi()
+{
+    UIVMLogViewerPanel::retranslateUi();
+    m_pLineNumberCheckBox->setText(UIVMLogViewerWidget::tr("Show Line Numbers"));
+    m_pLineNumberCheckBox->setToolTip(UIVMLogViewerWidget::tr("Show Line Numbers"));
 
-void UIVMLogViewerBookmarksPanel::retranslateUi()
-{
-    if (m_pDeleteCurrentButton)
-        m_pDeleteCurrentButton->setToolTip(UIVMLogViewerWidget::tr("Delete the current bookmark."));
-    if (m_pDeleteAllButton)
-    {
-        m_pDeleteAllButton->setToolTip(UIVMLogViewerWidget::tr("Delete all bookmarks."));
-        m_pDeleteAllButton->setText(UIVMLogViewerWidget::tr("Delete all"));
-    }
-    UIVMLogViewerPanel::retranslateUi();
+    m_pWrapLinesCheckBox->setText(UIVMLogViewerWidget::tr("Wrap Lines"));
+    m_pWrapLinesCheckBox->setToolTip(UIVMLogViewerWidget::tr("Wrap Lines"));
 }
-
-void UIVMLogViewerBookmarksPanel::sltDeleteCurrentBookmark()
-{
-    if (!m_pBookmarksComboBox)
-        return;
-
-    if (m_pBookmarksComboBox->currentIndex() == 0)
-        return;
-    emit sigDeleteBookmark(m_pBookmarksComboBox->currentIndex() - 1);
-}
-
-void UIVMLogViewerBookmarksPanel::sltBookmarkSelected(int index)
-{
-    /* Do nothing if the index is 0, that is combo box title item: */
-    if (index <= 0)
-        return;
-   emit sigBookmarkSelected(index - 1);
-}

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerSettingsPanel.h

@@ -16 +16 @@
  */
 
-#ifndef ___UIVMLogViewerBookmarksPanel_h___
-#define ___UIVMLogViewerBookmarksPanel_h___
+#ifndef ___UIVMLogViewerSettingssPanel_h___
+#define ___UIVMLogViewerSettingssPanel_h___
 
 /* GUI includes: */
@@ -23 +23 @@
 
 /* Forward declarations: */
-class QComboBox;
-class QPushButton;
-class QSpacerItem;
-class QIToolButton;
+class QCheckBox;
+class UIVMLogViewerWidget;
 
-/** UIVMLogViewerPanel extension providing GUI for bookmark management. Show a list of bookmarks currently set
-  for displayed log page. It has controls to navigate and clear bookmarks. */
-class UIVMLogViewerBookmarksPanel : public UIVMLogViewerPanel
+/** UIVMLogViewerPanel extension providing GUI to manage logviewer settings. */
+class UIVMLogViewerSettingsPanel : public UIVMLogViewerPanel
 {
     Q_OBJECT;
@@ -36 +33 @@
 signals:
 
-    void sigDeleteBookmark(int bookmarkIndex);
-    void sigDeleteAllBookmarks();
-    void sigBookmarkSelected(int index);
+    void sigShowLineNumbers(bool show);
+    void sigWrapLines(bool show);
 
 public:
 
-    UIVMLogViewerBookmarksPanel(QWidget *pParent, UIVMLogViewerWidget *pViewer);
+    UIVMLogViewerSettingsPanel(QWidget *pParent, UIVMLogViewerWidget *pViewer);
 
-    /* Adds a single bookmark to an existing list of bookmarks. Possibly called
-       by UIVMLogViewerWidget when user adds a bookmark thru context menu etc. */
-    void addBookmark(const QPair<int, QString> &newBookmark);
-    /* Clear the bookmark list and show this list instead. Probably done after
-       user switches to another log page tab etc. */
-    void setBookmarksList(const QVector<QPair<int, QString> > &bookmarkList);
-    void updateBookmarkList(const QVector<QPair<int, QString> > &bookmarkVector);
+    void setShowLineNumbers(bool bShowLineNumbers);
+    void setWrapLines(bool bWrapLines);
 
 public slots:
+
 
 protected:
@@ -64 +56 @@
 private slots:
 
-    void sltDeleteCurrentBookmark();
-    void sltBookmarkSelected(int index);
-
 private:
 
-    /* @a index is the index of the curent bookmark. */
-    void setBookmarkIndex(int index);
-
-    const int     m_iMaxBookmarkTextLength;
-    QComboBox    *m_pBookmarksComboBox;
-    QPushButton  *m_pDeleteAllButton;
-    QIToolButton *m_pDeleteCurrentButton;
-    QSpacerItem  *m_pSpacerItem;
+    QCheckBox   *m_pLineNumberCheckBox;
+    QCheckBox   *m_pWrapLinesCheckBox;
 };
 
-#endif /* !___UIVMLogViewerBookmarksPanel_h___ */
+#endif /* !___UIVMLogViewerSettingsPanel_h___ */

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerTextEdit.cpp

@@ -120 +120 @@
     QSize sizeHint() const
     {
-        if(!m_pTextEdit)
+        if (!m_pTextEdit)
             return QSize();
         return QSize(m_pTextEdit->lineNumberAreaWidth(), 0);
@@ -129 +129 @@
     void paintEvent(QPaintEvent *event)
     {
-        if(m_pTextEdit)
+        if (m_pTextEdit)
             m_pTextEdit->lineNumberAreaPaintEvent(event);
     }
@@ -154 +154 @@
     , m_mouseCursorLine(-1)
     , m_bShownTextIsFiltered(false)
+    , m_bShowLineNumbers(true)
+    , m_bWrapLines(false)
 {
     setMouseTracking(true);
@@ -190 +192 @@
     setWordWrapMode(QTextOption::NoWrap);
     setReadOnly(true);
-    if(m_pLineNumberArea)
+    if (m_pLineNumberArea)
         m_pLineNumberArea->setFont(font);
 
@@ -197 +199 @@
 int UIVMLogViewerTextEdit::lineNumberAreaWidth()
 {
+    if(!m_bShowLineNumbers)
+        return 0;
+
     int digits = 1;
     int max = qMax(1, blockCount());
@@ -211 +216 @@
 void UIVMLogViewerTextEdit::lineNumberAreaPaintEvent(QPaintEvent *event)
 {
+    if(!m_bShowLineNumbers)
+        return;
     QPainter painter(m_pLineNumberArea);
     painter.fillRect(event->rect(), Qt::lightGray);
@@ -228 +235 @@
                 painter.drawPath(path);
             }
-            if((blockNumber + 1) == m_mouseCursorLine)
+            if ((blockNumber + 1) == m_mouseCursorLine && underMouse())
             {
                 painter.setPen(Qt::red);
@@ -249 +256 @@
     /* If shown text is filtered, do not create Bookmark action since
        we disable all bookmarking related functionalities in this case. */
-    if(m_bShownTextIsFiltered)
+    if (m_bShownTextIsFiltered)
     {
         QPlainTextEdit::contextMenuEvent(pEvent);
@@ -278 +285 @@
         int rectX = viewport()->width() - rectWidth;
         int rectMargin = 4;
-        if(verticalScrollBar())
+        if (verticalScrollBar())
             rectX -= verticalScrollBar()->width();
         QPainter painter(viewport());
@@ -306 +313 @@
 }
 
+void UIVMLogViewerTextEdit::leaveEvent(QEvent * pEvent)
+{
+    QPlainTextEdit::leaveEvent(pEvent);
+    /* Force a redraw as mouse leaves this to remove the mouse
+       cursor track rectangle (the red rectangle we draw on the line number area. */
+    update();
+}
 
 void UIVMLogViewerTextEdit::sltUpdateLineNumberAreaWidth(int /* newBlockCount */)
@@ -331 +345 @@
 {
     UIIndicatorScrollBar* vScrollBar = qobject_cast<UIIndicatorScrollBar*>(verticalScrollBar());
-    if(vScrollBar)
+    if (vScrollBar)
         vScrollBar->setMarkingsVector(vector);
 }
@@ -338 +352 @@
 {
     UIIndicatorScrollBar* vScrollBar = qobject_cast<UIIndicatorScrollBar*>(verticalScrollBar());
-    if(vScrollBar)
+    if (vScrollBar)
         vScrollBar->clearMarkingsVector();
 }
@@ -345 +359 @@
 {
     QTextDocument* pDocument = document();
-    if(!pDocument)
+    if (!pDocument)
         return;
 
@@ -357 +371 @@
 {
     int height = 0;
-    if(viewport())
+    if (viewport())
         height = viewport()->height();
-    if(verticalScrollBar() && verticalScrollBar()->isVisible())
+    if (verticalScrollBar() && verticalScrollBar()->isVisible())
         height -= horizontalScrollBar()->height();
     int singleLineHeight = fontMetrics().lineSpacing();
-    if(singleLineHeight == 0)
+    if (singleLineHeight == 0)
         return 0;
     return height / singleLineHeight;
@@ -392 +406 @@
 void UIVMLogViewerTextEdit::toggleBookmark(const QPair<int, QString>& bookmark)
 {
-    if(m_bShownTextIsFiltered)
+    if (m_bShownTextIsFiltered)
         return;
 
     int lineNumber = bookmark.first;
 
-    if(m_bookmarkLineSet.contains(lineNumber))
+    if (m_bookmarkLineSet.contains(lineNumber))
         emit sigDeleteBookmark(bookmark);
     else
@@ -405 +419 @@
 void UIVMLogViewerTextEdit::setShownTextIsFiltered(bool warning)
 {
-    if(m_bShownTextIsFiltered == warning)
+    if (m_bShownTextIsFiltered == warning)
         return;
     m_bShownTextIsFiltered = warning;
 }
 
+void UIVMLogViewerTextEdit::setShowLineNumbers(bool bShowLineNumbers)
+{
+    if(m_bShowLineNumbers == bShowLineNumbers)
+        return;
+    m_bShowLineNumbers = bShowLineNumbers;
+    emit updateRequest(viewport()->rect(), 0);
+}
+
+void UIVMLogViewerTextEdit::setWrapLines(bool bWrapLines)
+{
+    if(m_bWrapLines == bWrapLines)
+        return;
+    m_bWrapLines = bWrapLines;
+    update();
+}
+
+
 #include "UIVMLogViewerTextEdit.moc"

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerTextEdit.h

@@ -49 +49 @@
     void setShownTextIsFiltered(bool warning);
 
+    void setShowLineNumbers(bool bShowLineNumbers);
+    void setWrapLines(bool bWrapLines);
+
 protected:
 
@@ -55 +58 @@
     virtual void resizeEvent(QResizeEvent *pEvent) /* override */;
     virtual void mouseMoveEvent(QMouseEvent *pEvent) /* override */;
+    virtual void leaveEvent(QEvent * event) /* override */;
 
 private slots:
@@ -84 +88 @@
         And we dont display bookmarks and adding/deleting bookmarks are disabled. */
     bool                 m_bShownTextIsFiltered;
+    bool                 m_bShowLineNumbers;
+    bool                 m_bWrapLines;
+
     friend class UILineNumberArea;
 };

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerWidget.cpp

@@ -43 +43 @@
 # include "UIVMLogViewerFilterPanel.h"
 # include "UIVMLogViewerSearchPanel.h"
+# include "UIVMLogViewerSettingsPanel.h"
 # include "UIToolBar.h"
 
@@ -61 +62 @@
     , m_pFilterPanel(0)
     , m_pBookmarksPanel(0)
+    , m_pSettingsPanel(0)
     , m_pMainLayout(0)
     , m_enmEmbedding(enmEmbedding)
@@ -70 +72 @@
     , m_pActionBookmark(0)
     , m_pMenu(0)
-    , m_bMarkBookmarkLines(0)
+    , m_bShowLineNumbers(true)
+    , m_bWrapLines(false)
+
 {
     /* Prepare VM Log-Viewer: */
@@ -110 +114 @@
 {
     UIVMLogPage* logPage = currentLogPage();
-    if(!logPage)
+    if (!logPage)
         return;
     logPage->deleteBookmark(index);
@@ -120 +124 @@
 {
     UIVMLogPage* logPage = currentLogPage();
-    if(!logPage)
+    if (!logPage)
         return;
     logPage->deleteAllBookmarks();
@@ -130 +134 @@
 void UIVMLogViewerWidget::sltUpdateBookmarkPanel()
 {
-    if(!currentLogPage() || !m_pBookmarksPanel)
+    if (!currentLogPage() || !m_pBookmarksPanel)
         return;
     disconnect(m_pBookmarksPanel, &UIVMLogViewerBookmarksPanel::sigBookmarkSelected,
@@ -141 +145 @@
 void UIVMLogViewerWidget::gotoBookmark(int bookmarkIndex)
 {
-    if(!currentLogPage())
+    if (!currentLogPage())
         return;
     currentLogPage()->scrollToBookmark(bookmarkIndex);
@@ -277 +281 @@
 void UIVMLogViewerWidget::sltFilterApplied(bool isOriginal)
 {
-    if(currentLogPage())
+    if (currentLogPage())
         currentLogPage()->setFiltered(!isOriginal);
     /* Reapply the search to get highlighting etc. correctly */
@@ -288 +292 @@
     /* Disable bookmark panel since bookmarks are stored as line numbers within
        the original log text and does not mean much in a reduced/filtered one. */
-    if(m_pBookmarksPanel)
-    {
-        if(isFiltered)
+    if (m_pBookmarksPanel)
+    {
+        if (isFiltered)
         {
             m_pBookmarksPanel->setEnabled(false);
@@ -300 +304 @@
 }
 
+void UIVMLogViewerWidget::sltShowLineNumbers(bool bShowLineNumbers)
+{
+    if (m_bShowLineNumbers == bShowLineNumbers)
+        return;
+
+    m_bShowLineNumbers = bShowLineNumbers;
+    /* Set all log page instances. */
+    for (int i = 0; i < m_logPageList.size(); ++i)
+    {
+        UIVMLogPage* pLogPage = qobject_cast<UIVMLogPage*>(m_logPageList[i]);
+        if (pLogPage)
+            pLogPage->setShowLineNumbers(m_bShowLineNumbers);
+    }
+}
+
+void UIVMLogViewerWidget::sltWrapLines(bool bWrapLines)
+{
+    if (m_bWrapLines == bWrapLines)
+        return;
+
+    m_bWrapLines = bWrapLines;
+    /* Set all log page instances. */
+    for (int i = 0; i < m_logPageList.size(); ++i)
+    {
+        UIVMLogPage* pLogPage = qobject_cast<UIVMLogPage*>(m_logPageList[i]);
+        if (pLogPage)
+            pLogPage->setWrapLines(m_bWrapLines);
+    }
+}
+
+
 void UIVMLogViewerWidget::setMachine(const CMachine &machine)
 {
@@ -330 +365 @@
     m_panelActionMap.insert(m_pSearchPanel, m_pActionFind);
     m_panelActionMap.insert(m_pFilterPanel, m_pActionFilter);
+    m_panelActionMap.insert(m_pSettingsPanel, m_pActionSettings);
 }
 
@@ -389 +425 @@
                 this, &UIVMLogViewerWidget::gotoBookmark);
     }
+
+    m_pSettingsPanel = new UIVMLogViewerSettingsPanel(this, this);
+    AssertPtrReturnVoid(m_pSettingsPanel);
+    {
+        installEventFilter(m_pSettingsPanel);
+        m_pSettingsPanel->hide();
+        /* Initialize settings' panel checkboxes: */
+        m_pSettingsPanel->setShowLineNumbers(m_bShowLineNumbers);
+        m_pSettingsPanel->setWrapLines(m_bWrapLines);
+
+        m_pMainLayout->insertWidget(5, m_pSettingsPanel);
+        connect(m_pSettingsPanel, &UIVMLogViewerSettingsPanel::sigShowLineNumbers, this, &UIVMLogViewerWidget::sltShowLineNumbers);
+        connect(m_pSettingsPanel, &UIVMLogViewerSettingsPanel::sigWrapLines, this, &UIVMLogViewerWidget::sltWrapLines);
+    }
 }
 
@@ -422 +472 @@
     }
 
+    /* Create and configure 'Settings' action: */
+    m_pActionSettings = new QAction(this);
+    AssertPtrReturnVoid(m_pActionSettings);
+    {
+        m_pActionSettings->setCheckable(true);
+        connect(m_pActionSettings, &QAction::triggered, this, &UIVMLogViewerWidget::sltPanelActionTriggered);
+    }
+
+
     /* Create and configure 'Refresh' action: */
     m_pActionRefresh = new QAction(this);
@@ -469 +528 @@
     if (m_pActionBookmark)
         m_pActionBookmark->setIcon(UIIconPool::iconSet(QString(":/%1_bookmark_24px.png").arg(strPrefix),
+                                                       QString(":/%1_bookmark_disabled_24px.png").arg(strPrefix)));
+
+    if (m_pActionSettings)
+        m_pActionSettings->setIcon(UIIconPool::iconSet(QString(":/%1_bookmark_24px.png").arg(strPrefix),
                                                        QString(":/%1_bookmark_disabled_24px.png").arg(strPrefix)));
 }
@@ -497 +560 @@
         if (m_pActionBookmark)
             m_pToolBar->addAction(m_pActionBookmark);
+
+        if (m_pActionSettings)
+            m_pToolBar->addAction(m_pActionSettings);
 
 #ifdef VBOX_WS_MAC
@@ -528 +594 @@
         if (m_pActionBookmark)
             m_pMenu->addAction(m_pActionBookmark);
-
+        if (m_pActionSettings)
+            m_pMenu->addAction(m_pActionSettings);
     }
 }
@@ -576 +643 @@
         m_pActionBookmark->setToolTip(tr("Bookmark the line"));
         m_pActionBookmark->setStatusTip(tr("Bookmark the line"));
+    }
+
+    if (m_pActionSettings)
+    {
+        m_pActionSettings->setText(tr("&Settings"));
+        m_pActionSettings->setToolTip(tr("LogViewer Settings"));
+        m_pActionSettings->setStatusTip(tr("LogViewer Settings"));
     }
 
@@ -606 +680 @@
 
     /* Make sure the log view widget has the focus: */
-    if(currentLogPage())
+    if (currentLogPage())
         currentLogPage()->setFocus();
 }
@@ -761 +835 @@
     /* Create page-container: */
     UIVMLogPage* pLogPage = new UIVMLogPage(this);
+    AssertPtrReturnVoid(pLogPage);
+
     connect(pLogPage, &UIVMLogPage::sigBookmarksUpdated, this, &UIVMLogViewerWidget::sltUpdateBookmarkPanel);
     connect(pLogPage, &UIVMLogPage::sigLogPageFilteredChanged, this, &UIVMLogViewerWidget::sltLogPageFilteredChanged);
-    AssertPtrReturnVoid(pLogPage);
+    /* Initialize setting for this log page */
+    pLogPage->setShowLineNumbers(m_bShowLineNumbers);
+    pLogPage->setWrapLines(m_bWrapLines);
     /* Set the file name only if we really have log file to read. */
     if (!noLogsToShow)

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerWidget.h

@@ -42 +42 @@
 class UIVMLogViewerPanel;
 class UIVMLogViewerSearchPanel;
+class UIVMLogViewerSettingsPanel;
 
 /* Type definitions: */
@@ -115 +116 @@
     void sltLogPageFilteredChanged(bool isFiltered);
 
+    void sltShowLineNumbers(bool bShowLineNumbers);
+    void sltWrapLines(bool bWrapLine);
+
 private:
 
@@ -174 +178 @@
     QVector<QWidget*>  m_logPageList;
 
-    /** Holds the index to the current tab: */
-    //int          m_iCurrentTabIndex;
-
-    /** Holds the instance of search-panel. */
-    UIVMLogViewerSearchPanel    *m_pSearchPanel;
-    /** Holds the instance of filter panel. */
-    UIVMLogViewerFilterPanel    *m_pFilterPanel;
-    UIVMLogViewerBookmarksPanel *m_pBookmarksPanel;
-    QMap<UIVMLogViewerPanel*, QAction*> m_panelActionMap;
-
-    /** Holds the list of log file content. */
-    // VMLogMap             m_logMap;
-    // mutable BookmarkMap  m_bookmarkMap;
+    /** @name Panel instances and a QMap for mapping panel instances to related actions.
+      * @{ */
+        UIVMLogViewerSearchPanel    *m_pSearchPanel;
+        UIVMLogViewerFilterPanel    *m_pFilterPanel;
+        UIVMLogViewerBookmarksPanel *m_pBookmarksPanel;
+        UIVMLogViewerSettingsPanel  *m_pSettingsPanel;
+        QMap<UIVMLogViewerPanel*, QAction*> m_panelActionMap;
+    /** @} */
     QVBoxLayout         *m_pMainLayout;
 
@@ -194 +193 @@
     /** @name Toolbar and menu variables.
       * @{ */
-        /** Holds the toolbar widget instance. */
         UIToolBar *m_pToolBar;
-        /** Holds the Find action instance. */
         QAction   *m_pActionFind;
-        /** Holds the Filter action instance. */
         QAction   *m_pActionFilter;
-        /** Holds the Refresh action instance. */
         QAction   *m_pActionRefresh;
-        /** Holds the Save action instance. */
         QAction   *m_pActionSave;
-        /** Holds the Bookmark action instance. */
         QAction   *m_pActionBookmark;
-        /** Holds the menu object instance. */
+        QAction   *m_pActionSettings;
         QMenu     *m_pMenu;
     /** @} */
-    const bool     m_bMarkBookmarkLines;
+
+    /** @name Toolbar and menu variables.
+     * @{ */
+        /** Showing/hiding line numbers and line wraping settings are set per
+            UIVMLogViewerWidget and applies to all log pages (all tabs) */
+        bool m_bShowLineNumbers;
+        bool m_bWrapLines;
+    /** @} */
+
     friend class UIVMLogViewerBookmarksPanel;
     friend class UIVMLogViewerFilterPanel;
     friend class UIVMLogViewerSearchPanel;
+    friend class UIVMLogViewerSettingsPanel;
     friend class UIVMLogViewerPanel;
 };