Changeset 70693 in vbox for trunk/src/VBox/Devices/USB

Timestamp:

Jan 22, 2018 9:02:01 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

120429

Message:

VUSB/VUSBDevice: Avoid that the device is destroyed while in certain code paths by using locking

File:

• trunk/src/VBox/Devices/USB/VUSBDevice.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/USB/VUSBDevice.cpp

@@ -309 +309 @@
     if (pDev->pUsbIns->pReg->pfnUsbSetConfiguration)
     {
+        RTCritSectEnter(&pDev->pHub->pRootHub->CritSectDevices);
         int rc = vusbDevIoThreadExecSync(pDev, (PFNRT)pDev->pUsbIns->pReg->pfnUsbSetConfiguration, 5,
                                          pDev->pUsbIns, pNewCfgDesc->Core.bConfigurationValue,
@@ -317 +318 @@
             return false;
         }
+        RTCritSectLeave(&pDev->pHub->pRootHub->CritSectDevices);
     }
     Log(("vusb: %p[%s]: SET_CONFIGURATION: Selected config %u\n", pDev, pDev->pUsbIns->pszName, iCfg));
@@ -457 +459 @@
     if (pDev->pUsbIns->pReg->pfnUsbSetInterface)
     {
+        RTCritSectEnter(&pDev->pHub->pRootHub->CritSectDevices);
         int rc = vusbDevIoThreadExecSync(pDev, (PFNRT)pDev->pUsbIns->pReg->pfnUsbSetInterface, 3, pDev->pUsbIns, iIf, iAlt);
         if (RT_FAILURE(rc))
@@ -463 +466 @@
             return false;
         }
+        RTCritSectLeave(&pDev->pHub->pRootHub->CritSectDevices);
     }
 
@@ -529 +533 @@
                 &&  pDev->pUsbIns->pReg->pfnUsbClearHaltedEndpoint)
             {
+                RTCritSectEnter(&pDev->pHub->pRootHub->CritSectDevices);
                 int rc = vusbDevIoThreadExecSync(pDev, (PFNRT)pDev->pUsbIns->pReg->pfnUsbClearHaltedEndpoint,
                                                  2, pDev->pUsbIns, pSetup->wIndex);
+                RTCritSectLeave(&pDev->pHub->pRootHub->CritSectDevices);
                 return RT_SUCCESS(rc);
             }