Changeset 70696 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

Jan 23, 2018 4:28:54 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

120433

Message:

bootsectors/bs3-cpu-instr-2: Use the FS/GS base MSR to verify initial, existing base address read test.

File:

• trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-2-template.c (modified) (7 diffs)

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-2-template.c

@@ -848 +848 @@
 
 static void bs3CpuInstr2_rdfsbase_rdgsbase_Common(uint8_t bMode, BS3CI2FSGSBASE const *paFsGsBaseWorkers,
-                                                  unsigned cFsGsBaseWorkers)
+                                                  unsigned cFsGsBaseWorkers, uint32_t idxFsGsBaseMsr)
 {
     BS3REGCTX         Ctx;
@@ -877 +877 @@
         if (fSupportsFsGsBase)
         {
+            uint64_t uBaseAddr;
+
             /* CR4.FSGSBASE disabled -> #UD. */
             Ctx.cr4.u &= ~X86_CR4_FSGSBASE;
             bs3CpuInstr2_fsgsbase_ExpectUD(bMode, &Ctx, &ExpectCtx, &TrapFrame);
 
-            /* Read any existing base address. */
-            Ctx.rbx.u  = 0xa0000;
+            /* Read and verify existing base address. */
+            uBaseAddr  = ASMRdMsr(idxFsGsBaseMsr);
+            Ctx.rbx.u  = 0;
             Ctx.cr4.u |= X86_CR4_FSGSBASE;
             Bs3MemCpy(&ExpectCtx, &Ctx, sizeof(ExpectCtx));
             Bs3TrapSetJmpAndRestore(&Ctx, &TrapFrame);
             ExpectCtx.rip.u       = Ctx.rip.u + paFsGsBaseWorkers[iWorker].offWorkerUd2;
-            ExpectCtx.rbx.u       = TrapFrame.Ctx.rbx.u;
+            ExpectCtx.rbx.u       = uBaseAddr;
             ExpectCtx.rflags.u32 |= X86_EFL_RF;
             if (!Bs3TestCheckRegCtxEx(&TrapFrame.Ctx, &ExpectCtx, 0 /*cbPcAdjust*/, 0 /*cbSpAdjust*/, 0 /*fExtraEfl*/, "lm64",
@@ -895 +898 @@
             }
 
-            /* Write and read back the address. */
+            /* Write, read and verify series of base addresses. */
             if (!bs3CpuInstr2_fsgsbase_VerifyWorker(bMode, &Ctx, &ExpectCtx, &TrapFrame, &paFsGsBaseWorkers[iWorker], &iIter))
             {
@@ -950 +953 @@
             bs3CpuInstr2_fsgsbase_ExpectUD(bMode, &Ctx, &ExpectCtx, &TrapFrame);
 
-            /* Write the base address. */
+            /* Write a base address. */
             Ctx.rbx.u  = 0xa0000;
             Ctx.cr4.u |= X86_CR4_FSGSBASE;
@@ -963 +966 @@
             }
 
-            /* Write and read back the address. */
+            /* Write and read back series of base addresses. */
             if (!bs3CpuInstr2_fsgsbase_VerifyWorker(bMode, &Ctx, &ExpectCtx, &TrapFrame, &paFsGsBaseWorkers[iWorker], &iIter))
             {
@@ -1000 +1003 @@
 BS3_DECL_FAR(uint8_t) BS3_CMN_NM(bs3CpuInstr2_rdfsbase)(uint8_t bMode)
 {
-    bs3CpuInstr2_rdfsbase_rdgsbase_Common(bMode, s_aRdFsBaseWorkers, RT_ELEMENTS(s_aRdFsBaseWorkers));
+    bs3CpuInstr2_rdfsbase_rdgsbase_Common(bMode, s_aRdFsBaseWorkers, RT_ELEMENTS(s_aRdFsBaseWorkers), MSR_K8_FS_BASE);
     return 0;
 }
@@ -1007 +1010 @@
 BS3_DECL_FAR(uint8_t) BS3_CMN_NM(bs3CpuInstr2_rdgsbase)(uint8_t bMode)
 {
-    bs3CpuInstr2_rdfsbase_rdgsbase_Common(bMode, s_aRdGsBaseWorkers, RT_ELEMENTS(s_aRdGsBaseWorkers));
+    bs3CpuInstr2_rdfsbase_rdgsbase_Common(bMode, s_aRdGsBaseWorkers, RT_ELEMENTS(s_aRdGsBaseWorkers), MSR_K8_GS_BASE);
     return 0;
 }