Changeset 70827 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jan 31, 2018 12:26:20 PM (7 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9104: Reworking VBoxVersion stuff: Refactoring.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/UIVersion.h (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIVersion.h

@@ -25 +25 @@
 
     /** Constructs default object. */
-    UIVersion() : m_x(-1), m_y(-1), m_z(-1) {}
+    UIVersion()
+        : m_x(-1), m_y(-1), m_z(-1)
+    {}
 
     /** Constructs object based on parsed @a strVersion. */
@@ -31 +33 @@
         : m_x(-1), m_y(-1), m_z(-1)
     {
-        QStringList versionStack = strVersion.split('.');
+        const QStringList versionStack = strVersion.split('.');
         if (versionStack.size() > 0)
             m_x = versionStack[0].toInt();
@@ -40 +42 @@
     }
 
-    /** Assigns this object with value of @a other. */
-    UIVersion& operator=(const UIVersion &other) { m_x = other.x(); m_y = other.y(); m_z = other.z(); return *this; }
+    /** Assigns this object with value of @a another. */
+    UIVersion &operator=(const UIVersion &another)
+    {
+        m_x = another.x();
+        m_y = another.y();
+        m_z = another.z();
+        return *this;
+    }
 
     /** Returns whether this object is valid. */
-    bool isValid() const { return m_x != -1 && m_y != -1 && m_z != -1; }
+    bool isValid() const { return (m_x != -1) && (m_y != -1) && (m_z != -1); }
 
     /** Returns whether this object is equal to @a other. */
@@ -56 +64 @@
     bool operator<(const UIVersion &other) const
     {
-        return (m_x <  other.m_x) ||
-               (m_x == other.m_x && m_y <  other.m_y) ||
-               (m_x == other.m_x && m_y == other.m_y && m_z <  other.m_z);
+        return    (m_x <  other.m_x)
+               || (m_x == other.m_x && m_y <  other.m_y)
+               || (m_x == other.m_x && m_y == other.m_y && m_z <  other.m_z);
     }
     /** Checks whether this object is more than @a other. */
     bool operator>(const UIVersion &other) const
     {
-        return (m_x >  other.m_x) ||
-               (m_x == other.m_x && m_y >  other.m_y) ||
-               (m_x == other.m_x && m_y == other.m_y && m_z >  other.m_z);
+        return    (m_x >  other.m_x)
+               || (m_x == other.m_x && m_y >  other.m_y)
+               || (m_x == other.m_x && m_y == other.m_y && m_z >  other.m_z);
     }
 
     /** Returns object string representation. */
-    QString toString() const
-    {
-        return QString("%1.%2.%3").arg(m_x).arg(m_y).arg(m_z);
-    }
+    QString toString() const { return QString("%1.%2.%3").arg(m_x).arg(m_y).arg(m_z); }
 
     /** Returns the object X value. */