Changeset 70894 in vbox for trunk/src/VBox/Devices

Timestamp:

Feb 7, 2018 5:13:53 PM (7 years ago)

Author:

vboxsync

Message:

Audio/DevHDA.cpp: Save a lot of stream startup time by avoiding to create/destroy the driver stream in hdaAddStream(). The driver streams already are getting created/destroyed hdaMixerAddStream/hdaMixerDestroyStream.

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -1959 +1959 @@
     AssertPtrReturn(pCfg,  VERR_INVALID_POINTER);
 
-    int rc = VINF_SUCCESS;
-
-    PHDADRIVER pDrv;
-    RTListForEach(&pThis->lstDrv, pDrv, HDADRIVER, Node)
-    {
-        int rc2;
-
-        switch (pCfg->enmDir)
-        {
-            case PDMAUDIODIR_OUT:
-                rc2 = hdaAddStreamOut(pThis, pCfg);
-                break;
-
-            case PDMAUDIODIR_IN:
-                rc2 = hdaAddStreamIn(pThis, pCfg);
-                break;
-
-            default:
-                rc2 = VERR_NOT_SUPPORTED;
-                AssertFailed();
-                break;
-        }
-
-        if (   RT_FAILURE(rc2)
-            && (pDrv->fFlags & PDMAUDIODRVFLAGS_PRIMARY)) /* We only care about primary drivers here, the rest may fail. */
-        {
-            if (RT_SUCCESS(rc))
-                rc = rc2;
-            /* Keep going. */
-        }
-    }
+    int rc;
+
+    LogFlowFuncEnter();
+
+    switch (pCfg->enmDir)
+    {
+        case PDMAUDIODIR_OUT:
+            rc = hdaAddStreamOut(pThis, pCfg);
+            break;
+
+        case PDMAUDIODIR_IN:
+            rc = hdaAddStreamIn(pThis, pCfg);
+            break;
+
+        default:
+            rc = VERR_NOT_SUPPORTED;
+            AssertFailed();
+            break;
+    }
+
+    LogFlowFunc(("Returning %Rrc\n", rc));
 
     return rc;