Changeset 70902 in vbox for trunk/src/VBox/Devices

Timestamp:

Feb 8, 2018 10:02:08 AM (7 years ago)

Author:

vboxsync

Message:

Audio/DrvAudio.cpp: Make sure to disable the backend first before destroying it and check for this in strict builds.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -517 +517 @@
                 if (RT_SUCCESS(rc))
                 {
-                    pHstStream->fStatus &= ~(PDMAUDIOSTREAMSTS_FLAG_ENABLED | PDMAUDIOSTREAMSTS_FLAG_PENDING_DISABLE);
+                    pHstStream->fStatus = PDMAUDIOSTREAMSTS_FLAG_INITIALIZED; /* Reset to initialized state. */
                     AudioMixBufReset(&pHstStream->MixBuf);
                 }
@@ -3137 +3137 @@
         {
             pHstStream->fStatus &= ~PDMAUDIOSTREAMSTS_FLAG_INITIALIZED;
-#if 0 /** @todo r=andy Disabled for now -- need to test this on Windows hosts. */
-            Assert(pHstStream->fStatus == PDMAUDIOSTRMSTS_FLAG_NONE);
+
+#ifdef VBOX_STRICT
+            pszHstSts = dbgAudioStreamStatusToStr(pHstStream->fStatus);
+            AssertMsg(pHstStream->fStatus == PDMAUDIOSTREAMSTS_FLAG_NONE,
+                      ("Stream '%s' still has %s set when destroying, must close properly first\n",
+                       pHstStream->szName, pszHstSts));
+            RTStrFree(pszHstSts);
 #endif
         }
@@ -3280 +3285 @@
     PPDMAUDIOSTREAM pStream;
     RTListForEach(&pThis->lstHstStreams, pStream, PDMAUDIOSTREAM, Node)
+    {
+        drvAudioStreamControlInternalBackend(pThis, pStream, PDMAUDIOSTREAMCMD_DISABLE);
         drvAudioStreamDestroyInternalBackend(pThis, pStream);
+    }
 
     /*