Changeset 70910 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Feb 8, 2018 12:37:31 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

120738

Message:

Audio/DrvAudio.cpp: Log if host stream has pending operations left in drvAudioStreamDestroyInternalBackend().

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -138 +138 @@
 # endif /* unused */
 
-#if defined(VBOX_STRICT) || defined(LOG_ENABLED)
+#ifdef LOG_ENABLED
 /**
  * Converts an audio stream status to a string.
@@ -3122 +3122 @@
     int rc = VINF_SUCCESS;
 
-#ifdef VBOX_STRICT
+#ifdef LOG_ENABLED
     char *pszHstSts = dbgAudioStreamStatusToStr(pHstStream->fStatus);
     LogFunc(("[%s] fStatus=%s\n", pHstStream->szName, pszHstSts));
@@ -3138 +3138 @@
             pHstStream->fStatus &= ~PDMAUDIOSTREAMSTS_FLAG_INITIALIZED;
 
-#ifdef VBOX_STRICT
-            pszHstSts = dbgAudioStreamStatusToStr(pHstStream->fStatus);
-            AssertMsg(pHstStream->fStatus == PDMAUDIOSTREAMSTS_FLAG_NONE,
-                      ("Stream '%s' still has %s set when destroying, must close properly first\n",
-                       pHstStream->szName, pszHstSts));
-            RTStrFree(pszHstSts);
+#ifdef LOG_ENABLED
+            /* This is not fatal, but log it anyway. */
+            if (pHstStream->fStatus != PDMAUDIOSTREAMSTS_FLAG_NONE)
+                LogFunc(("[%s] Warning: Stream still has %s set when destroying, must properly drain first\n",
+                         pHstStream->szName, pszHstSts));
 #endif
         }