Changeset 70961 in vbox for trunk/src/VBox/Storage

Timestamp:

Feb 11, 2018 12:06:03 PM (7 years ago)

Author:

vboxsync

Message:

Storage/QCOW: Fix bug introduced in r120663 which caused creation of broken QCOW images with certain sizes failing to get opened later. The fix to enforce at least 1 L1 table entry was completely wrong, there wasn't anything needing fixing as the line below would enforce that already. Only aligning the L1 table to a cluster size is required actually.

File:

• trunk/src/VBox/Storage/QCOW.cpp (modified) (1 diff)

trunk/src/VBox/Storage/QCOW.cpp

@@ -1286 +1286 @@
                 pImage->cbL2Table          = qcowCluster2Byte(pImage, QCOW_L2_CLUSTERS_DEFAULT);
                 pImage->cL2TableEntries    = pImage->cbL2Table / sizeof(uint64_t);
-                pImage->cL1TableEntries    = RT_MIN(1, cbSize / (pImage->cbCluster * pImage->cL2TableEntries));
+                pImage->cL1TableEntries    = cbSize / (pImage->cbCluster * pImage->cL2TableEntries);
                 if (cbSize % (pImage->cbCluster * pImage->cL2TableEntries))
                     pImage->cL1TableEntries++;