Changeset 71139 in vbox for trunk/src/VBox/Main/src-server/win

Timestamp:

Feb 27, 2018 5:48:13 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

121027

Message:

Main/VBoxSVC,VBoxSDS: fix for ​bugref:8161: added API client list interface to VBoxSDS, forcibly closes all VirtualBox clients process on Windows 7 at system shutdown. Added functionality to close VBoxSDS and VBoxSVC services automatically if the API client finished unexpectedly (crashed).

File:

• trunk/src/VBox/Main/src-server/win/svcmain.cpp (modified) (11 diffs)

trunk/src/VBox/Main/src-server/win/svcmain.cpp

@@ -28 +28 @@
 #include "VBox/com/com.h"
 #include "VBox/com/VirtualBox.h"
+#include "VBox/com/array.h"
 
 #include "VirtualBoxImpl.h"
@@ -44 +45 @@
 #include <iprt/asm.h>
 
+#include <TlHelp32.h>
 
 /*********************************************************************************************************************************
@@ -94 +96 @@
 volatile uint32_t dwTimeOut = dwNormalTimeout; /* time for EXE to be idle before shutting down. Can be decreased at system shutdown phase. */
 
+
+BOOL CALLBACK CloseWindowProc(_In_ HWND   hWnd, _In_ LPARAM /* lParam */)
+{
+    _ASSERTE(hWnd);
+    DWORD_PTR dwResult;
+    // Close topmost windows in the thread
+    LRESULT lResult = SendMessageTimeout(hWnd, WM_CLOSE, NULL, NULL,
+        SMTO_ABORTIFHUNG | SMTO_BLOCK, 0, &dwResult);
+    if (lResult != 0)
+    {
+        LogRel(("EnumThreadWndProc: Close message sent to window %x successfully \n", hWnd));
+    }
+    else
+    {
+        LogRel(("EnumThreadWndProc: Cannot send event to window %x. result: %d, last error: %x\n",
+            hWnd, dwResult, GetLastError()));
+    }
+    return TRUE;
+}
+
+void SendCloseToAllThreads(DWORD dwTargetPid)
+{
+    HANDLE hSnapshot = CreateToolhelp32Snapshot(TH32CS_SNAPTHREAD, 0);
+    if (hSnapshot == NULL)
+    {
+        LogRel(("SendCloseToAllThreads: cannot get threads snapshot. error: 0x%x \n",
+            GetLastError()));
+        return;
+    }
+
+    THREADENTRY32 threadEntry;
+    ZeroMemory(&threadEntry, sizeof(threadEntry));
+    threadEntry.dwSize = sizeof(threadEntry);
+
+    if (Thread32First(hSnapshot, &threadEntry))
+    {
+        do
+        {
+            LogRel(("SendCloseToAllThreads: process: %d thread: %x \n",
+                threadEntry.th32OwnerProcessID, threadEntry.th32ThreadID));
+            if (threadEntry.th32OwnerProcessID == dwTargetPid)
+            {
+                BOOL bRes = EnumThreadWindows(threadEntry.th32ThreadID, CloseWindowProc, NULL);
+                if (!bRes)
+                {
+                    LogRel(("SendCloseToAllThreads: EnumThreadWindows() failed to enumerate threads. error: %x \n",
+                        GetLastError()));
+                }
+                else
+                {
+                    LogRel(("SendCloseToAllThreads: about to close window in thread %x of process d\n",
+                        threadEntry.th32ThreadID, dwTargetPid));
+                }
+            }
+        } while (Thread32Next(hSnapshot, &threadEntry));
+    }
+    CloseHandle(hSnapshot);
+}
+
+static int CloseActiveClients()
+{
+    ComPtr<IVirtualBoxClientList> ptrClientList;
+    /*
+    * Connect to VBoxSDS.
+    */
+    // TODO: here we close all API client processes: our own and customers
+    LogRelFunc(("Forcibly close API clients during system shutdown on Windows 7:\n"));
+    HRESULT hrc = CoCreateInstance(CLSID_VirtualBoxClientList, NULL, CLSCTX_LOCAL_SERVER, IID_IVirtualBoxClientList,
+        (void **)ptrClientList.asOutParam());
+    if (SUCCEEDED(hrc))
+    {
+        com::SafeArray<LONG> aCllients;
+        hrc = ptrClientList->get_Clients(aCllients.__asOutParam());
+        RTCList<LONG> clientsList = aCllients.toList();
+        LogRel(("==========Client list begin ========\n"));
+        for (int i = 0; i < clientsList.size(); i++)
+        {
+            LogRel(("About to close client pid: %d\n", clientsList[i]));
+            SendCloseToAllThreads(clientsList[i]);
+        }
+        LogRel(("==========Client list end ========\n"));
+    }
+    else
+    {
+        LogFunc(("Error to connect to VBoxSDS: hr=%Rhrf\n", hrc));
+    }
+    return 0;
+}
+
+// These are copies of functions defined in VersionHelpers.h
+bool IsWindowsVersionOrGreaterWrap(WORD wMajorVersion, WORD wMinorVersion, WORD wServicePackMajor)
+{
+    OSVERSIONINFOEXW osvi = { sizeof(osvi), 0, 0, 0, 0,{ 0 }, 0, 0 };
+    DWORDLONG        const dwlConditionMask = VerSetConditionMask(
+        VerSetConditionMask(
+            VerSetConditionMask(
+                0, VER_MAJORVERSION, VER_GREATER_EQUAL),
+            VER_MINORVERSION, VER_GREATER_EQUAL),
+        VER_SERVICEPACKMAJOR, VER_GREATER_EQUAL);
+
+    osvi.dwMajorVersion = wMajorVersion;
+    osvi.dwMinorVersion = wMinorVersion;
+    osvi.wServicePackMajor = wServicePackMajor;
+
+    return VerifyVersionInfoW(&osvi, VER_MAJORVERSION | VER_MINORVERSION | VER_SERVICEPACKMAJOR, dwlConditionMask) != FALSE;
+}
+
+
+#if !defined _WIN32_WINNT_WIN8
+
+#define _WIN32_WINNT_WIN8                   0x0602
+
+#endif  // #if !defined _WIN32_WINNT_WIN8
+
+bool IsWindows8OrGreaterWrap()
+{
+    return IsWindowsVersionOrGreaterWrap(HIBYTE(_WIN32_WINNT_WIN8), LOBYTE(_WIN32_WINNT_WIN8), 0);
+}
 
 
@@ -241 +361 @@
     HRESULT VirtualBoxClassFactory::i_registerWithSds(IUnknown **ppOtherVirtualBox);
     void    VirtualBoxClassFactory::i_deregisterWithSds(void);
+    void    VirtualBoxClassFactory::i_finishVBoxSvc();
 
     friend VBoxSVCRegistration;
@@ -311 +432 @@
             return m_pFactory->i_getVirtualBox(ppResult);
         return E_FAIL;
+    }
+
+    // IVBoxSVCRegistration: called from
+    STDMETHOD(NotifyClientsFinished)()
+    {
+        LogRelFunc(("All clients gone - shutdown sequence initiated\n"));
+
+        m_pFactory->i_finishVBoxSvc();
+
+        // This is not enough to finish VBoxSvc such as reference to crashed client still is in action
+        // So I forcebly shutdown VBoxSvc
+        while (g_pModule->Unlock() > 0)
+        {};
+
+        return S_OK;
     }
 };
@@ -354 +490 @@
             NOREF(hrc);
         }
-        m_ptrVirtualBoxSDS.setNull();
-        g_fRegisteredWithVBoxSDS = false;
-    }
-    if (m_pVBoxSVC)
-    {
-        m_pVBoxSVC->m_pFactory = NULL;
-        m_pVBoxSVC->Release();
-        m_pVBoxSVC = NULL;
-    }
+    }
+    i_finishVBoxSvc();
 }
 
@@ -381 +510 @@
     Log(("VirtualBoxClassFactory::GetVirtualBox: E_FAIL\n"));
     return E_FAIL;
+}
+
+
+void    VirtualBoxClassFactory::i_finishVBoxSvc()
+{
+    LogRelFunc(("Finish work of VBoxSVc and VBoxSDS\n"));
+    if (m_ptrVirtualBoxSDS.isNotNull())
+    {
+        m_ptrVirtualBoxSDS.setNull();
+        g_fRegisteredWithVBoxSDS = false;
+    }
+    if (m_pVBoxSVC)
+    {
+        m_pVBoxSVC->m_pFactory = NULL;
+        m_pVBoxSVC->Release();
+        m_pVBoxSVC = NULL;
+    }
 }
 
@@ -536 +682 @@
                     Log(("VBoxSVCWinMain: WM_QUERYENDSESSION: VBoxSvc has active connections. bActivity = %d. Loc count = %d\n",
                          g_pModule->bActivity, g_pModule->GetLockCount()));
+
+                    // On Windows 7 our clients doesn't receive right sequence of Session End events
+                    // So we send them all WM_QUIT to forcible close them.
+                    // Windows 10 sends end session events correctly
+                    // Note: the IsWindows8Point1() and IsWindows10OrGreater() doesnt work in
+                    // application without manifest so I use old compatible functions for detection of Win 7
+                    if(!IsWindows8OrGreaterWrap())
+                        CloseActiveClients();
                 }
                 rc = !fActiveConnection;
@@ -629 +783 @@
         }
     }
+}
+
+
+int SetServiceEnvFlag()
+{
+    int rc = VINF_SUCCESS;
+    if (!SetEnvironmentVariable(L"VBOX_SERVICE_PROCESS", L""))
+    {
+        rc = RTErrConvertFromWin32(GetLastError());
+        LogRel(("Error: cannot set service environment flag:  %Rrs\n", rc));
+    }
+    return rc;
 }
 
@@ -667 +833 @@
      */
     RTR3InitExe(argc, &argv, 0);
+
+    SetServiceEnvFlag();
 
     static const RTGETOPTDEF s_aOptions[] =
@@ -873 +1041 @@
             if (RT_FAILURE(vrc))
             {
-                Log(("SVCMAIN: Failed to process Helper request (%Rrc).", vrc));
+                Log(("SVCMAIN: Failed to process Helper request (%Rrc).\n", vrc));
                 nRet = 1;
             }