Changeset 71184 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Mar 3, 2018 3:01:59 PM (7 years ago)

Author:

vboxsync

Message:

CPUM,NEM: Introduced CPUMCTX field for tracking state that's not in the structure. Made NEM/win only get/set the register it needs. New NEM runloop based on low level messages, skipping translations. bugref:9044

File:

• trunk/src/VBox/VMM/VMMR3/NEMR3Native-win.cpp (modified) (19 diffs)

trunk/src/VBox/VMM/VMMR3/NEMR3Native-win.cpp

@@ -210 +210 @@
 # define WHvGetVirtualProcessorRegisters            g_pfnWHvGetVirtualProcessorRegisters
 # define WHvSetVirtualProcessorRegisters            g_pfnWHvSetVirtualProcessorRegisters
+
+# define VidMessageSlotHandleAndGetNext             g_pfnVidMessageSlotHandleAndGetNext
+# define VidStartVirtualProcessor                    g_pfnVidStartVirtualProcessor
+# define VidStopVirtualProcessor                    g_pfnVidStopVirtualProcessor
+
 #endif
 
@@ -1337 +1342 @@
 }
 
-
-#ifdef LOG_ENABLED
-
+#ifndef NEM_WIN_USE_OUR_OWN_RUN_API
+
+# ifdef LOG_ENABLED
 /**
  * Log the full details of an exit reason.
@@ -1392 +1397 @@
             break;
 
-# if 0
+#  if 0
         case WHvRunVpExitReasonUnrecoverableException:
         case WHvRunVpExitReasonInvalidVpRegisterValue:
@@ -1410 +1415 @@
             WHV_X64_UNSUPPORTED_FEATURE_CONTEXT UnsupportedFeature;
             WHV_RUN_VP_CANCELED_CONTEXT CancelReason;
-#endif
+#  endif
 
         case WHvRunVpExitReasonNone:
@@ -1455 +1460 @@
     }
 }
-
-#endif /* LOG_ENABLED */
+# endif /* LOG_ENABLED */
+
+
+/**
+ * Advances the guest RIP and clear EFLAGS.RF.
+ *
+ * This may clear VMCPU_FF_INHIBIT_INTERRUPTS.
+ *
+ * @param   pVCpu           The cross context virtual CPU structure.
+ * @param   pCtx            The CPU context to update.
+ * @param   pExitCtx        The exit context.
+ */
+DECLINLINE(void) nemR3WinAdvanceGuestRipAndClearRF(PVMCPU pVCpu, PCPUMCTX pCtx, WHV_VP_EXIT_CONTEXT const *pExitCtx)
+{
+    /* Advance the RIP. */
+    Assert(pExitCtx->InstructionLength > 0 && pExitCtx->InstructionLength < 16);
+    pCtx->rip += pExitCtx->InstructionLength;
+    pCtx->rflags.Bits.u1RF = 0;
+
+    /* Update interrupt inhibition. */
+    if (!VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INHIBIT_INTERRUPTS))
+    { /* likely */ }
+    else if (pCtx->rip != EMGetInhibitInterruptsPC(pVCpu))
+        VMCPU_FF_CLEAR(pVCpu, VMCPU_FF_INHIBIT_INTERRUPTS);
+}
 
 
@@ -1467 +1495 @@
 
 
-#ifndef NEM_WIN_USE_HYPERCALLS_FOR_PAGES
+# ifndef NEM_WIN_USE_HYPERCALLS_FOR_PAGES
 /**
  * @callback_method_impl{FNPGMPHYSNEMENUMCALLBACK,
@@ -1493 +1521 @@
     return VINF_SUCCESS;
 }
-#endif /* !NEM_WIN_USE_HYPERCALLS_FOR_PAGES */
+# endif /* !NEM_WIN_USE_HYPERCALLS_FOR_PAGES */
 
 
@@ -1587 +1615 @@
                                       pIoPortCtx->AccessInfo.AccessSize);
             if (IOM_SUCCESS(rcStrict))
-                nemHCWinAdvanceGuestRipAndClearRF(pVCpu, pCtx, &pIoPortCtx->VpContext);
+                nemR3WinAdvanceGuestRipAndClearRF(pVCpu, pCtx, &pIoPortCtx->VpContext);
         }
         else
@@ -1597 +1625 @@
             {
                 pCtx->eax = (pCtx->eax & ~fAndMask) | (uValue & fAndMask);
-                nemHCWinAdvanceGuestRipAndClearRF(pVCpu, pCtx, &pIoPortCtx->VpContext);
+                nemR3WinAdvanceGuestRipAndClearRF(pVCpu, pCtx, &pIoPortCtx->VpContext);
             }
         }
@@ -1692 +1720 @@
 VBOXSTRICTRC nemR3WinWHvRunGC(PVM pVM, PVMCPU pVCpu)
 {
-#ifdef LOG_ENABLED
+# ifdef LOG_ENABLED
     if (LogIs3Enabled())
     {
@@ -1698 +1726 @@
         nemHCWinLogState(pVM, pVCpu);
     }
-#endif
+# endif
 
     /*
@@ -1725 +1753 @@
             && !VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_HM_TO_R3_MASK))
         {
-#ifdef NEM_WIN_USE_OUR_OWN_RUN_API
-            int rc2 = nemHCWinRunVirtualProcessor(pVM, pVCpu, &ExitReason, sizeof(ExitReason));
-            AssertRCBreakStmt(rc2, rcStrict = rc2);
-#else
             Log8(("Calling WHvRunVirtualProcessor\n"));
             VMCPU_CMPXCHG_STATE(pVCpu, VMCPUSTATE_STARTED_EXEC_NEM, VMCPUSTATE_STARTED);
@@ -1739 +1763 @@
             Log2(("WHvRunVirtualProcessor -> %#x; exit code %#x (%d) (cpu status %u)\n",
                   hrc, ExitReason.ExitReason, ExitReason.ExitReason, nemR3WinCpuGetRunningStatus(pVCpu) ));
-#endif
         }
         else
@@ -1753 +1776 @@
         AssertRCBreakStmt(rc2, rcStrict = rc2);
 
-#ifdef LOG_ENABLED
+# ifdef LOG_ENABLED
         /*
          * Do some logging.
@@ -1761 +1784 @@
         if (LogIs3Enabled())
             nemHCWinLogState(pVM, pVCpu);
-#endif
-
-#ifdef VBOX_STRICT
+# endif
+
+# ifdef VBOX_STRICT
         /* Assert that the VpContext field makes sense. */
         switch (ExitReason.ExitReason)
@@ -1792 +1815 @@
             default: break; /* shut up compiler. */
         }
-#endif
+# endif
 
         /*
@@ -1859 +1882 @@
         }
 
-#ifndef NEM_WIN_USE_HYPERCALLS_FOR_PAGES
+# ifndef NEM_WIN_USE_HYPERCALLS_FOR_PAGES
         /* Hack alert! */
         uint32_t const cMappedPages = pVM->nem.s.cMappedPages;
@@ -1869 +1892 @@
             Log(("nemR3NativeRunGC: Unmapped all; cMappedPages=%u -> %u\n", cMappedPages, pVM->nem.s.cMappedPages));
         }
-#endif
+# endif
 
         /* If any FF is pending, return to the EM loops.  That's okay for the
@@ -1884 +1907 @@
 }
 
+#endif /* !NEM_WIN_USE_OUR_OWN_RUN_API */
+
 
 VBOXSTRICTRC nemR3NativeRunGC(PVM pVM, PVMCPU pVCpu)
 {
-#if 1
+#ifndef NEM_WIN_USE_OUR_OWN_RUN_API
     return nemR3WinWHvRunGC(pVM, pVCpu);
 #elif 1