Changeset 71719 in vbox

Timestamp:

Apr 6, 2018 6:48:26 PM (7 years ago)

Author:

vboxsync

Message:

RpcChannelHook.cpp: @todo wrt reliablity.

File:

• trunk/src/VBox/Main/src-all/win/RpcChannelHook.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/win/RpcChannelHook.cpp

@@ -76 +76 @@
  * @todo Consider using RTONCE to serialize this (though it's likely unncessary
  *       due to COM).
+ *
+ * @todo r=bird: Failure here must be fatal to VBoxProxyStub loading, or we can
+ *               kiss the reliablity of VBoxSVC good bye!
  */
 void SetupClientRpcChannelHook(void)
 {
     // register single hook only
+    /** @todo r=bird: This is called from DllMain/AttachProcess, so it should
+     *        only happen once.  OTOH, do we need to do anything on detach? */
     if (!CRpcChannelHook::IsChannelHookRegistered())
     {
@@ -170 +175 @@
             RTPROCESS pid = RTProcSelf();
             hrc = ptrClientList->RegisterClient(pid);
-            LogFunc(("Called VBoxSDS RegisterClient() : hr=%Rhrf\n", hrc));
+            if (SUCCEEDED(hrc))
+                LogFunc(("Called VBoxSDS RegisterClient() : hr=%Rhrf\n", hrc));
+            else
+                LogRel(("ERROR! Call to VBoxSDS::RegisterClient failed: hr=%Rhrf\n", hrc));
         }
         else
         {
-            LogFunc(("Error to connect to VBoxSDS: hr=%Rhrf\n", hrc));
+            LogRel(("ERROR! Failed to connect to VBoxSDS: hr=%Rhrf\n", hrc));
         }
+        /** @todo r=bird: Failure of any of above calls shall result in
+         * failure to get IVirtualBox!  Because the alternative is that VBoxSVC
+         * will quit early on us and potentally mess up the VM.  Much better
+         * to fail before its even started. */
     }
 }