Changeset 71733 in vbox

Timestamp:

Apr 7, 2018 2:35:47 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

121835

Message:

HDAStreamPeriod.cpp: No point in hdaStreamPeriodCreate returning VINF_SUCCESS even when RTCritSectInit fails (if that is intentional, please change it to a void function). The HDASTREAMPERIOD::Dbg.tsStartNs member is used in log statements but was incorrectly guarded by DEBUG rather than LOG_ENABLED (this would create build problems if enabling logging in say a release build).

Location:

trunk/src/VBox/Devices/Audio

Files:

• HDAStream.h (modified) (1 diff)
• HDAStreamPeriod.cpp (modified) (7 diffs)
• HDAStreamPeriod.h (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/HDAStream.h

@@ -24 +24 @@
 #include "HDAStreamPeriod.h"
 
-/*********************************************************************************************************************************
-*   Prototypes                                                                                                                   *
-*********************************************************************************************************************************/
 
 typedef struct HDAMIXERSINK *PHDAMIXERSINK;

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.cpp

@@ -3 +3 @@
  * HDAStreamPeriod.cpp - Stream period functions for HD Audio.
  *
- * Utility functions for handling HDA audio stream periods.
- * Stream period handling is needed in order to keep track of a stream's timing
+ * Utility functions for handling HDA audio stream periods.  Stream period
+ * handling is needed in order to keep track of a stream's timing
  * and processed audio data.
  *
- * As the HDA device only has one bit clock (WALCLK) but audio streams can be processed
- * at certain points in time, these functions can be used to estimate and schedule the
- * wall clock (WALCLK) for all streams accordingly.
+ * As the HDA device only has one bit clock (WALCLK) but audio streams can be
+ * processed at certain points in time, these functions can be used to estimate
+ * and schedule the wall clock (WALCLK) for all streams accordingly.
  */
 
@@ -39 +39 @@
 #include "HDAStreamPeriod.h"
 
-#ifdef IN_RING3
+
+#ifdef IN_RING3 /* entire file currently */
+
 /**
  * Creates a stream period.
@@ -51 +53 @@
 
     int rc = RTCritSectInit(&pPeriod->CritSect);
-    if (RT_SUCCESS(rc))
-    {
-        pPeriod->fStatus = HDASTREAMPERIOD_FLAG_VALID;
-    }
+    AssertRCReturnStmt(rc, pPeriod->fStatus = 0, rc);
+    pPeriod->fStatus = HDASTREAMPERIOD_FLAG_VALID;
 
     return VINF_SUCCESS;
@@ -143 +143 @@
     pPeriod->framesTransferred = 0;
     pPeriod->cIntPending       = 0;
-#ifdef DEBUG
+# ifdef LOG_ENABLED
     pPeriod->Dbg.tsStartNs     = 0;
-#endif
+# endif
 }
 
@@ -164 +164 @@
     pPeriod->framesTransferred = 0;
     pPeriod->cIntPending       = 0;
-#ifdef DEBUG
+# ifdef LOG_ENABLED
     pPeriod->Dbg.tsStartNs     = RTTimeNanoTS();
-#endif
-
-    Log3Func(("[SD%RU8] Starting @ %RU64 (%RU64 long)\n",
-              pPeriod->u8SD, pPeriod->u64StartWalClk, pPeriod->u64DurationWalClk));
-
+# endif
+
+    Log3Func(("[SD%RU8] Starting @ %RU64 (%RU64 long)\n", pPeriod->u8SD, pPeriod->u64StartWalClk, pPeriod->u64DurationWalClk));
     return VINF_SUCCESS;
 }
@@ -257 +255 @@
 {
     /* Prevent division by zero. */
-    const uint32_t uHz = (pPeriod->u32Hz ? pPeriod->u32Hz : 1);
+    const uint32_t uHz = pPeriod->u32Hz ? pPeriod->u32Hz : 1;
 
     /* 24 MHz wall clock (WALCLK): 42ns resolution. */
@@ -272 +270 @@
 uint64_t hdaStreamPeriodGetAbsElapsedWalClk(PHDASTREAMPERIOD pPeriod)
 {
-    return   pPeriod->u64StartWalClk
-           + pPeriod->u64ElapsedWalClk
-           + pPeriod->i64DelayWalClk;
+    return pPeriod->u64StartWalClk
+         + pPeriod->u64ElapsedWalClk
+         + pPeriod->i64DelayWalClk;
 }
 

trunk/src/VBox/Devices/Audio/HDAStreamPeriod.h

@@ -23 +23 @@
 # include <iprt/time.h>
 #endif
+#include <VBox/log.h> /* LOG_ENABLED */
 
 struct HDASTREAM;
 typedef HDASTREAM *PHDASTREAM;
 
-#ifdef DEBUG
+#ifdef LOG_ENABLED
 /**
  * Structure for debug information of an HDA stream's period.
@@ -76 +77 @@
     uint8_t                 cIntPending;
     uint8_t                 Padding3[7];
-#ifdef DEBUG
+#ifdef LOG_ENABLED
     /** Debugging information. */
     HDASTREAMPERIODDBGINFO  Dbg;