Changeset 71738 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Apr 7, 2018 9:44:18 PM (7 years ago)

Author:

vboxsync

Message:

DevAC97: AC97SOUNDSOURCE_LAST_INDEX -> AC97SOUNDSOURCE_END_INDEX, as we use 'last' to be inclusive in an enumeration and 'end' to be +1.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -188 +188 @@
 typedef enum
 {
-    AC97_CODEC_STAC9700 = 0,     /* SigmaTel STAC9700 */
-    AC97_CODEC_AD1980,           /* Analog Devices AD1980 */
-    AC97_CODEC_AD1981B           /* Analog Devices AD1981B */
+    AC97_CODEC_STAC9700 = 0,     /**< SigmaTel STAC9700 */
+    AC97_CODEC_AD1980,           /**< Analog Devices AD1980 */
+    AC97_CODEC_AD1981B           /**< Analog Devices AD1981B */
 } AC97CODEC;
 
 /* Analog Devices miscellaneous regiter bits used in AD1980. */
-#define AC97_AD_MISC_LOSEL       RT_BIT(5)   /* Surround (rear) goes to line out outputs. */
-#define AC97_AD_MISC_HPSEL       RT_BIT(10)  /* PCM (front) goes to headphone outputs. */
+#define AC97_AD_MISC_LOSEL       RT_BIT(5)   /**< Surround (rear) goes to line out outputs. */
+#define AC97_AD_MISC_HPSEL       RT_BIT(10)  /**< PCM (front) goes to headphone outputs. */
 
 #define ICHAC97STATE_2_DEVINS(a_pAC97)   ((a_pAC97)->pDevInsR3)
@@ -220 +220 @@
 typedef enum
 {
-    AC97SOUNDSOURCE_PI_INDEX = 0, /** PCM in */
-    AC97SOUNDSOURCE_PO_INDEX,     /** PCM out */
-    AC97SOUNDSOURCE_MC_INDEX,     /** Mic in */
-    AC97SOUNDSOURCE_LAST_INDEX
+    AC97SOUNDSOURCE_PI_INDEX = 0, /**< PCM in */
+    AC97SOUNDSOURCE_PO_INDEX,     /**< PCM out */
+    AC97SOUNDSOURCE_MC_INDEX,     /**< Mic in */
+    AC97SOUNDSOURCE_END_INDEX
 } AC97SOUNDSOURCE;
 
@@ -3220 +3220 @@
     SSMR3PutMem(pSSM, pThis->mixer_data, sizeof(pThis->mixer_data));
 
-    uint8_t active[AC97SOUNDSOURCE_LAST_INDEX];
+    uint8_t active[AC97SOUNDSOURCE_END_INDEX];
 
     active[AC97SOUNDSOURCE_PI_INDEX] = ichac97StreamIsEnabled(pThis, &pThis->StreamLineIn) ? 1 : 0;
@@ -3287 +3287 @@
 
     /** @todo r=andy Stream IDs are hardcoded to certain streams. */
-    uint8_t uaStrmsActive[AC97SOUNDSOURCE_LAST_INDEX];
+    uint8_t uaStrmsActive[AC97SOUNDSOURCE_END_INDEX];
     SSMR3GetMem(pSSM, uaStrmsActive, sizeof(uaStrmsActive));