Changeset 71743 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Apr 7, 2018 10:25:47 PM (7 years ago)

Author:

vboxsync

Message:

DevSB16.cpp,DevHDA.cpp: Just put markers on the PDMDEV_CHECK_VERSIONS_RETURN macro invoations so nobody puts stuff before them again (see ac97).

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -4713 +4713 @@
 static DECLCALLBACK(int) hdaR3Destruct(PPDMDEVINS pDevIns)
 {
-    PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
+    PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns); /* this shall come first */
     PHDASTATE pThis = PDMINS_2_DATA(pDevIns, PHDASTATE);
     DEVHDA_LOCK(pThis); /** @todo r=bird: this will fail on early constructor failure. */
@@ -4753 +4753 @@
 static DECLCALLBACK(int) hdaR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
-    RT_NOREF(iInstance);
-    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
+    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns); /* this shall come first */
     PHDASTATE pThis = PDMINS_2_DATA(pDevIns, PHDASTATE);
-    Assert(iInstance == 0);
+    Assert(iInstance == 0); RT_NOREF(iInstance);
 
     /*