Changeset 71746 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Apr 8, 2018 2:31:11 PM (7 years ago)

Author:

vboxsync

Message:

DevSB16: Stop using the IO_WRITE_PROTO and IO_READ_PROTO macros.

File:

• trunk/src/VBox/Devices/Audio/DevSB16.cpp (modified) (12 diffs)

trunk/src/VBox/Devices/Audio/DevSB16.cpp

@@ -72 +72 @@
 #define SB16_SAVE_STATE_VERSION_VBOX_30 1
 
-#define IO_READ_PROTO(name)                                             \
-    DECLCALLBACK(int) name (PPDMDEVINS pDevIns, void *opaque,       \
-                            RTIOPORT nport, uint32_t *pu32, unsigned cb)
-
-#define IO_WRITE_PROTO(name)                                            \
-    DECLCALLBACK(int) name (PPDMDEVINS pDevIns, void *opaque,       \
-                            RTIOPORT nport, uint32_t val, unsigned cb)
-
 
 /*********************************************************************************************************************************
@@ -555 +547 @@
 }
 
+/**
+ * @callback_method_impl{PFNTMTIMERDEV}
+ */
 static DECLCALLBACK(void) sb16TimerIRQ(PPDMDEVINS pDevIns, PTMTIMER pTimer, void *pvThis)
 {
@@ -1338 +1333 @@
 }
 
-static IO_WRITE_PROTO(dsp_write)
+/**
+ * @callback_method_impl{PFNIOMIOPORTOUT}
+ */
+static DECLCALLBACK(int) dsp_write(PPDMDEVINS pDevIns, void *opaque, RTIOPORT nport, uint32_t val, unsigned cb)
 {
     RT_NOREF(pDevIns, cb);
@@ -1435 +1433 @@
 }
 
-static IO_READ_PROTO(dsp_read)
+
+/**
+ * @callback_method_impl{PFNIOMIOPORTIN}
+ */
+static DECLCALLBACK(int) dsp_read(PPDMDEVINS pDevIns, void *opaque, RTIOPORT nport, uint32_t *pu32, unsigned cb)
 {
     RT_NOREF(pDevIns, cb);
@@ -1720 +1722 @@
 }
 
-static IO_WRITE_PROTO(mixer_write)
+/**
+ * @callback_method_impl{PFNIOMIOPORTOUT}
+ */
+static DECLCALLBACK(int) mixer_write(PPDMDEVINS pDevIns, void *opaque, RTIOPORT nport, uint32_t val, unsigned cb)
 {
     RT_NOREF(pDevIns);
@@ -1749 +1754 @@
 }
 
-static IO_READ_PROTO(mixer_read)
+/**
+ * @callback_method_impl{PFNIOMIOPORTIN}
+ */
+static DECLCALLBACK(int) mixer_read(PPDMDEVINS pDevIns, void *opaque, RTIOPORT nport, uint32_t *pu32, unsigned cb)
 {
     RT_NOREF(pDevIns, cb);
@@ -1768 +1776 @@
 }
 
-static int sb16WriteAudio(PSB16STATE pThis, int nchan, uint32_t dma_pos,
-                          uint32_t dma_len, int len)
+/**
+ * Called by sb16DMARead.
+ */
+static int sb16WriteAudio(PSB16STATE pThis, int nchan, uint32_t dma_pos, uint32_t dma_len, int len)
 {
     uint8_t  tmpbuf[_4K]; /** @todo Have a buffer on the heap. */
@@ -1838 +1848 @@
 }
 
+/**
+ * @callback_method_impl{FNDMATRANSFERHANDLER,
+ *      Worker callback for both DMA channels.}
+ */
 static DECLCALLBACK(uint32_t) sb16DMARead(PPDMDEVINS pDevIns, void *opaque, unsigned nchan, uint32_t dma_pos, uint32_t dma_len)
 {
@@ -1926 +1940 @@
 
 #ifndef VBOX_WITH_AUDIO_SB16_CALLBACKS
+
 static void sb16TimerMaybeStart(PSB16STATE pThis)
 {
@@ -1980 +1995 @@
             continue;
 
-#ifdef VBOX_STRICT
+# ifdef VBOX_STRICT
         /*
          * Sanity. Make sure that all streams have the same configuration
@@ -2005 +2020 @@
             }
         }
-#endif
+# endif
         PPDMIAUDIOCONNECTOR pConn = pDrv->pConnector;
         if (!pConn)
@@ -2066 +2081 @@
     }
 }
+
 #endif /* !VBOX_WITH_AUDIO_SB16_CALLBACKS */