VirtualBox

Changeset 71809 in vbox for trunk/src/VBox/Devices


Ignore:
Timestamp:
Apr 10, 2018 11:49:53 AM (7 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
121912
Message:

PC/Dev*: nits

Location:
trunk/src/VBox/Devices/PC
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/Devices/PC/DevACPI.cpp

    r70181 r71809  
    4242# define DEBUG_ACPI
    4343#endif
    44 
    4544
    4645
    … …  
    35373536static DECLCALLBACK(int) acpiR3Destruct(PPDMDEVINS pDevIns)
    35383537{
     3538    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    35393539    ACPIState *pThis = PDMINS_2_DATA(pDevIns, ACPIState *);
    35403540    if (pThis->pu8CustBin)
    … …  
    35513551static DECLCALLBACK(int) acpiR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    35523552{
     3553    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    35533554    ACPIState *pThis = PDMINS_2_DATA(pDevIns, ACPIState *);
    3554     PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    35553555
    35563556    /*

  • trunk/src/VBox/Devices/PC/DevDMA.cpp

    r71218 r71809  
    10691069static DECLCALLBACK(int) dmaConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    10701070{
     1071    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    10711072    RT_NOREF(iInstance);
    10721073    DMAState *pThis = PDMINS_2_DATA(pDevIns, DMAState *);

  • trunk/src/VBox/Devices/PC/DevHPET.cpp

    r69500 r71809  
    13091309static DECLCALLBACK(int) hpetR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    13101310{
    1311     RT_NOREF(iInstance);
    13121311    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    1313     HPET   *pThis = PDMINS_2_DATA(pDevIns, HPET *);
     1312    HPET *pThis = PDMINS_2_DATA(pDevIns, HPET *);
    13141313
    13151314    /* Only one HPET device now, as we use fixed MMIO region. */
    1316     Assert(iInstance == 0);
     1315    Assert(iInstance == 0); RT_NOREF(iInstance);
    13171316
    13181317    /*

  • trunk/src/VBox/Devices/PC/DevIoApic.cpp

    r70875 r71809  
    11431143static DECLCALLBACK(int) ioapicR3Destruct(PPDMDEVINS pDevIns)
    11441144{
     1145    PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
    11451146    PIOAPIC pThis = PDMINS_2_DATA(pDevIns, PIOAPIC);
    11461147    LogFlow(("IOAPIC: ioapicR3Destruct: pThis=%p\n", pThis));
    1147     PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
    11481148
    11491149# ifndef IOAPIC_WITH_PDM_CRITSECT
    … …  
    11661166static DECLCALLBACK(int) ioapicR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    11671167{
    1168     RT_NOREF(iInstance);
     1168    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    11691169    PIOAPIC pThis = PDMINS_2_DATA(pDevIns, PIOAPIC);
    11701170    LogFlow(("IOAPIC: ioapicR3Construct: pThis=%p iInstance=%d\n", pThis, iInstance));
    1171     Assert(iInstance == 0);
     1171    Assert(iInstance == 0); RT_NOREF(iInstance);
    11721172
    11731173    /*

  • trunk/src/VBox/Devices/PC/DevPcArch.cpp

    r71114 r71809  
    249249static DECLCALLBACK(int)  pcarchConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    250250{
    251     RT_NOREF1(iInstance);
    252251    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    253252    PDEVPCARCH  pThis = PDMINS_2_DATA(pDevIns, PDEVPCARCH);
    254253    int         rc;
    255     Assert(iInstance == 0);
     254    Assert(iInstance == 0); RT_NOREF(iInstance);
    256255
    257256    /*

  • trunk/src/VBox/Devices/PC/DevPcBios.cpp

    r67585 r71809  
    10781078static DECLCALLBACK(int) pcbiosDestruct(PPDMDEVINS pDevIns)
    10791079{
     1080    PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
    10801081    PDEVPCBIOS  pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
    10811082    LogFlow(("pcbiosDestruct:\n"));
    1082     PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
    10831083
    10841084    /*
    … …  
    11801180static DECLCALLBACK(int)  pcbiosConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    11811181{
    1182     RT_NOREF1(iInstance);
     1182    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    11831183    PDEVPCBIOS  pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
    11841184    int         rc;
    11851185    int         cb;
    1186 
    1187     Assert(iInstance == 0);
    1188     PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
     1186    Assert(iInstance == 0); RT_NOREF(iInstance);
    11891187
    11901188    /*

  • trunk/src/VBox/Devices/PC/DevPit-i8254.cpp

    r69500 r71809  
    13051305static DECLCALLBACK(int)  pitConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    13061306{
     1307    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    13071308    PPITSTATE   pThis = PDMINS_2_DATA(pDevIns, PPITSTATE);
    13081309    int         rc;

  • trunk/src/VBox/Devices/PC/DevRTC.cpp

    r69500 r71809  
    10751075static DECLCALLBACK(int)  rtcConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    10761076{
    1077     RT_NOREF1(iInstance);
    10781077    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    10791078    PRTCSTATE   pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
    10801079    int         rc;
    1081     Assert(iInstance == 0);
     1080    Assert(iInstance == 0); RT_NOREF(iInstance);
    10821081
    10831082    /*
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette