Changeset 71925 in vbox for trunk

Timestamp:

Apr 19, 2018 9:43:40 PM (7 years ago)

Author:

vboxsync

Message:

iom.h: Fixed buggy IOMMMIO_DOES_WRITE_MODE_ALLOW_QWORD macro (only affected NVMe I think).

File:

• trunk/include/VBox/vmm/iom.h (modified) (1 diff)

trunk/include/VBox/vmm/iom.h

@@ -160 +160 @@
  * thru to the device handler.
  * @param   a_fFlags        The MMIO handler flags.
- * @remarks The current implementation makes ASSUMPTIONS about the mode values!
- */
-#define IOMMMIO_DOES_WRITE_MODE_ALLOW_QWORD(a_fFlags)   RT_BOOL((a_fFlags) & UINT32_C(0x00000020))
+ */
+#define IOMMMIO_DOES_WRITE_MODE_ALLOW_QWORD(a_fFlags) \
+    (   ((a_fFlags) & IOMMMIO_FLAGS_WRITE_MODE) == IOMMMIO_FLAGS_WRITE_DWORD_QWORD_ZEROED \
+     || ((a_fFlags) & IOMMMIO_FLAGS_WRITE_MODE) == IOMMMIO_FLAGS_WRITE_DWORD_QWORD_READ_MISSING \
+     || ((a_fFlags) & IOMMMIO_FLAGS_WRITE_MODE) == IOMMMIO_FLAGS_WRITE_ONLY_DWORD_QWORD )