Changeset 71963 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

Apr 22, 2018 1:12:48 PM (7 years ago)

Author:

vboxsync

Message:

ValidationKit: Make pylint happy

Location:

trunk/src/VBox/ValidationKit

Files:

• common/utils.py (modified) (1 diff)
• tests/api/tdMoveMedium1.py (modified) (1 diff)
• tests/api/tdMoveVM1.py (modified) (6 diffs)

trunk/src/VBox/ValidationKit/common/utils.py

@@ -328 +328 @@
                     if offComma < 0:
                         return open(sFile, sMode + 'N');
-                    return open(sFile, sMode[:offComma] + 'N' + sMode[offComma:]);
+                    return open(sFile, sMode[:offComma] + 'N' + sMode[offComma:]); # pylint: disable=bad-open-mode
 
             # Just in case.

trunk/src/VBox/ValidationKit/tests/api/tdMoveMedium1.py

@@ -119 +119 @@
                     continue
                 (asExts, aTypes) = oDskFmt.describeFileExtensions()
-                for i in range(0, len(asExts)):
+                for i in range(0, len(asExts)): #pylint: disable=consider-using-enumerate
                     if aTypes[i] is vboxcon.DeviceType_HardDisk:
                         sExt = '.' + asExts[i]

trunk/src/VBox/ValidationKit/tests/api/tdMoveVM1.py

@@ -97 +97 @@
                 continue
             (asExts, aTypes) = oDskFmt.describeFileExtensions()
-            for i in range(0, len(asExts)):
+            for i in range(0, len(asExts)): #pylint: disable=consider-using-enumerate
                 if aTypes[i] is vboxcon.DeviceType_HardDisk:
                     sExt = '.' + asExts[i]
@@ -180 +180 @@
             if key == 'StandardImage' or key == 'ISOImage' or key == 'FloppyImage':
                 aReferences = dsReferenceFiles[key]
-                if len (aReferences) > 0:
+                if aReferences:
                     aoMediumAttachments = oMachine.getMediumAttachmentsOfController(value)
                     for oAttachment in aoMediumAttachments:
@@ -187 +187 @@
             elif key == 'SnapshotFile':
                 aReferences = dsReferenceFiles[key]
-                if len (aReferences) > 0:
+                if aReferences:
                     aActuals = self.__getSnapshotsFiles(oMachine)
 
@@ -193 +193 @@
             elif key == 'SettingsFile':
                 aReferences = dsReferenceFiles[key]
-                if len (aReferences) > 0:
+                if aReferences:
                     aActuals.add(oMachine.settingsFilePath)
 
@@ -199 +199 @@
             elif key == 'SavedStateFile':
                 aReferences = dsReferenceFiles[key]
-                if len (aReferences) > 0:
+                if aReferences:
                     aActuals = self.__getStatesFiles(oMachine)
 
@@ -205 +205 @@
             elif key == 'LogFile':
                 aReferences = dsReferenceFiles[key]
-                if len (aReferences) > 0:
+                if aReferences:
                     aActuals = self.__getLogFiles(oMachine)
 
-            if len(aActuals) > 0:
+            if aActuals:
                 reporter.log('Check %s' % (key))
                 intersection = aReferences.intersection(aActuals)