Changeset 71995 in vbox for trunk/src

Timestamp:

Apr 24, 2018 7:44:43 AM (7 years ago)

Author:

vboxsync

Message:

bugref:8345. Call WaitForAsyncProgressCompletion only in success.

File:

• trunk/src/VBox/Main/src-server/MachineImplMoveVM.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImplMoveVM.cpp

@@ -1089 +1089 @@
             ComPtr<IProgress> moveDiskProgress;
             rc = pMedium->SetLocation(bstrLocation.raw(), moveDiskProgress.asOutParam());
-            /* Wait until the async process has finished. */
-            rc = m_pProgress->WaitForAsyncProgressCompletion(moveDiskProgress);
+            if (SUCCEEDED(rc))
+            {
+                /* In case of failure moveDiskProgress would be in the invalid state or not initialized at all
+                 * Call WaitForAsyncProgressCompletion only in success
+                 */
+                /* Wait until the async process has finished. */
+                rc = m_pProgress->WaitForAsyncProgressCompletion(moveDiskProgress);
+            }
 
             /*acquire the lock back*/