Changeset 72031 in vbox

Timestamp:

Apr 26, 2018 8:36:11 AM (7 years ago)

Author:

vboxsync

Message:

ValidationKit/tests/serial: Add verbose flag to avoid flooding the log with error messages by default

File:

• trunk/src/VBox/ValidationKit/utils/serial/SerialTest.cpp (modified) (5 diffs)

trunk/src/VBox/ValidationKit/utils/serial/SerialTest.cpp

@@ -325 +325 @@
  * Verifies the data in the given RX buffer for correct transmission.
  *
- * @returns nothing.
+ * @returns Flag whether verification failed.
  * @param   hTest               The test handle to report errors to.
  * @param   pSerBuf             The RX buffer pointer.
  * @param   iCntTx              The current TX counter value the RX buffer should never get ahead of.
  */
-static void serialTestRxBufVerify(RTTEST hTest, PSERIALTESTTXRXBUFCNT pSerBuf, uint32_t iCntTx)
+static bool serialTestRxBufVerify(RTTEST hTest, PSERIALTESTTXRXBUFCNT pSerBuf, uint32_t iCntTx)
 {
     uint32_t offRx = 0;
@@ -349 +349 @@
     }
 
-    if (fFailed)
-        RTTestFailed(hTest, "Data corruption/loss detected\n");
-
     if (RT_UNLIKELY(pSerBuf->iCnt > iCntTx))
+    {
+        fFailed = true;
         RTTestFailed(hTest, "Overtook the send buffer, expected maximum counter value %u got %u\n",
                      iCntTx, pSerBuf->iCnt);
+    }
 
     /* Remove processed data from the buffer and move the rest to the front. */
@@ -363 +363 @@
         pSerBuf->cbTxRxMax += offRx;
     }
+
+    return fFailed;
 }
 
@@ -380 +382 @@
 {
     uint64_t tsStart = RTTimeMilliTS();
+    bool fFailed = false;
     SERIALTESTTXRXBUFCNT SerBufTx;
     SERIALTESTTXRXBUFCNT SerBufRx;
@@ -408 +411 @@
                 break;
 
-            serialTestRxBufVerify(pSerialTest->hTest, &SerBufRx, SerBufTx.iCnt);
+            bool fRes = serialTestRxBufVerify(pSerialTest->hTest, &SerBufRx, SerBufTx.iCnt);
+            if (fRes && !fFailed)
+            {
+                fFailed = true;
+                RTTestFailed(pSerialTest->hTest, "Data corruption/loss detected\n");
+            }
         }
         if (   RT_SUCCESS(rc)