Changeset 72054 in vbox for trunk/src/VBox

Timestamp:

Apr 27, 2018 9:18:51 AM (7 years ago)

Author:

vboxsync

Message:

*: RTListMove no longer need the call to init the destination list to workaround buggy behavior when when the source is empty.

Location:

trunk/src/VBox

Files:

• Devices/USB/usbip/USBProxyDevice-usbip.cpp (modified) (1 diff)
• Devices/VMMDev/VMMDevHGCM.cpp (modified) (1 diff)
• Runtime/testcase/tstRTList.cpp (modified) (1 diff)
• Storage/VD.cpp (modified) (1 diff)
• VMM/VMMR3/PDMBlkCache.cpp (modified) (1 diff)

trunk/src/VBox/Devices/USB/usbip/USBProxyDevice-usbip.cpp

@@ -1263 +1263 @@
     RTLISTANCHOR ListUrbsPending;
 
-    RTListInit(&ListUrbsPending);
     int rc = RTSemFastMutexRequest(pProxyDevUsbIp->hMtxLists);
     AssertRC(rc);

trunk/src/VBox/Devices/VMMDev/VMMDevHGCM.cpp

@@ -1822 +1822 @@
     /* Get local copy of the list of loaded commands. */
     RTLISTANCHOR listLoadedCommands;
-    RTListInit(&listLoadedCommands); /* RTListMove does not touch the destination is the source list is empty. */
     RTListMove(&listLoadedCommands, &pThis->listHGCMCmd);
 

trunk/src/VBox/Runtime/testcase/tstRTList.cpp

@@ -131 +131 @@
     /* Move the list to a new one. */
     RTLISTANCHOR ListHeadNew;
-
-    RTListInit(&ListHeadNew);
     RTListMove(&ListHeadNew, &ListHead);
 

trunk/src/VBox/Storage/VD.cpp

@@ -3509 +3509 @@
     PVDISK pDisk = pIoStorage->pVDIo->pDisk;
     RTLISTANCHOR ListIoCtxWaiting;
-    RTListInit(&ListIoCtxWaiting);
     bool fFlush;
 

trunk/src/VBox/VMM/VMMR3/PDMBlkCache.cpp

@@ -697 +697 @@
     RTLISTANCHOR ListDirtyNotCommitted;
 
-    RTListInit(&ListDirtyNotCommitted);
     RTSpinlockAcquire(pBlkCache->LockList);
     RTListMove(&ListDirtyNotCommitted, &pBlkCache->ListDirtyNotCommitted);