Changeset 7207 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Feb 28, 2008 6:43:08 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

28520

Message:

Main: Reworked enums to avoid 1) weird duplication of enum name when referring to enum values in cross-platform code; 2) possible clashes on Win32 due to putting identifiers like Paused or Disabled to the global namespace (via C enums). In the new style, enums are used like this: a) USBDeviceState_T v = USBDeviceState_Busy from cross-platform non-Qt code; b) KUSBDeviceState v = KUSBDeviceState_Busy from Qt code; c) USBDeviceState v = USBDeviceState_Busy from plain Win32 and d) PRUInt32 USBDeviceState v = USBDeviceState::Busy from plain XPCOM.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp (modified) (58 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp

@@ -178 +178 @@
     {
         USBFilter ()
-            : mAction (USBDeviceFilterAction_InvalidUSBDeviceFilterAction)
+            : mAction (USBDeviceFilterAction_Null)
             {}
 
@@ -913 +913 @@
         RTPrintf("Time offset:     %lld ms\n", timeOffset);
 
-    TriStateBool_T hwVirtExEnabled;
+    TSBool_T hwVirtExEnabled;
     machine->COMGETTER(HWVirtExEnabled)(&hwVirtExEnabled);
-    if (hwVirtExEnabled == TriStateBool_TSDefault)
+    if (hwVirtExEnabled == TSBool_Default)
     {
         BOOL fHWVirtExEnabled;
@@ -929 +929 @@
     {
         if (details == VMINFO_MACHINEREADABLE)
-            RTPrintf("hwvirtex=\"%s\"\n", hwVirtExEnabled == TriStateBool_TSTrue ? "on" : "off");
+            RTPrintf("hwvirtex=\"%s\"\n", hwVirtExEnabled == TSBool_True ? "on" : "off");
         else
-            RTPrintf("Hardw. virt.ext: %s\n", hwVirtExEnabled == TriStateBool_TSTrue ? "on" : "off");
+            RTPrintf("Hardw. virt.ext: %s\n", hwVirtExEnabled == TSBool_True ? "on" : "off");
     }
 
@@ -1063 +1063 @@
     ComPtr<IHardDisk> hardDisk;
     Bstr filePath;
-    rc = machine->GetHardDisk(DiskControllerType_IDE0Controller, 0, hardDisk.asOutParam());
+    rc = machine->GetHardDisk(DiskControllerType_IDE0, 0, hardDisk.asOutParam());
     if (SUCCEEDED(rc) && hardDisk)
     {
@@ -1086 +1086 @@
             RTPrintf("hda=\"none\"\n");
     }
-    rc = machine->GetHardDisk(DiskControllerType_IDE0Controller, 1, hardDisk.asOutParam());
+    rc = machine->GetHardDisk(DiskControllerType_IDE0, 1, hardDisk.asOutParam());
     if (SUCCEEDED(rc) && hardDisk)
     {
@@ -1109 +1109 @@
             RTPrintf("hdb=\"none\"\n");
     }
-    rc = machine->GetHardDisk(DiskControllerType_IDE1Controller, 1, hardDisk.asOutParam());
+    rc = machine->GetHardDisk(DiskControllerType_IDE1, 1, hardDisk.asOutParam());
     if (SUCCEEDED(rc) && hardDisk)
     {
@@ -1217 +1217 @@
                 switch (attachment)
                 {
-                    case NetworkAttachmentType_NoNetworkAttachment:
+                    case NetworkAttachmentType_Null:
                         if (details == VMINFO_MACHINEREADABLE)
                             strAttachment = "null";
@@ -1223 +1223 @@
                             strAttachment = "none";
                         break;
-                    case NetworkAttachmentType_NATNetworkAttachment:
+                    case NetworkAttachmentType_NAT:
                         if (details == VMINFO_MACHINEREADABLE)
                             strAttachment = "nat";
@@ -1229 +1229 @@
                             strAttachment = "NAT";
                         break;
-                    case NetworkAttachmentType_HostInterfaceNetworkAttachment:
+                    case NetworkAttachmentType_HostInterface:
                     {
                         Bstr strHostIfDev;
@@ -1242 +1242 @@
                         break;
                     }
-                    case NetworkAttachmentType_InternalNetworkAttachment:
+                    case NetworkAttachmentType_Internal:
                     {
                         Bstr strNetwork;
@@ -1275 +1275 @@
                 nic->COMGETTER(AdapterType)(&NICType);
                 switch (NICType) {
-                case NetworkAdapterType_NetworkAdapterAm79C970A:
+                case NetworkAdapterType_Am79C970A:
                     strNICType = "Am79C970A";
                     break;
-                case NetworkAdapterType_NetworkAdapterAm79C973:
+                case NetworkAdapterType_Am79C973:
                     strNICType = "Am79C973";
                     break;
 #ifdef VBOX_WITH_E1000
-                case NetworkAdapterType_NetworkAdapter82540EM:
+                case NetworkAdapterType_I82540EM:
                     strNICType = "82540EM";
                     break;
@@ -1351 +1351 @@
                 {
                     default:
-                    case PortMode_DisconnectedPort:
+                    case PortMode_Disconnected:
                         if (details == VMINFO_MACHINEREADABLE)
                             RTPrintf("uartmode%d=\"disconnected\"\n", currentUART + 1);
@@ -1357 +1357 @@
                             RTPrintf(", disconnected\n");
                         break;
-                    case PortMode_HostPipePort:
+                    case PortMode_HostPipe:
                         if (details == VMINFO_MACHINEREADABLE)
                             RTPrintf("uartmode%d=\"%s,%lS\"\n", currentUART + 1,
@@ -1365 +1365 @@
                                      fServer ? "server" : "client", path.raw());
                         break;
-                    case PortMode_HostDevicePort:
+                    case PortMode_HostDevice:
                         if (details == VMINFO_MACHINEREADABLE)
                             RTPrintf("uartmode%d=\"%lS\"\n", currentUART + 1,
@@ -1391 +1391 @@
             switch (enmDrvType)
             {
-                case AudioDriverType_NullAudioDriver:
+                case AudioDriverType_Null:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "null";
@@ -1397 +1397 @@
                         pszDrv = "Null";
                     break;
-                case AudioDriverType_WINMMAudioDriver:
+                case AudioDriverType_WINMM:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "winmm";
@@ -1403 +1403 @@
                         pszDrv = "WINMM";
                     break;
-                case AudioDriverType_DSOUNDAudioDriver:
+                case AudioDriverType_DSOUND:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "dsound";
@@ -1409 +1409 @@
                         pszDrv = "DSOUND";
                     break;
-                case AudioDriverType_OSSAudioDriver:
+                case AudioDriverType_OSS:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "oss";
@@ -1415 +1415 @@
                         pszDrv = "OSS";
                     break;
-                case AudioDriverType_ALSAAudioDriver:
+                case AudioDriverType_ALSA:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "alsa";
@@ -1421 +1421 @@
                         pszDrv = "ALSA";
                     break;
-                case AudioDriverType_PulseAudioDriver:
+                case AudioDriverType_Pulse:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "pulse";
@@ -1427 +1427 @@
                         pszDrv = "PulseAudio";
                     break;
-                case AudioDriverType_CoreAudioDriver:
+                case AudioDriverType_Core:
                     if (details == VMINFO_MACHINEREADABLE)
                         pszDrv = "coreaudio";
@@ -1477 +1477 @@
         switch (enmMode)
         {
-            case ClipboardMode_ClipDisabled:
+            case ClipboardMode_Disabled:
                 if (details == VMINFO_MACHINEREADABLE)
                     psz = "disabled";
@@ -1483 +1483 @@
                     psz = "disabled";
                 break;
-            case ClipboardMode_ClipHostToGuest:
+            case ClipboardMode_HostToGuest:
                 if (details == VMINFO_MACHINEREADABLE)
                     psz = "hosttoguest";
@@ -1489 +1489 @@
                     psz = "HostToGuest";
                 break;
-            case ClipboardMode_ClipGuestToHost:
+            case ClipboardMode_GuestToHost:
                 if (details == VMINFO_MACHINEREADABLE)
                     psz = "guesttohost";
@@ -1495 +1495 @@
                     psz = "GuestToHost";
                 break;
-            case ClipboardMode_ClipBidirectional:
+            case ClipboardMode_Bidirectional:
                 if (details == VMINFO_MACHINEREADABLE)
                     psz = "bidirectional";
@@ -1548 +1548 @@
             switch (vrdpAuthType)
             {
-                case VRDPAuthType_VRDPAuthNull:
+                case VRDPAuthType_Null:
                     strAuthType = "null";
                     break;
-                case VRDPAuthType_VRDPAuthExternal:
+                case VRDPAuthType_External:
                     strAuthType = "external";
                     break;
-                case VRDPAuthType_VRDPAuthGuest:
+                case VRDPAuthType_Guest:
                     strAuthType = "guest";
                     break;
@@ -2685 +2685 @@
             RTPrintf("Accessible: %s\n", fAccessible ? "yes" : "no");
             Bstr machineUUIDs;
-            CHECK_ERROR(virtualBox, GetDVDImageUsage(uuid, ResourceUsage_AllUsage, machineUUIDs.asOutParam()));
+            CHECK_ERROR(virtualBox, GetDVDImageUsage(uuid, ResourceUsage_All, machineUUIDs.asOutParam()));
             /** @todo usage */
             RTPrintf("\n");
@@ -2712 +2712 @@
             RTPrintf("Accessible: %s\n", fAccessible ? "yes" : "no");
             Bstr machineUUIDs;
-            CHECK_ERROR(virtualBox, GetFloppyImageUsage(uuid, ResourceUsage_AllUsage, machineUUIDs.asOutParam()));
+            CHECK_ERROR(virtualBox, GetFloppyImageUsage(uuid, ResourceUsage_All, machineUUIDs.asOutParam()));
             /** @todo usage */
             RTPrintf("\n");
@@ -2786 +2786 @@
             switch (state)
             {
-                case USBDeviceState_USBDeviceNotSupported:
+                case USBDeviceState_NotSupported:
                     pszState = "Not supported"; break;
-                case USBDeviceState_USBDeviceUnavailable:
+                case USBDeviceState_Unavailable:
                     pszState = "Unavailable"; break;
-                case USBDeviceState_USBDeviceBusy:
+                case USBDeviceState_Busy:
                     pszState = "Busy"; break;
-                case USBDeviceState_USBDeviceAvailable:
+                case USBDeviceState_Available:
                     pszState = "Available"; break;
-                case USBDeviceState_USBDeviceHeld:
+                case USBDeviceState_Held:
                     pszState = "Held"; break;
-                case USBDeviceState_USBDeviceCaptured:
+                case USBDeviceState_Captured:
                     pszState = "Captured"; break;
                 default:
@@ -2851 +2851 @@
             switch (action)
             {
-                case USBDeviceFilterAction_USBDeviceFilterIgnore:
+                case USBDeviceFilterAction_Ignore:
                     pszAction = "Ignore";
                     break;
-                case USBDeviceFilterAction_USBDeviceFilterHold:
+                case USBDeviceFilterAction_Hold:
                     pszAction = "Hold";
                     break;
@@ -3100 +3100 @@
                     else if (strcmp(type, "writethrough") == 0)
                     {
-                        CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_WritethroughHardDisk));
+                        CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Writethrough));
                     }
 
@@ -3182 +3182 @@
             if (strcmp(type, "normal") == 0)
             {
-                if (hddType != HardDiskType_NormalHardDisk)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_NormalHardDisk));
+                if (hddType != HardDiskType_Normal)
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Normal));
             }
             else if (strcmp(type, "writethrough") == 0)
             {
-                if (hddType != HardDiskType_WritethroughHardDisk)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_WritethroughHardDisk));
+                if (hddType != HardDiskType_Writethrough)
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Writethrough));
 
             }
             else if (strcmp(type, "immutable") == 0)
             {
-                if (hddType != HardDiskType_ImmutableHardDisk)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_ImmutableHardDisk));
+                if (hddType != HardDiskType_Immutable)
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Immutable));
             }
             else
@@ -3895 +3895 @@
             if (strcmp(argv[i], "none") == 0)
             {
-                bootDevice[n - 1] = DeviceType_NoDevice;
+                bootDevice[n - 1] = DeviceType_Null;
             }
             else if (strcmp(argv[i], "floppy") == 0)
             {
-                bootDevice[n - 1] = DeviceType_FloppyDevice;
+                bootDevice[n - 1] = DeviceType_Floppy;
             }
             else if (strcmp(argv[i], "dvd") == 0)
             {
-                bootDevice[n - 1] = DeviceType_DVDDevice;
+                bootDevice[n - 1] = DeviceType_DVD;
             }
             else if (strcmp(argv[i], "disk") == 0)
             {
-                bootDevice[n - 1] = DeviceType_HardDiskDevice;
+                bootDevice[n - 1] = DeviceType_HardDisk;
             }
             else if (strcmp(argv[i], "net") == 0)
             {
-                bootDevice[n - 1] = DeviceType_NetworkDevice;
+                bootDevice[n - 1] = DeviceType_Network;
             }
             else
@@ -4403 +4403 @@
             if (strcmp(hwvirtex, "on") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TriStateBool_TSTrue));
+                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TSBool_True));
             }
             else if (strcmp(hwvirtex, "off") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TriStateBool_TSFalse));
+                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TSBool_False));
             }
             else if (strcmp(hwvirtex, "default") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TriStateBool_TSDefault));
+                CHECK_ERROR(machine, COMSETTER(HWVirtExEnabled)(TSBool_Default));
             }
             else
@@ -4513 +4513 @@
             if (strcmp(hdds[0], "none") == 0)
             {
-                machine->DetachHardDisk(DiskControllerType_IDE0Controller, 0);
+                machine->DetachHardDisk(DiskControllerType_IDE0, 0);
             }
             else
@@ -4546 +4546 @@
                 {
                     hardDisk->COMGETTER(Id)(uuid.asOutParam());
-                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE0Controller, 0));
+                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE0, 0));
                 }
                 else
@@ -4558 +4558 @@
             if (strcmp(hdds[1], "none") == 0)
             {
-                machine->DetachHardDisk(DiskControllerType_IDE0Controller, 1);
+                machine->DetachHardDisk(DiskControllerType_IDE0, 1);
             }
             else
@@ -4591 +4591 @@
                 {
                     hardDisk->COMGETTER(Id)(uuid.asOutParam());
-                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE0Controller, 1));
+                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE0, 1));
                 }
                 else
@@ -4603 +4603 @@
             if (strcmp(hdds[2], "none") == 0)
             {
-                machine->DetachHardDisk(DiskControllerType_IDE1Controller, 1);
+                machine->DetachHardDisk(DiskControllerType_IDE1, 1);
             }
             else
@@ -4636 +4636 @@
                 {
                     hardDisk->COMGETTER(Id)(uuid.asOutParam());
-                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE1Controller, 1));
+                    CHECK_ERROR(machine, AttachHardDisk(uuid, DiskControllerType_IDE1, 1));
                 }
                 else
@@ -4809 +4809 @@
                 else if (strcmp(audio, "null") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_NullAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_Null));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4816 +4816 @@
                 else if (strcmp(audio, "winmm") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_WINMMAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_WINMM));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4822 +4822 @@
                 else if (strcmp(audio, "dsound") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_DSOUNDAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_DSOUND));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4829 +4829 @@
                 else if (strcmp(audio, "oss") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_OSSAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_OSS));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4835 +4835 @@
                 else if (strcmp(audio, "alsa") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_ALSAAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_ALSA));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4842 +4842 @@
                 else if (strcmp(audio, "pulse") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_PulseAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_Pulse));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4850 +4850 @@
                 else if (strcmp(audio, "coreaudio") == 0)
                 {
-                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_CoreAudioDriver));
+                    CHECK_ERROR(audioAdapter, COMSETTER(AudioDriver)(AudioDriverType_Core));
                     CHECK_ERROR(audioAdapter, COMSETTER(Enabled)(true));
                 }
@@ -4885 +4885 @@
             if (strcmp(clipboard, "disabled") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_ClipDisabled));
+                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_Disabled));
             }
             else if (strcmp(clipboard, "hosttoguest") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_ClipHostToGuest));
+                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_HostToGuest));
             }
             else if (strcmp(clipboard, "guesttohost") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_ClipGuestToHost));
+                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_GuestToHost));
             }
             else if (strcmp(clipboard, "bidirectional") == 0)
             {
-                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_ClipBidirectional));
+                CHECK_ERROR(machine, COMSETTER(ClipboardMode)(ClipboardMode_Bidirectional));
             }
             else
@@ -4954 +4954 @@
                 if (strcmp(nictype[n], "Am79C970A") == 0)
                 {
-                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_NetworkAdapterAm79C970A), 1);
+                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_Am79C970A), 1);
                 }
                 else if (strcmp(nictype[n], "Am79C973") == 0)
                 {
-                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_NetworkAdapterAm79C973), 1);
+                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_Am79C973), 1);
                 }
 #ifdef VBOX_WITH_E1000
                 else if (strcmp(nictype[n], "82540EM") == 0)
                 {
-                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_NetworkAdapter82540EM), 1);
+                    CHECK_ERROR_RET(nic, COMSETTER(AdapterType)(NetworkAdapterType_I82540EM), 1);
                 }
 #endif
@@ -5135 +5135 @@
                 if (strcmp(uarts_mode[n], "disconnected") == 0)
                 {
-                    CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_DisconnectedPort), 1);
+                    CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_Disconnected), 1);
                 }
                 else
@@ -5141 +5141 @@
                     if (strcmp(uarts_mode[n], "server") == 0)
                     {
-                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostPipePort), 1);
+                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostPipe), 1);
                         CHECK_ERROR_RET(uart, COMSETTER(Server) (TRUE), 1);
                     }
                     else if (strcmp(uarts_mode[n], "client") == 0)
                     {
-                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostPipePort), 1);
+                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostPipe), 1);
                         CHECK_ERROR_RET(uart, COMSETTER(Server) (FALSE), 1);
                     }
                     else
                     {
-                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostDevicePort), 1);
+                        CHECK_ERROR_RET(uart, COMSETTER(HostMode) (PortMode_HostDevice), 1);
                     }
                     CHECK_ERROR_RET(uart, COMSETTER(Path) (Bstr(uarts_path[n])), 1);
@@ -5197 +5197 @@
                     if (strcmp(vrdpauthtype, "null") == 0)
                     {
-                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_VRDPAuthNull));
+                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_Null));
                     }
                     else if (strcmp(vrdpauthtype, "external") == 0)
                     {
-                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_VRDPAuthExternal));
+                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_External));
                     }
                     else if (strcmp(vrdpauthtype, "guest") == 0)
                     {
-                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_VRDPAuthGuest));
+                        CHECK_ERROR(vrdpServer, COMSETTER(AuthType)(VRDPAuthType_Guest));
                     }
                     else
@@ -6201 +6201 @@
         switch (type)
         {
-            case HardDiskType_NormalHardDisk:
+            case HardDiskType_Normal:
                 typeStr = "standard";
                 break;
-            case HardDiskType_ImmutableHardDisk:
+            case HardDiskType_Immutable:
                 typeStr = "immutable";
                 break;
-            case HardDiskType_WritethroughHardDisk:
+            case HardDiskType_Writethrough:
                 typeStr = "writethrough";
                 break;
@@ -6300 +6300 @@
             {
                 if (strcmp(type, "normal") == 0)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_NormalHardDisk));
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Normal));
                 else if (strcmp(type, "immutable") == 0)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_ImmutableHardDisk));
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Immutable));
                 else if (strcmp(type, "writethrough") == 0)
-                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_WritethroughHardDisk));
+                    CHECK_ERROR(hardDisk, COMSETTER(Type)(HardDiskType_Writethrough));
             }
             if (SUCCEEDED(rc))
@@ -6878 +6878 @@
                     i++;
                     if (strcmp (argv [i], "ignore") == 0)
-                        cmd.mFilter.mAction = USBDeviceFilterAction_USBDeviceFilterIgnore;
+                        cmd.mFilter.mAction = USBDeviceFilterAction_Ignore;
                     else if (strcmp (argv [i], "hold") == 0)
-                        cmd.mFilter.mAction = USBDeviceFilterAction_USBDeviceFilterHold;
+                        cmd.mFilter.mAction = USBDeviceFilterAction_Hold;
                     else
                     {
@@ -6899 +6899 @@
                     ||
                        (   cmd.mGlobal
-                        && cmd.mFilter.mAction == USBDeviceFilterAction_InvalidUSBDeviceFilterAction
+                        && cmd.mFilter.mAction == USBDeviceFilterAction_Null
                        )
                     || (   !cmd.mGlobal
@@ -6999 +6999 @@
                     CHECK_ERROR_BREAK (flt, COMSETTER(MaskedInterfaces) (f.mMaskedInterfaces));
 
-                if (f.mAction != USBDeviceFilterAction_InvalidUSBDeviceFilterAction)
+                if (f.mAction != USBDeviceFilterAction_Null)
                     CHECK_ERROR_BREAK (flt, COMSETTER(Action) (f.mAction));
 
@@ -7056 +7056 @@
                     CHECK_ERROR_BREAK (flt, COMSETTER(MaskedInterfaces) (f.mMaskedInterfaces));
 
-                if (f.mAction != USBDeviceFilterAction_InvalidUSBDeviceFilterAction)
+                if (f.mAction != USBDeviceFilterAction_Null)
                     CHECK_ERROR_BREAK (flt, COMSETTER(Action) (f.mAction));
             }