Changeset 72098 in vbox for trunk/src/VBox/Additions/common

Timestamp:

May 3, 2018 4:20:44 PM (7 years ago)

Author:

vboxsync

Message:

Guest Control/VBoxService: Resolved a @todo in vgsvcGstCtrlSessionHandlePathRename() (now using a dedicated flag for the actual RTPathRename call).

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -575 +575 @@
         if (RT_SUCCESS(rc))
         {
-/** @todo r=bird: shouldn't you use a different variable here for the IPRT flags??? */
+            unsigned fPathRenameFlags = 0;
+
             if (fFlags & PATHRENAME_FLAG_NO_REPLACE)
-                fFlags |= RTPATHRENAME_FLAGS_NO_REPLACE;
+                fPathRenameFlags |= RTPATHRENAME_FLAGS_NO_REPLACE;
 
             if (fFlags & PATHRENAME_FLAG_REPLACE)
-                fFlags |= RTPATHRENAME_FLAGS_REPLACE;
+                fPathRenameFlags |= RTPATHRENAME_FLAGS_REPLACE;
 
             if (fFlags & PATHRENAME_FLAG_NO_SYMLINKS)
-                fFlags |= RTPATHRENAME_FLAGS_NO_SYMLINKS;
-
-            rc = RTPathRename(szSource, szDest, fFlags);
+                fPathRenameFlags |= RTPATHRENAME_FLAGS_NO_SYMLINKS;
+
+            rc = RTPathRename(szSource, szDest, fPathRenameFlags);
         }