Changeset 72140 in vbox for trunk/src/VBox/Runtime/generic

Timestamp:

May 7, 2018 2:21:31 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

122537

Message:

IPRT/time: misc fixes (incorrect offUTC conversion sign, forgotten storing of offUTC, incorrect month/day calculation for first day of month, avoiding assertions when leap year needs to be recalulated) for local time, make RTTimeImplode process local time correctly, plus an implementation of RTTimeLocalNormalize and RTTimeConvertToZulu. Much improved testcase exercising overflow handling in the local time case.

File:

• trunk/src/VBox/Runtime/generic/RTTimeLocalExplode-generic.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/generic/RTTimeLocalExplode-generic.cpp

@@ -35 +35 @@
 RTDECL(PRTTIME) RTTimeLocalExplode(PRTTIME pTime, PCRTTIMESPEC pTimeSpec)
 {
-    pTime = RTTimeExplode(pTime, pTimeSpec);
+    RTTIMESPEC LocalTime = *pTimeSpec;
+    int64_t LocalUTCOffset = RTTimeLocalDeltaNano(); /**< @todo this is obviously wrong. Need RTTimeLocalDeltaNanoFor(pTimeSpec); */
+    RTTimeSpecAddNano(&LocalTime, LocalUTCOffset);
+    pTime = RTTimeExplode(pTime, &LocalTime);
     if (pTime)
     {
         pTime->fFlags = (pTime->fFlags & ~RTTIME_FLAGS_TYPE_MASK) | RTTIME_FLAGS_TYPE_LOCAL;
-        pTime->offZone = RTTimeLocalDeltaNano() / (UINT64_C(1000000000)*3600); /** @todo this is obviously wrong. Need RTTimeLocalDeltaNanoFor(pTimeSpec); */
+        pTime->offUTC = LocalUTCOffset / RT_NS_1MIN;
     }
     return pTime;