Changeset 72173 in vbox for trunk/src

Timestamp:

May 9, 2018 1:38:13 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

122595

Message:

FE/Qt bugref:9072 Some small refactoring in logviewer filter panel.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/VBoxGlobal.cpp (modified) (2 diffs)
• logviewer/UIVMLogViewerFilterPanel.cpp (modified) (5 diffs)
• settings/machine/UIMachineSettingsGeneral.cpp (modified) (1 diff)
• widgets/UIApplianceEditorWidget.cpp (modified) (1 diff)
• widgets/UINameAndSystemEditor.cpp (modified) (7 diffs)
• widgets/UINameAndSystemEditor.h (modified) (5 diffs)
• widgets/UIVMNamePathSelector.cpp (modified) (7 diffs)
• widgets/UIVMNamePathSelector.h (modified) (4 diffs)
• wizards/importappliance/UIWizardImportAppPageBasic1.cpp (modified) (4 diffs)
• wizards/importappliance/UIWizardImportAppPageBasic1.h (modified) (3 diffs)
• wizards/newvm/UIWizardNewVMPageBasic1.cpp (modified) (4 diffs)
• wizards/newvm/UIWizardNewVMPageBasic1.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

@@ -1160 +1160 @@
     QString strHomeFolder = fUseLastFolder && !strLastFolder.isEmpty() ? strLastFolder :
                             strDefaultFolder.isEmpty() ? vboxGlobal().homeFolder() : strDefaultFolder;
+
 
     /* Prepare filters and backends: */
@@ -4676 +4677 @@
     return true;
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerFilterPanel.cpp

@@ -32 +32 @@
 # include <QPlainTextEdit>
 # include <QTextCursor>
-# include <QToolButton>
 # include <QRadioButton>
 # include <QScrollArea>
@@ -79 +78 @@
     virtual void        mousePressEvent(QMouseEvent * event) /* override */;
     virtual void        mouseReleaseEvent(QMouseEvent *){}
-    virtual void        paintEvent(QPaintEvent *event);
+    virtual void        paintEvent(QPaintEvent *event) /* override */;
 
 private slots:
@@ -90 +89 @@
 private:
 
-    void         createButtons();
-    QToolButton *m_pRemoveTermButton;
-    QToolButton *m_pClearAllButton;
-    const int    m_iRemoveTermButtonSize;
-    int          m_iTrailingSpaceCount;
+    void          createButtons();
+    QIToolButton *m_pRemoveTermButton;
+    QIToolButton *m_pClearAllButton;
+    const int     m_iRemoveTermButtonSize;
+    int           m_iTrailingSpaceCount;
 };
 
@@ -197 +196 @@
     if (!m_pRemoveTermButton)
     {
-        m_pRemoveTermButton = new QToolButton(this);
+        m_pRemoveTermButton = new QIToolButton(this);
         if (m_pRemoveTermButton)
         {
             m_pRemoveTermButton->setIcon(m_pRemoveTermButton->style()->standardIcon(QStyle::SP_TitleBarCloseButton));
             m_pRemoveTermButton->hide();
-            connect(m_pRemoveTermButton, &QToolButton::clicked, this, &UIVMFilterLineEdit::sltRemoveFilterTerm);
+            connect(m_pRemoveTermButton, &QIToolButton::clicked, this, &UIVMFilterLineEdit::sltRemoveFilterTerm);
         }
     }
@@ -208 +207 @@
     if (!m_pClearAllButton)
     {
-        m_pClearAllButton = new QToolButton(this);
+        m_pClearAllButton = new QIToolButton(this);
         if (m_pClearAllButton)
         {
             m_pClearAllButton->setIcon(m_pClearAllButton->style()->standardIcon(QStyle::SP_LineEditClearButton));
-            connect(m_pClearAllButton, &QToolButton::clicked, this, &UIVMFilterLineEdit::sltClearAll);
+            connect(m_pClearAllButton, &QIToolButton::clicked, this, &UIVMFilterLineEdit::sltClearAll);
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsGeneral.cpp

@@ -554 +554 @@
         {
             /* Configure widget: */
-            m_pNameAndSystemEditor->nameEditor()->setValidator(new QRegExpValidator(QRegExp(".+"), this));
+            //m_pNameAndSystemEditor->nameEditor()->setValidator(new QRegExpValidator(QRegExp(".+"), this));
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIApplianceEditorWidget.cpp

@@ -668 +668 @@
                    UIFilePathSelector *pFileChooser = new UIFilePathSelector(pParent);
                    pFileChooser->setMode(UIFilePathSelector::Mode_File_Save);
-                   pFileChooser->setResetEnabled(false);
+                   pFileChooser->setResetEnabled(true);
                    pEditor = pFileChooser;
                 break;

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UINameAndSystemEditor.cpp

@@ -31 +31 @@
 # include "UIFilePathSelector.h"
 # include "UINameAndSystemEditor.h"
+# include "UIVMNamePathSelector.h"
 
 /* COM includes: */
@@ -50 +51 @@
     , m_fSupportsHWVirtEx(false)
     , m_fSupportsLongMode(false)
-    , m_pLabelName(0)
     , m_pLabelFamily(0)
     , m_pLabelType(0)
     , m_pIconType(0)
-    , m_pEditorName(0)
-    , m_pEditorLocation(0)
+    , m_pNamePathLabel(0)
+    , m_pNamePathSelector(0)
     , m_pComboFamily(0)
     , m_pComboType(0)
@@ -65 +65 @@
 QString UINameAndSystemEditor::name() const
 {
-    if (!m_fChooseLocation)
-        return m_pEditorName->text();
-    else
-        return m_pEditorLocation->path();
+    if (!m_pNamePathSelector)
+        return QString();
+    return m_pNamePathSelector->name();
+}
+
+QString UINameAndSystemEditor::path() const
+{
+    if (!m_pNamePathSelector)
+        return vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder();
+    return m_pNamePathSelector->path();
 }
 
 void UINameAndSystemEditor::setName(const QString &strName)
 {
-    if (!m_fChooseLocation)
-        m_pEditorName->setText(strName);
-    else
-        m_pEditorLocation->setPath(strName);
+    if (!m_pNamePathSelector)
+        return;
+    m_pNamePathSelector->setName(strName);
 }
 
@@ -112 +117 @@
 void UINameAndSystemEditor::retranslateUi()
 {
-    m_pLabelName->setText(tr("N&ame:"));
     m_pLabelFamily->setText(tr("&Type:"));
     m_pLabelType->setText(tr("&Version:"));
-    if (!m_fChooseLocation)
-        m_pEditorName->setWhatsThis(tr("Holds the name of the virtual machine."));
-    else
-        m_pEditorLocation->setWhatsThis(tr("Holds the location of the virtual machine."));
+    m_pNamePathLabel->setText(tr("Path/Name:"));
+
     m_pComboFamily->setWhatsThis(tr("Selects the operating system family that "
                                     "you plan to install into this virtual machine."));
@@ -227 +229 @@
         pMainLayout->setContentsMargins(0, 0, 0, 0);
 
-        /* Create VM name label: */
-        m_pLabelName = new QLabel;
-        if (m_pLabelName)
-        {
-            /* Configure VM name label: */
-            m_pLabelName->setAlignment(Qt::AlignRight);
-            m_pLabelName->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
-            /* Add VM name label into main-layout: */
-            pMainLayout->addWidget(m_pLabelName, 0, 0);
-        }
-
-        if (!m_fChooseLocation)
-        {
-            /* Create VM name editor: */
-            m_pEditorName = new QLineEdit;
-            if (m_pEditorName)
-            {
-                /* Configure VM name editor: */
-                m_pEditorName->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
-                m_pLabelName->setBuddy(m_pEditorName);
-                /* Add VM name editor into main-layout: */
-                pMainLayout->addWidget(m_pEditorName, 0, 1, 1, 2);
-            }
-        }
-        else
-        {
-            /* Create VM location editor: */
-            m_pEditorLocation = new UIFilePathSelector;
-            if (m_pEditorLocation)
-            {
-                /* Configure advanced VM name editor: */
-                m_pEditorLocation->setResetEnabled(false);
-                m_pEditorLocation->setMode(UIFilePathSelector::Mode_File_Save);
-                m_pEditorLocation->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
-                m_pEditorLocation->setHomeDir(vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder());
-                m_pLabelName->setBuddy(m_pEditorLocation);
-                /* Add advanced VM name editor into main-layout: */
-                pMainLayout->addWidget(m_pEditorLocation, 0, 1, 1, 2);
-            }
+        m_pNamePathLabel = new QLabel;
+        if (m_pNamePathLabel)
+        {
+            m_pNamePathLabel->setAlignment(Qt::AlignRight);
+            m_pNamePathLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
+            pMainLayout->addWidget(m_pNamePathLabel, 0, 0, 1, 1);
+        }
+        m_pNamePathSelector = new UIVMNamePathSelector;
+        if (m_pNamePathSelector)
+        {
+            m_pNamePathSelector->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
+            pMainLayout->addWidget(m_pNamePathSelector, 0, 1, 1, 2);
         }
 
@@ -325 +300 @@
                 pLayoutIcon->addWidget(m_pIconType);
             }
-
             /* Add stretch to sub-layout: */
             pLayoutIcon->addStretch();
@@ -358 +332 @@
 {
     /* Prepare connections: */
-    if (!m_fChooseLocation)
-        connect(m_pEditorName, &QLineEdit::textChanged,
-                this, &UINameAndSystemEditor::sigNameChanged);
-    else
-        connect(m_pEditorLocation, &UIFilePathSelector::pathChanged,
-                this, &UINameAndSystemEditor::sigNameChanged);
+    connect(m_pNamePathSelector, &UIVMNamePathSelector::sigNameChanged,
+            this, &UINameAndSystemEditor::sigNameChanged);
     connect(m_pComboFamily, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
             this, &UINameAndSystemEditor::sltFamilyChanged);

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UINameAndSystemEditor.h

@@ -36 +36 @@
 class QString;
 class UIFilePathSelector;
+class UIVMNamePathSelector;
 
 /** QWidget subclass providing complex editor for basic VM parameters. */
@@ -58 +59 @@
     UINameAndSystemEditor(QWidget *pParent, bool fChooseLocation = false);
 
-    /** Returns the VM name editor. */
-    QLineEdit *nameEditor() const { return m_pEditorName; }
-    /** Returns the VM location editor. */
-    UIFilePathSelector *locationEditor() const { return m_pEditorLocation; }
-
     /** Returns the VM name. */
     QString name() const;
+    /** Returns path string selected by the user. */
+    QString path() const;
+
     /** Defines the VM @a strName. */
     void setName(const QString &strName);
@@ -86 +85 @@
     void sltTypeChanged(int iIndex);
 
-private:
+ private:
 
     /** @name Prepare cascade.
@@ -113 +112 @@
     bool                    m_fSupportsLongMode;
 
-    /** Holds the VM name label instance. */
-    QLabel                 *m_pLabelName;
     /** Holds the VM OS family label instance. */
     QLabel                 *m_pLabelFamily;
@@ -121 +118 @@
     /** Holds the VM OS type icon instance. */
     QLabel                 *m_pIconType;
-    /** Holds the VM name editor instance. */
-    QLineEdit              *m_pEditorName;
-    /** Holds the VM location editor instance. */
-    UIFilePathSelector     *m_pEditorLocation;
+
+    QLabel                 *m_pNamePathLabel;
+    UIVMNamePathSelector   *m_pNamePathSelector;
     /** Holds the VM OS family combo instance. */
     QComboBox              *m_pComboFamily;

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIVMNamePathSelector.cpp

@@ -25 +25 @@
 
 /* GUI includes: */
+# include "QIFileDialog.h"
 # include "QILineEdit.h"
 # include "QILabel.h"
+# include "QIToolButton.h"
+# include "UIIconPool.h"
 # include "UIVMNamePathSelector.h"
 # include "VBoxGlobal.h"
@@ -35 +38 @@
 #endif /* !VBOX_WITH_PRECOMPILED_HEADERS */
 
-
-
 UIVMNamePathSelector::UIVMNamePathSelector(QWidget *pParent /* = 0 */)
     : QIWithRetranslateUI<QWidget>(pParent)
@@ -43 +44 @@
     , m_pName(0)
     , m_pSeparator(0)
+    ,m_pFileDialogButton(0)
 {
     prepareWidgets();
+    retranslateUi();
 }
 
@@ -52 +55 @@
     CVirtualBox vbox = vboxGlobal().virtualBox();
     /* Get default machine folder: */
-    /*const QString strDefaultMachineFolder = */return vbox.GetSystemProperties().GetDefaultMachineFolder();
+    return vbox.GetSystemProperties().GetDefaultMachineFolder();
 
 }
@@ -65 +68 @@
     m_pMainLayout->setSpacing(0);
     setLayout(m_pMainLayout);
+
+    m_pFileDialogButton = new QIToolButton(this);
+    if (m_pFileDialogButton)
+    {
+        m_pMainLayout->addWidget(m_pFileDialogButton);
+        m_pFileDialogButton->setIcon(UIIconPool::iconSet(QString(":/sf_add_16px.png")));
+        connect(m_pFileDialogButton, &QIToolButton::clicked, this, &UIVMNamePathSelector::sltOpenPathSelector);
+    }
 
     m_pPath = new QILineEdit;
@@ -84 +95 @@
     {
         m_pMainLayout->addWidget(m_pName);
+        connect(m_pName, &QILineEdit::textChanged,
+                this, &UIVMNamePathSelector::sigNameChanged);
+
     }
 
@@ -121 +135 @@
 void UIVMNamePathSelector::retranslateUi()
 {
+    setToolTip(tr("The Virtual Machine files will be saved under ..."));
 }
+
+void UIVMNamePathSelector::sltOpenPathSelector()
+{
+
+    QString strSelectedPath = QIFileDialog::getExistingDirectory(m_pPath->text(), this,
+                                                                 QString("Select a parent folder for new Virtual Machine"));
+    if (!strSelectedPath.isEmpty())
+    {
+        m_pPath->setText(strSelectedPath);
+    }
+}

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIVMNamePathSelector.h

@@ -29 +29 @@
 class QILabel;
 class QILineEdit;
-
+class QIToolButton;
 
 class SHARED_LIBRARY_STUFF UIVMNamePathSelector : public QIWithRetranslateUI<QWidget>
@@ -36 +36 @@
 
 signals:
+
+    void sigNameChanged(const QString &strName);
 
 public:
@@ -55 +57 @@
 private slots:
 
+    void sltOpenPathSelector();
 
 private:
@@ -65 +68 @@
     QILineEdit  *m_pName;
     QILabel     *m_pSeparator;
+    QIToolButton *m_pFileDialogButton;
+
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/importappliance/UIWizardImportAppPageBasic1.cpp

@@ -25 +25 @@
 
 /* Local includes: */
+# include "QIRichTextLabel.h"
+# include "UIEmptyFilePathSelector.h"
+# include "UIFilePathSelector.h"
 # include "UIWizardImportAppPageBasic1.h"
 # include "UIWizardImportAppPageBasic2.h"
 # include "UIWizardImportApp.h"
 # include "VBoxGlobal.h"
-# include "UIEmptyFilePathSelector.h"
-# include "QIRichTextLabel.h"
+
+/* COM includes: */
+# include "CSystemProperties.h"
 
 #endif /* !VBOX_WITH_PRECOMPILED_HEADERS */
@@ -54 +58 @@
         pMainLayout->addWidget(m_pLabel);
         pMainLayout->addWidget(m_pFileSelector);
+
+
+        m_pDefaultFolderLabel = new QIRichTextLabel(this);
+        if (m_pDefaultFolderLabel)
+        {
+            pMainLayout->addWidget(m_pDefaultFolderLabel);
+        }
+
+        m_pDestinationFolderSelector = new UIFilePathSelector(this);
+        if (m_pDestinationFolderSelector)
+        {
+            m_pDestinationFolderSelector->setMode(UIFilePathSelector::Mode_Folder);
+            pMainLayout->addWidget(m_pDestinationFolderSelector);
+
+            m_pDestinationFolderSelector->setPath(vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder());
+            m_pDestinationFolderSelector->setResetEnabled(false);
+        }
+
         pMainLayout->addStretch();
     }
@@ -70 +92 @@
                                             "saved in the Open Virtualization Format (OVF). "
                                             "To continue, select the file to import below.</p>"));
+    m_pDefaultFolderLabel->setText(UIWizardImportApp::tr("Select a destionation folder for appliance"));
     m_pFileSelector->setChooseButtonToolTip(UIWizardImportApp::tr("Choose a virtual appliance file to import..."));
     m_pFileSelector->setFileDialogTitle(UIWizardImportApp::tr("Please choose a virtual appliance file to import"));
@@ -107 +130 @@
     return pImportApplianceWidget->isValid();
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/wizards/importappliance/UIWizardImportAppPageBasic1.h

@@ -24 +24 @@
 /* Forward declarations: */
 class UIEmptyFilePathSelector;
+class UIFilePathSelector;
 class QIRichTextLabel;
 
@@ -36 +37 @@
     /* Widgets: */
     UIEmptyFilePathSelector *m_pFileSelector;
+    QIRichTextLabel         *m_pDefaultFolderLabel;
+    UIFilePathSelector      *m_pDestinationFolderSelector;
 };
 
@@ -65 +68 @@
 
 #endif /* __UIWizardImportAppPageBasic1_h__ */
-

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageBasic1.cpp

@@ -217 +217 @@
 bool UIWizardNewVMPage1::createMachineFolder()
 {
+    if (!m_pNameAndSystemEditor)
+        return false;
     /* Cleanup previosly created folder if any: */
     if (machineFolderCreated() && !cleanupMachineFolder())
@@ -227 +229 @@
     CVirtualBox vbox = vboxGlobal().virtualBox();
     /* Get default machine folder: */
-    const QString strDefaultMachineFolder = vbox.GetSystemProperties().GetDefaultMachineFolder();
+    //const QString strMachineFolder = vbox.GetSystemProperties().GetDefaultMachineFolder();
+
     /* Compose machine filename: */
     const QString strMachineFilePath = vbox.ComposeMachineFilename(m_pNameAndSystemEditor->name(),
                                                                    m_strGroup,
                                                                    QString(),
-                                                                   strDefaultMachineFolder);
+                                                                   m_pNameAndSystemEditor->path());
     /* Compose machine folder/basename: */
     const QFileInfo fileInfo(strMachineFilePath);
@@ -315 +318 @@
 
     /* Translate widgets: */
-    m_pLabel->setText(UIWizardNewVM::tr("Please choose a descriptive name for the new virtual machine "
+    m_pLabel->setText(UIWizardNewVM::tr("Please choose a descriptive name and destination folder for the new virtual machine "
                                         "and select the type of operating system you intend to install on it. "
                                         "The name you choose will be used throughout VirtualBox "
@@ -340 +343 @@
     return createMachineFolder();
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageBasic1.h

@@ -58 +58 @@
     QString m_strMachineBaseName;
 
-    /* Widgets: */
+    /** Provides a path selector and a line edit field for path and name entry. */
     UINameAndSystemEditor *m_pNameAndSystemEditor;
 
-    /* Variables: */
+    /** Variables: */
     QString m_strGroup;
     bool m_fSupportsHWVirtEx;
@@ -107 +107 @@
 
 #endif // __UIWizardNewVMPageBasic1_h__
-