Changeset 72194 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

May 11, 2018 2:28:46 PM (7 years ago)

Author:

vboxsync

Message:

IEM: Comments, asserts, no real change.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -1825 +1825 @@
      * limit.
      */
+    /** @todo Robert Collins claims (The Segment Descriptor Cache, DDJ August
+     *        1998) that up to and including the Intel 486, far control
+     *        transfers in real mode set default CS attributes (0x93) and also
+     *        set a 64K segment limit. Starting with the Pentium, the
+     *        attributes and limit are left alone but the access rights are
+     *        ignored. We only implement the Pentium+ behavior.
+     *  */
     if (IEM_IS_REAL_OR_V86_MODE(pVCpu))
     {
+        Assert(enmEffOpSize == IEMMODE_16BIT || enmEffOpSize == IEMMODE_32BIT);
         if (offSeg > pCtx->cs.u32Limit)
         {
@@ -1994 +2002 @@
      * limit.
      */
+    /** @todo See comment for similar code in iemCImpl_FarJmp */
     if (IEM_IS_REAL_OR_V86_MODE(pVCpu))
     {
@@ -2247 +2256 @@
      * Real mode and V8086 mode are easy.
      */
+    /** @todo See comment for similar code in iemCImpl_FarJmp */
     if (IEM_IS_REAL_OR_V86_MODE(pVCpu))
     {
@@ -2266 +2276 @@
         pCtx->cs.u64Base    = (uint32_t)uNewCs << 4;
         pCtx->eflags.Bits.u1RF = 0;
-        /** @todo do we load attribs and limit as well? */
         if (cbPop)
             iemRegAddToRsp(pVCpu, pCtx, cbPop);