Changeset 72279 in vbox

Timestamp:

May 22, 2018 9:22:09 AM (7 years ago)

Author:

vboxsync

Message:

FE/Qt bugref:6769: Replacing the combined name/path selector widget in new vm wizard with seperate widgets

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• widgets/UIFilePathSelector.cpp (modified) (2 diffs)
• widgets/UIFilePathSelector.h (modified) (2 diffs)
• widgets/UINameAndSystemEditor.cpp (modified) (12 diffs)
• widgets/UINameAndSystemEditor.h (modified) (3 diffs)
• wizards/newvm/UIWizardNewVMPageBasic1.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp

@@ -176 +176 @@
 }
 
+void UIFilePathSelector::setDefaultPath(const QString &strDefaultPath)
+{
+    if (m_strDefaultPath == strDefaultPath)
+        return;
+    m_strDefaultPath = strDefaultPath;
+    if (currentIndex() == ResetId)
+        setPath(m_strDefaultPath);
+}
+
+const QString& UIFilePathSelector::defaultPath() const
+{
+    return m_strDefaultPath;
+}
+
 void UIFilePathSelector::setPath(const QString &strPath, bool fRefreshText /* = true */)
 {
@@ -321 +335 @@
         case ResetId:
         {
-            changePath(QString::null);
+            if (m_strDefaultPath.isEmpty())
+                changePath(QString::null);
+            else
+                changePath(m_strDefaultPath);
             break;
         }

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.h

@@ -112 +112 @@
     void setToolTip(const QString &strToolTip);
 
+    void setDefaultPath(const QString &strDefaultPath);
+    const QString& defaultPath() const;
+
 public slots:
 
@@ -204 +207 @@
     /** Holds the copy action instance. */
     QAction *m_pCopyAction;
+
+    /** Path is set to m_strDefaultPath when it is reset. */
+    QString m_strDefaultPath;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UINameAndSystemEditor.cpp

@@ -24 +24 @@
 # include <QGridLayout>
 # include <QLabel>
-# include <QLineEdit>
 # include <QVBoxLayout>
 
 /* GUI includes: */
+# include "QILineEdit.h"
 # include "VBoxGlobal.h"
 # include "UIFilePathSelector.h"
 # include "UINameAndSystemEditor.h"
-# include "UIVMNamePathSelector.h"
 
 /* COM includes: */
@@ -54 +53 @@
     , m_pLabelType(0)
     , m_pIconType(0)
-    , m_pNamePathLabel(0)
-    , m_pNamePathSelector(0)
+    , m_pNameLabel(0)
+    , m_pPathLabel(0)
+    , m_pNameLineEdit(0)
+    , m_pPathSelector(0)
     , m_pComboFamily(0)
     , m_pComboType(0)
@@ -65 +66 @@
 QString UINameAndSystemEditor::name() const
 {
-    if (!m_pNamePathSelector)
+    if (!m_pNameLineEdit)
         return QString();
-    return m_pNamePathSelector->name();
+    return m_pNameLineEdit->text();
 }
 
 QString UINameAndSystemEditor::path() const
 {
-    if (!m_pNamePathSelector)
+    if (!m_pPathSelector)
         return vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder();
-    return m_pNamePathSelector->path();
+    return m_pPathSelector->path();
 }
 
 void UINameAndSystemEditor::setName(const QString &strName)
 {
-    if (!m_pNamePathSelector)
+    if (!m_pNameLineEdit)
         return;
-    m_pNamePathSelector->setName(strName);
+    m_pNameLineEdit->setText(strName);
 }
 
@@ -119 +120 @@
     m_pLabelFamily->setText(tr("&Type:"));
     m_pLabelType->setText(tr("&Version:"));
-    m_pNamePathLabel->setText(tr("Path/Name:"));
+    m_pNameLabel->setText(tr("Name:"));
+    m_pPathLabel->setText(tr("Path:"));
 
     m_pComboFamily->setWhatsThis(tr("Selects the operating system family that "
@@ -229 +231 @@
         pMainLayout->setContentsMargins(0, 0, 0, 0);
 
-        m_pNamePathLabel = new QLabel;
-        if (m_pNamePathLabel)
-        {
-            m_pNamePathLabel->setAlignment(Qt::AlignRight);
-            m_pNamePathLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
-            pMainLayout->addWidget(m_pNamePathLabel, 0, 0, 1, 1);
-        }
-        m_pNamePathSelector = new UIVMNamePathSelector;
-        if (m_pNamePathSelector)
-        {
-            m_pNamePathSelector->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed);
-            m_pNamePathSelector->setPath(vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder());
-            pMainLayout->addWidget(m_pNamePathSelector, 0, 1, 1, 2);
-            setFocusProxy(m_pNamePathSelector);
+        m_pNameLabel = new QLabel;
+        if (m_pNameLabel)
+        {
+            m_pNameLabel->setAlignment(Qt::AlignRight);
+            m_pNameLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
+            pMainLayout->addWidget(m_pNameLabel, 0, 0, 1, 1);
+        }
+        m_pNameLineEdit = new QILineEdit;
+        if (m_pNameLineEdit)
+        {
+            pMainLayout->addWidget(m_pNameLineEdit, 0, 1, 1, 1);
+        }
+
+        m_pPathLabel = new QLabel;
+        if (m_pPathLabel)
+        {
+            m_pPathLabel->setAlignment(Qt::AlignRight);
+            pMainLayout->addWidget(m_pPathLabel, 1, 0, 1, 1);
+        }
+
+        m_pPathSelector = new UIFilePathSelector;
+        if (m_pPathSelector)
+        {
+            pMainLayout->addWidget(m_pPathSelector, 1, 1, 1, 1);
+            QString strDefaultMachineFolder = vboxGlobal().virtualBox().GetSystemProperties().GetDefaultMachineFolder();
+            m_pPathSelector->setPath(strDefaultMachineFolder);
+            m_pPathSelector->setDefaultPath(strDefaultMachineFolder);
         }
 
@@ -253 +268 @@
             m_pLabelFamily->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
             /* Add VM OS family label into main-layout: */
-            pMainLayout->addWidget(m_pLabelFamily, 1, 0);
+            pMainLayout->addWidget(m_pLabelFamily, 2, 0);
         }
 
@@ -264 +279 @@
             m_pLabelFamily->setBuddy(m_pComboFamily);
             /* Add VM OS family combo into main-layout: */
-            pMainLayout->addWidget(m_pComboFamily, 1, 1);
+            pMainLayout->addWidget(m_pComboFamily, 2, 1);
         }
 
@@ -275 +290 @@
             m_pLabelType->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
             /* Add VM OS type label into main-layout: */
-            pMainLayout->addWidget(m_pLabelType, 2, 0);
+            pMainLayout->addWidget(m_pLabelType, 3, 0);
         }
 
@@ -286 +301 @@
             m_pLabelType->setBuddy(m_pComboType);
             /* Add VM OS type combo into main-layout: */
-            pMainLayout->addWidget(m_pComboType, 2, 1);
+            pMainLayout->addWidget(m_pComboType, 3, 1);
         }
 
@@ -305 +320 @@
             pLayoutIcon->addStretch();
             /* Add sub-layout into main-layout: */
-            pMainLayout->addLayout(pLayoutIcon, 1, 2, 2, 1);
+            pMainLayout->addLayout(pLayoutIcon, 2, 2, 2, 1);
         }
     }
@@ -334 +349 @@
 {
     /* Prepare connections: */
-    connect(m_pNamePathSelector, &UIVMNamePathSelector::sigNameChanged,
+    connect(m_pNameLineEdit, &QILineEdit::textChanged,
             this, &UINameAndSystemEditor::sigNameChanged);
-    connect(m_pNamePathSelector, &UIVMNamePathSelector::sigPathChanged,
+    connect(m_pPathSelector, &UIFilePathSelector::pathChanged,
             this, &UINameAndSystemEditor::sigPathChanged);
     connect(m_pComboFamily, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
@@ -346 +361 @@
 void UINameAndSystemEditor::setNameFieldValidator(const QString &strValidatorString)
 {
-    if (!m_pNamePathSelector)
+    if (!m_pNameLineEdit)
         return;
-    m_pNamePathSelector->setNameFieldValidator(strValidatorString);
-}
-
-void UINameAndSystemEditor::setMachineFolder(const QString &strPath)
-{
-    if (!m_pNamePathSelector)
-        return;
-    m_pNamePathSelector->setToolTipText(strPath);
-}
+    m_pNameLineEdit->setValidator(new QRegExpValidator(QRegExp(strValidatorString), this));
+}

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UINameAndSystemEditor.h

@@ -33 +33 @@
 class QComboBox;
 class QLabel;
-class QLineEdit;
+class QILineEdit;
 class QString;
 class UIFilePathSelector;
-class UIVMNamePathSelector;
 
 /** QWidget subclass providing complex editor for basic VM parameters. */
@@ -74 +73 @@
 
     void setNameFieldValidator(const QString &strValidatorString);
-
-    /** Forwards the machine name to UIVMNamePathSelector member instance. */
-    void setMachineFolder(const QString &strPath);
 
 protected:
@@ -125 +121 @@
     QLabel                 *m_pIconType;
 
-    QLabel                 *m_pNamePathLabel;
-    UIVMNamePathSelector   *m_pNamePathSelector;
+    QLabel                 *m_pNameLabel;
+    QLabel                 *m_pPathLabel;
+    QILineEdit             *m_pNameLineEdit;
+    UIFilePathSelector     *m_pPathSelector;
     /** Holds the VM OS family combo instance. */
     QComboBox              *m_pComboFamily;

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageBasic1.cpp

@@ -234 +234 @@
     m_strMachineFolder = fileInfo.absolutePath();
     m_strMachineBaseName = fileInfo.completeBaseName();
-
-    if (m_pNameAndSystemEditor)
-        m_pNameAndSystemEditor->setMachineFolder(m_strMachineFolder);
 }