Changeset 72347 in vbox

Timestamp:

May 25, 2018 4:38:31 PM (7 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9049: Do not just hang around or return late Main error about missed VM name/id for Runtime UI since we know that prematurely; show message-box with proper usage instead.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/globals

Files:

• UIMessageCenter.cpp (modified) (1 diff)
• UIMessageCenter.h (modified) (1 diff)
• UIStarter.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.cpp

@@ -400 +400 @@
           tr("<p>Cannot start the VirtualBox Manager due to local restrictions.</p>"
              "<p>The application will now terminate.</p>"));
+}
+
+void UIMessageCenter::cannotStartRuntime() const
+{
+    /* Prepare error string: */
+    const QString strError = tr("<p>You must specify a machine to start, using the command line.</p><p>%1</p>",
+                                "There will be a usage text passed as argument.");
+
+    /* Prepare Usage, it can change in future: */
+    const QString strTable = QString("<table cellspacing=0 style='white-space:pre'>%1</table>");
+    const QString strUsage = tr("<tr>"
+                                "<td>Usage: VirtualBoxVM --startvm &lt;name|UUID&gt;</td>"
+                                "</tr>"
+                                "<tr>"
+                                "<td>Starts the VirtualBox virtual machine with the given "
+                                "name or unique identifier (UUID).</td>"
+                                "</tr>");
+
+    /* Show error: */
+    alert(0, MessageType_Error, strError.arg(strTable.arg(strUsage)));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -235 +235 @@
 #endif /* RT_OS_LINUX */
     void cannotStartSelector() const;
+    void cannotStartRuntime() const;
     void showBetaBuildWarning() const;
     void showExperimentalBuildWarning() const;

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIStarter.cpp

@@ -152 +152 @@
             return QApplication::quit();
     }
+# if defined(VBOX_GUI_WITH_SHARED_LIBRARY) && defined(VBOX_RUNTIME_UI)
+    else
+    {
+        /* Show the error message otherwise: */
+        msgCenter().cannotStartRuntime();
+        return QApplication::quit();
+    }
+# endif /* VBOX_GUI_WITH_SHARED_LIBRARY && VBOX_RUNTIME_UI */
 #endif /* !VBOX_GUI_WITH_SHARED_LIBRARY || VBOX_RUNTIME_UI */
 }