Changeset 72369 in vbox for trunk/src

Timestamp:

May 28, 2018 8:02:03 PM (7 years ago)

Author:

vboxsync

Message:

nit (no else after return). bugref:9188

Location:

trunk/src/VBox/Runtime/common/asn1

Files:

• asn1-ut-integer-decode.cpp (modified) (1 diff)
• asn1-ut-integer.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/asn1/asn1-ut-integer-decode.cpp

@@ -69 +69 @@
                 return VINF_SUCCESS;
             }
-            else
-                rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_INTEGER_ENCODING,
-                                         "%s: Invalid integer length, exepcted more than 0: %#x",
-                                         pszErrorTag, pThis->Asn1Core.cb);
+            rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_INTEGER_ENCODING,
+                                     "%s: Invalid integer length, exepcted more than 0: %#x",
+                                     pszErrorTag, pThis->Asn1Core.cb);
         }
     }

trunk/src/VBox/Runtime/common/asn1/asn1-ut-integer.cpp

@@ -67 +67 @@
     switch (pThis->Asn1Core.cb)
     {
-        default:
+        default: AssertBreak(pThis->Asn1Core.cb > 8); /* paranoia */
         case 8: pThis->uValue.u |= (uint64_t)pThis->Asn1Core.uData.pu8[offLast - 7] << 56; RT_FALL_THRU();
         case 7: pThis->uValue.u |= (uint64_t)pThis->Asn1Core.uData.pu8[offLast - 6] << 48; RT_FALL_THRU();