Changeset 72393 in vbox for trunk/src/VBox

Timestamp:

May 30, 2018 3:24:13 PM (7 years ago)

Author:

vboxsync

Message:

FE/Qt: fix X11 host keyboard repeat handling again.
bugref:9189: FE/Qt: handle key repeat correctly in Qt5/X11 code
X11 has a rather idiosyncratic way of handling key repeat: it sends key up
and key down events, which confuses our X11 host keyboard handling. This was
reported in public ticket 1296 and fixed by manually suppressing the key up
events, but the fix got lost during the migration to Qt5, which required
converting Xlib code to (mainly) XCB.
Xkb added a way to suppress this idiosyncratic behaviour, see
​https://stackoverflow.com/a/2102689
This change implements that instead of the old fix.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIKeyboardHandler.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIKeyboardHandler.cpp

@@ -828 +828 @@
             }
 
-//            /* Fix for http://www.virtualbox.org/ticket/1296:
-//             * when X11 sends events for repeated keys, it always inserts an XKeyRelease before the XKeyPress. */
-//            XEvent returnEvent;
-//            if ((pEvent->type == XKeyRelease) && (XCheckIfEvent(pEvent->xkey.display, &returnEvent,
-//                UIKeyboardHandlerCompEvent, (XPointer)pEvent) == True))
-//            {
-//                XPutBackEvent(pEvent->xkey.display, &returnEvent);
-//                fResult = true;
-//                break;
-//            }
-
             /* Calculate flags: */
             int iflags = 0;
@@ -1029 +1018 @@
     /* Initialize the X keyboard subsystem: */
     initMappedX11Keyboard(QX11Info::display(), gEDataManager->remappedScanCodes());
+    /* Fix for http://www.virtualbox.org/ticket/1296:
+     * when X11 sends events for repeated keys, it always inserts an XKeyRelease
+     * before the XKeyPress. */
+    /* Disable key release events during key auto-repeat: */
+    XkbSetDetectableAutoRepeat(QX11Info::display(), True, NULL);
 #endif /* VBOX_WS_X11 */