Changeset 72468 in vbox for trunk/src/VBox/VMM

Timestamp:

Jun 7, 2018 9:38:33 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

122953

Message:

IEM: Missing IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX() for svm instructions. Added comment to vmcall and vmmcall explaining why no CPU features are checked when decoding. bugref:9044

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h (modified) (9 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h

@@ -304 +304 @@
 {
     IEMOP_MNEMONIC(vmcall, "vmcall");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the VMX instructions. ASSUMING no lock for now. */
+
+    /* Note! We do not check any CPUMFEATURES::fSvm here as we (GIM) generally
+             want all hypercalls regardless of instruction used, and if a
+             hypercall isn't handled by GIM or HMSvm will raise an #UD.
+             (NEM/win makes ASSUMPTIONS about this behavior.)  */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_vmcall);
 }
@@ -437 +443 @@
 {
     IEMOP_MNEMONIC(vmrun, "vmrun");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_vmrun);
 }
@@ -447 +454 @@
 {
     IEMOP_MNEMONIC(vmmcall, "vmmcall");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
+
+    /* Note! We do not check any CPUMFEATURES::fSvm here as we (GIM) generally
+             want all hypercalls regardless of instruction used, and if a
+             hypercall isn't handled by GIM or HMSvm will raise an #UD.
+             (NEM/win makes ASSUMPTIONS about this behavior.) */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_vmmcall);
 }
@@ -455 +468 @@
 {
     IEMOP_MNEMONIC(vmload, "vmload");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_vmload);
 }
@@ -467 +481 @@
 {
     IEMOP_MNEMONIC(vmsave, "vmsave");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_vmsave);
 }
@@ -479 +494 @@
 {
     IEMOP_MNEMONIC(stgi, "stgi");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_stgi);
 }
@@ -491 +507 @@
 {
     IEMOP_MNEMONIC(clgi, "clgi");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_clgi);
 }
@@ -503 +520 @@
 {
     IEMOP_MNEMONIC(invlpga, "invlpga");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_invlpga);
 }
@@ -515 +533 @@
 {
     IEMOP_MNEMONIC(skinit, "skinit");
+    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); /** @todo check prefix effect on the SVM instructions. ASSUMING no lock for now. */
     return IEM_MC_DEFER_TO_CIMPL_0(iemCImpl_skinit);
 }