Changeset 72480 in vbox for trunk/src/VBox/Main

Timestamp:

Jun 8, 2018 10:19:45 AM (7 years ago)

Author:

vboxsync

Message:

HostDnsService: there's no point to delay a call to updateInfo().

Location:

trunk/src/VBox/Main/src-server

Files:

• HostDnsService.cpp (modified) (8 diffs)
• HostDnsService.h (modified) (1 diff)

trunk/src/VBox/Main/src-server/HostDnsService.cpp

@@ -102 +102 @@
       : virtualbox(aParent),
         monitor(aMonitor),
-        info(NULL),
-        fModified(true)
+        info(NULL)
     {}
 
@@ -118 +117 @@
     HostDnsMonitor *monitor;
     HostDnsInformation *info;
-    bool fModified;
 };
 
@@ -329 +327 @@
 
 
-void HostDnsMonitorProxy::notify() const
+void HostDnsMonitorProxy::notify()
 {
     LogRel(("HostDnsMonitorProxy::notify\n"));
-    m->fModified = true;
+    updateInfo();
     m->virtualbox->i_onHostNameResolutionConfigurationChange();
 }
@@ -340 +338 @@
     AssertReturn(m && m->info, E_FAIL);
     RTCLock grab(m_LockMtx);
-
-    if (m->fModified)
-        updateInfo();
 
     LogRel(("HostDnsMonitorProxy::GetNameServers:\n"));
@@ -357 +352 @@
     RTCLock grab(m_LockMtx);
 
-    if (m->fModified)
-        updateInfo();
-
     LogRel(("HostDnsMonitorProxy::GetDomainName: %s\n",
             m->info->domain.empty() ? "no domain set" : m->info->domain.c_str()));
@@ -372 +364 @@
     AssertReturn(m && m->info, E_FAIL);
     RTCLock grab(m_LockMtx);
-
-    if (m->fModified)
-        updateInfo();
 
     LogRel(("HostDnsMonitorProxy::GetSearchStrings:\n"));
@@ -397 +386 @@
 void HostDnsMonitorProxy::updateInfo()
 {
+    RTCLock grab(m_LockMtx);
+
     HostDnsInformation *info = new HostDnsInformation(m->monitor->getInfo());
     HostDnsInformation *old = m->info;
@@ -405 +396 @@
         delete old;
     }
-
-    m->fModified = false;
 }
 

trunk/src/VBox/Main/src-server/HostDnsService.h

@@ -96 +96 @@
     ~HostDnsMonitorProxy();
     void init(VirtualBox *virtualbox);
-    void notify() const;
+    void notify();
 
     VirtualBox *getVirtualBox() const;